From: Richard Henderson <rth@cygnus.com>
To: Jakub Jelinek <jj@sunsite.ms.mff.cuni.cz>
Cc: ian@cygnus.com, binutils@sourceware.cygnus.com,
"David S. Miller" <davem@redhat.com>
Subject: Re: [PATCH] Support for R_SPARC_OLO10 relocations
Date: Thu, 08 Jul 1999 16:09:00 -0000 [thread overview]
Message-ID: <19990708160922.B17592@cygnus.com> (raw)
In-Reply-To: <19990705174729.B1736@mff.cuni.cz>
On Mon, Jul 05, 1999 at 05:47:29PM +0200, Jakub Jelinek wrote:
> * include/elf/sparc.h (ELF64_R_TYPE_DATA): Sign extend the value.
> (ELF64_R_TYPE_INFO): Mask out all but low 24 bits of data.
Actually, these macros macros made assumptions about the size
of bfd_vma. They did before your patch too, so I don't hold
that against you, but that doesn't mean it doesn't want fixing.
Plus I went ahead and killed DT_SPARC_PLTFMT. It was me that
added it in the first place, before we had a real ABI.
I committed this.
r~
Index: sparc.h
===================================================================
RCS file: /cvs/binutils/binutils/include/elf/sparc.h,v
retrieving revision 1.2
diff -c -p -d -r1.2 sparc.h
*** sparc.h 1999/06/10 21:00:53 1.2
--- sparc.h 1999/07/08 23:00:24
*************** END_RELOC_NUMBERS
*** 138,158 ****
/* Relocation macros. */
! #define ELF64_R_TYPE_DATA(info) (((bfd_vma) (info) << 32) >> 40)
! #define ELF64_R_TYPE_ID(info) (((bfd_vma) (info) << 56) >> 56)
! #define ELF64_R_TYPE_INFO(data, type) (((bfd_vma) (data) << 8) \
! + (bfd_vma) (type))
!
! #define DT_SPARC_REGISTER 0x70000001
! /*
! * FIXME: NOT ABI -- GET RID OF THIS
! * Defines the format used by the .plt. Currently defined values are
! * 0 -- reserved to SI
! * 1 -- absolute address in .got.plt
! * 2 -- got-relative address in .got.plt
! */
! #define DT_SPARC_PLTFMT 0x70000001
#endif /* _ELF_SPARC_H */
--- 138,152 ----
/* Relocation macros. */
! #define ELF64_R_TYPE_DATA(info) \
! (((bfd_signed_vma)((info) >> 8) ^ 0x800000) - 0x800000)
! #define ELF64_R_TYPE_ID(info) \
! ((info) & 0xff)
! #define ELF64_R_TYPE_INFO(data, type) \
! (((bfd_vma) ((data) & 0xffffff) << 8) | (bfd_vma) (type))
! /* Values for Elf64_Dyn.d_tag. */
! #define DT_SPARC_REGISTER 0x70000001
#endif /* _ELF_SPARC_H */
next prev parent reply other threads:[~1999-07-08 16:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-07-05 8:47 Jakub Jelinek
1999-07-08 15:50 ` Richard Henderson
1999-07-09 5:40 ` [PATCH] My current SPARC patches Jakub Jelinek
1999-07-16 14:34 ` Richard Henderson
1999-07-08 16:09 ` Richard Henderson [this message]
1999-07-08 20:02 ` [PATCH] Support for R_SPARC_OLO10 relocations Ian Lance Taylor
1999-07-08 23:34 ` Jakub Jelinek
1999-07-09 9:52 ` Ian Lance Taylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19990708160922.B17592@cygnus.com \
--to=rth@cygnus.com \
--cc=binutils@sourceware.cygnus.com \
--cc=davem@redhat.com \
--cc=ian@cygnus.com \
--cc=jj@sunsite.ms.mff.cuni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).