From: hjl@lucon.org (H.J. Lu)
To: mark@codesourcery.com (Mark Mitchell)
Cc: ian@zembu.com, binutils@sourceware.cygnus.com
Subject: Re: A 32bit BFD patch
Date: Sun, 11 Jul 1999 09:37:00 -0000 [thread overview]
Message-ID: <19990711163721.CC7E457BA@ocean.lucon.org> (raw)
In-Reply-To: <19990711093401Q.mitchell@codesourcery.com>
> Index: elf32-mips.c
> ===================================================================
> RCS file: /cvs/binutils/binutils/bfd/elf32-mips.c,v
> retrieving revision 1.14
> diff -u -p -r1.14 elf32-mips.c
> --- elf32-mips.c 1999/07/07 19:23:19 1.14
> +++ elf32-mips.c 1999/07/11 16:23:50
> @@ -269,10 +269,17 @@ typedef enum {
> : bfd_put_32 (abfd, val, ptr))
>
> /* Add a dynamic symbol table-entry. */
> +#ifdef BFD64
> #define MIPS_ELF_ADD_DYNAMIC_ENTRY(info, tag, val) \
> (ABI_64_P (elf_hash_table (info)->dynobj) \
> ? bfd_elf64_add_dynamic_entry (info, tag, val) \
> : bfd_elf32_add_dynamic_entry (info, tag, val))
> +#else
> +#define MIPS_ELF_ADD_DYNAMIC_ENTRY(info, tag, val) \
> + (ABI_64_P (elf_hash_table (info)->dynobj) \
> + ? bfd_elf64_add_dynamic_entry (info, tag, val) \
> + : (abort (), false))
> +#endif
>
This one doesn't look right. Did you mean
#define MIPS_ELF_ADD_DYNAMIC_ENTRY(info, tag, val) \
(ABI_64_P (elf_hash_table (info)->dynobj) \
? (abort (), false) \
: bfd_elf32_add_dynamic_entry (info, tag, val))
H.J.
next prev parent reply other threads:[~1999-07-11 9:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-07-10 10:47 H.J. Lu
1999-07-10 17:53 ` Ian Lance Taylor
1999-07-10 23:47 ` Mark Mitchell
1999-07-11 0:26 ` H.J. Lu
1999-07-11 9:30 ` Mark Mitchell
1999-07-11 9:37 ` H.J. Lu [this message]
1999-07-11 9:46 ` Mark Mitchell
1999-07-11 19:48 ` Ian Lance Taylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19990711163721.CC7E457BA@ocean.lucon.org \
--to=hjl@lucon.org \
--cc=binutils@sourceware.cygnus.com \
--cc=ian@zembu.com \
--cc=mark@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).