From mboxrd@z Thu Jan  1 00:00:00 1970
From: hjl@lucon.org (H.J. Lu)
To: mark@codesourcery.com (Mark Mitchell)
Cc: ian@zembu.com, binutils@sourceware.cygnus.com
Subject: Re: A 32bit BFD patch
Date: Sun, 11 Jul 1999 09:37:00 -0000
Message-id: <19990711163721.CC7E457BA@ocean.lucon.org>
References: <19990711093401Q.mitchell@codesourcery.com>
X-SW-Source: 1999-q3/msg00132.html

> Index: elf32-mips.c
> ===================================================================
> RCS file: /cvs/binutils/binutils/bfd/elf32-mips.c,v
> retrieving revision 1.14
> diff -u -p -r1.14 elf32-mips.c
> --- elf32-mips.c	1999/07/07 19:23:19	1.14
> +++ elf32-mips.c	1999/07/11 16:23:50
> @@ -269,10 +269,17 @@ typedef enum {
>     : bfd_put_32 (abfd, val, ptr))
>  
>  /* Add a dynamic symbol table-entry.  */
> +#ifdef BFD64
>  #define MIPS_ELF_ADD_DYNAMIC_ENTRY(info, tag, val) \
>    (ABI_64_P (elf_hash_table (info)->dynobj)	   \
>     ? bfd_elf64_add_dynamic_entry (info, tag, val)  \
>     : bfd_elf32_add_dynamic_entry (info, tag, val))
> +#else
> +#define MIPS_ELF_ADD_DYNAMIC_ENTRY(info, tag, val) \
> +  (ABI_64_P (elf_hash_table (info)->dynobj)	   \
> +   ? bfd_elf64_add_dynamic_entry (info, tag, val)  \
> +   : (abort (), false))
> +#endif
>  

This one doesn't look right. Did you mean

#define MIPS_ELF_ADD_DYNAMIC_ENTRY(info, tag, val) \
  (ABI_64_P (elf_hash_table (info)->dynobj)	   \
   ? (abort (), false) 				   \
   : bfd_elf32_add_dynamic_entry (info, tag, val))


H.J.