From: Richard Henderson <rth@cygnus.com>
To: Mark Mitchell <mark@codesourcery.com>
Cc: binutils@sourceware.cygnus.com
Subject: Re: .dynsym pain
Date: Wed, 14 Jul 1999 02:17:00 -0000 [thread overview]
Message-ID: <19990714021747.B7300@cygnus.com> (raw)
In-Reply-To: <19990714010018W.mitchell@codesourcery.com>
On Wed, Jul 14, 1999 at 01:00:18AM -0700, Mark Mitchell wrote:
> But, I'm nervous about the need for *two* sorts. The reason for the
> first sort is to calculate the size of the GOT:
Yep.
> So, if we resort, and the GOT gets bigger, that's very bad. I assume
> that this can't happen.
It surely shouldn't. It should only shrink.
> Perhaps you could add an assertion to check
> that this situation does not occur? Just checking `elf_hash_table
> (info)->dynsymcount - g->global_gotsym->dynindx' before and after the
> second sort should do it.
Yes, I'll add something. I don't think that'll do it since
the versioning code doesn't decrement dynsymcount, so I just
write a new value at the end of renumber_dynsym.
But saving a g->global_gotsize should do the trick.
r~
next prev parent reply other threads:[~1999-07-14 2:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-07-12 18:05 Richard Henderson
1999-07-12 20:37 ` Ian Lance Taylor
1999-07-13 18:20 ` Richard Henderson
1999-07-12 21:57 ` Mark Mitchell
1999-07-13 19:12 ` Richard Henderson
1999-07-13 22:42 ` Mark Mitchell
1999-07-14 0:20 ` Richard Henderson
1999-07-14 1:03 ` Mark Mitchell
1999-07-14 2:17 ` Richard Henderson [this message]
1999-07-14 8:35 ` Mark Mitchell
1999-07-14 17:04 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19990714021747.B7300@cygnus.com \
--to=rth@cygnus.com \
--cc=binutils@sourceware.cygnus.com \
--cc=mark@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).