From: hjl@varesearch.com (H.J. Lu)
To: nickc@cygnus.com
Cc: ian@zembu.com (Ian Lance Taylor), binutils@sourceware.cygnus.com
Subject: A COFF patch
Date: Mon, 19 Jul 1999 10:29:00 -0000 [thread overview]
Message-ID: <19990719172937.1926E3FC1@varesearch.com> (raw)
Hi, Nick,
I don't know what you did to COFF. It seems that your change breaks
"configure --enable-targets=all". This patch seems to fix it. It may
not cover everything nor the best fix. But it is good enough for me
to pass "make check" when I use "configure --enable-targets=all" on
Linux/x86.
Thanks.
--
H.J. Lu (hjl@gnu.org)
---
Mon Jul 19 10:24:55 1998 H.J. Lu (hjl@gnu.org)
* coffgen.c (coff_object_p): Check if we are fed with a COFF
file.
Index: coffgen.c
===================================================================
RCS file: /work/cvs/gnu/binutils/bfd/coffgen.c,v
retrieving revision 1.1.1.2
diff -u -p -r1.1.1.2 coffgen.c
--- coffgen.c 1999/07/12 17:13:25 1.1.1.2
+++ coffgen.c 1999/07/19 17:21:51
@@ -254,6 +254,11 @@ coff_object_p (abfd)
struct internal_filehdr internal_f;
struct internal_aouthdr internal_a;
+ /* We may be called as bfd_check_format. We have to be prepared to
+ deal with everything. */
+ if (!coff_backend_info(abfd))
+ return 0;
+
/* figure out how much to read */
filhsz = bfd_coff_filhsz (abfd);
aoutsz = bfd_coff_aoutsz (abfd);
next reply other threads:[~1999-07-19 10:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-07-19 10:29 H.J. Lu [this message]
1999-07-19 11:42 ` Ian Lance Taylor
1999-07-19 11:45 ` H.J. Lu
1999-07-19 12:37 ` Ian Lance Taylor
1999-07-20 1:50 Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19990719172937.1926E3FC1@varesearch.com \
--to=hjl@varesearch.com \
--cc=binutils@sourceware.cygnus.com \
--cc=ian@zembu.com \
--cc=nickc@cygnus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).