From mboxrd@z Thu Jan  1 00:00:00 1970
From: hjl@varesearch.com (H.J. Lu)
To: ian@zembu.com (Ian Lance Taylor)
Cc: nickc@cygnus.com, binutils@sourceware.cygnus.com
Subject: Re: A COFF patch
Date: Mon, 19 Jul 1999 11:45:00 -0000
Message-id: <19990719184440.766313FC1@varesearch.com>
References: <19990719184128.3456.qmail@daffy.airs.com>
X-SW-Source: 1999-q3/msg00260.html

> 
>    Date: Mon, 19 Jul 1999 10:29:37 -0700 (PDT)
>    From: hjl@varesearch.com (H.J. Lu)
> 
>    I don't know what you did to COFF. It seems that your change breaks
>    "configure --enable-targets=all". This patch seems to fix it. It may
>    not cover everything nor the best fix. But it is good enough for me
>    to pass "make check" when I use "configure --enable-targets=all" on
>    Linux/x86.
> 
>    Mon Jul 19 10:24:55 1998  H.J. Lu  (hjl@gnu.org)
> 
> 	   * coffgen.c (coff_object_p): Check if we are fed with a COFF
> 	   file.
> 
> This patch is definitely wrong.  Nick, please don't check it in.
> 
> It is simply wrong for coff_object_p to be called with abfd->xvec set
> to any bfd_target structure which has a NULL backend_data field.  We
> need to understand why that is happening.  Nick added a field to
> bfd_target; perhaps the problem is simply that he somehow forgot to
> update one of the many structure initializations.
> 

Just configure binutils with "--enable-targets=all" on Linux/x86
and watch for "make check". Many tests failed on me.


-- 
H.J. Lu (hjl@gnu.org)