From: Ian Lance Taylor <ian@zembu.com>
To: snowball3@bigfoot.com
Cc: binutils@sourceware.cygnus.com
Subject: Re: Patch for obj-coff.c
Date: Fri, 30 Jul 1999 10:07:00 -0000 [thread overview]
Message-ID: <19990730170643.14867.qmail@daffy.airs.com> (raw)
In-Reply-To: <199907301649.QAA25978@out5.ibm.net>
From: "Mark E." <snowball3@bigfoot.com>
Date: Fri, 30 Jul 1999 12:50:19 -0400
This patch seems to fix the debugging problem under BFD assember caused by not
creating an endndx AUX record. I believe the Win32 ports use stabs by default, so
it's no wonder no one ever noticed.
Thanks for tracking this down.
Looking at this code, I don't why see it needs to ever check *punt.
Could you try out this patch and see if you ever get the warning?
Ian
--- config/obj-coff.c.~4~ Sat Jun 26 22:32:49 1999
+++ config/obj-coff.c Fri Jul 30 13:02:26 1999
@@ -1091,9 +1091,13 @@ coff_frob_symbol (symp, punt)
set_end = NULL;
}
- if (next_set_end != NULL
- && ! *punt)
- set_end = next_set_end;
+ if (next_set_end != NULL)
+ {
+ if (set_end != NULL)
+ as_warn ("Warning: internal error: forgetting to set endndx of %s",
+ S_GET_NAME (set_end));
+ set_end = next_set_end;
+ }
if (! *punt
&& S_GET_STORAGE_CLASS (symp) == C_FCN
prev parent reply other threads:[~1999-07-30 10:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-07-30 9:50 Mark E.
1999-07-30 10:07 ` Ian Lance Taylor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19990730170643.14867.qmail@daffy.airs.com \
--to=ian@zembu.com \
--cc=binutils@sourceware.cygnus.com \
--cc=snowball3@bigfoot.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).