From: Geoff Keating <geoffk@ozemail.com.au>
To: gavin@cygnus.com, Mark Mitchell <mark@codesourcery.com>,
binutils@sourceware.cygnus.com
Subject: Reloc changes to bfd/elf32-mips.c
Date: Mon, 27 Sep 1999 04:24:00 -0000 [thread overview]
Message-ID: <199909271119.VAA01664@gluttony.geoffk.wattle.id.au> (raw)
This has most impact on C++.
I'm not sure exactly who can approve changes to the sourceware
binutils; if Gavin or Mark could do this (at least for MIPS), it'd be
good to know as the current sequence of patches will not be the last.
I'm also not sure who can check stuff in.
Anyway, is the patch OK?
--
Geoffrey Keating <geoffk@cygnus.com>
===File ~/patches/cygnus/tx49-bin-relax.patch===============
md5sum: 5e8722c506533dd1 fa69a2dbb712c6f2 162776
Index: binutils/gas/ChangeLog
0a
Mon Sep 20 18:17:41 1999 Geoffrey Keating <geoffk@cygnus.com>
* config/tc-mips.c (nopic_need_relax): Allow for the
.sdata.foo sections generated by -fdata-sections,
and for the .gnu.linkonce.s sections generated by C++.
.
Changed files:
binutils/gas/ChangeLog
binutils/gas/config/tc-mips.c
md5sum: 1badbcc38e94c005 36b310b7eac9fea2 333029
--- /sloth/disk0/co/binutils-mainline/binutils/gas/config/tc-mips.c Wed Aug 4 01:22:38 1999
+++ binutils/gas/config/tc-mips.c Mon Sep 27 20:15:59 1999
@@ -294,8 +294,9 @@ static int g_switch_seen = 0;
better.
This function can only provide a guess, but it seems to work for
- gcc output. If it guesses wrong, the only loss should be in
- efficiency; it shouldn't introduce any bugs.
+ gcc output. It needs to guess right for gcc, otherwise gcc
+ will put what it thinks is a GP-relative instruction in a branch
+ delay slot.
I don't know if a fix is needed for the SVR4_PIC mode. I've only
fixed it for the non-PIC mode. KR 95/04/07 */
@@ -10625,7 +10626,9 @@ nopic_need_relax (sym, before_relaxing)
assert (strcmp (segname, ".lit8") != 0
&& strcmp (segname, ".lit4") != 0);
change = (strcmp (segname, ".sdata") != 0
- && strcmp (segname, ".sbss") != 0);
+ && strcmp (segname, ".sbss") != 0
+ && strncmp (segname, ".sdata.", 7) != 0
+ && strncmp (segname, ".gnu.linkonce.s.", 16) != 0);
}
return change;
}
============================================================
next reply other threads:[~1999-09-27 4:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-09-27 4:24 Geoff Keating [this message]
1999-09-27 18:25 ` Ian Lance Taylor
1999-09-27 4:30 Geoff Keating
1999-09-27 12:37 ` Mark Mitchell
1999-09-28 0:54 ` Mark Mitchell
1999-09-28 6:57 ` Ian Lance Taylor
1999-09-28 20:32 ` Geoff Keating
1999-09-28 20:57 ` Ian Lance Taylor
1999-09-28 21:52 ` Geoff Keating
1999-09-28 22:03 ` Ian Lance Taylor
1999-10-06 19:21 ` Geoff Keating
1999-10-06 19:35 ` Ian Lance Taylor
1999-10-06 20:39 ` Geoff Keating
1999-10-06 20:53 ` Ian Lance Taylor
1999-10-07 4:47 ` Geoff Keating
1999-10-07 7:28 ` Ian Lance Taylor
1999-10-07 9:17 ` Mark Mitchell
1999-09-28 22:16 ` Mark Mitchell
1999-09-29 8:25 ` Ian Lance Taylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199909271119.VAA01664@gluttony.geoffk.wattle.id.au \
--to=geoffk@ozemail.com.au \
--cc=binutils@sourceware.cygnus.com \
--cc=gavin@cygnus.com \
--cc=mark@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).