From: Geoff Keating <geoffk@ozemail.com.au>
To: ian@zembu.com
Cc: rth@cygnus.com, binutils@sourceware.cygnus.com
Subject: Re: Trivial patch for elf.sc in ld.
Date: Mon, 27 Sep 1999 21:30:00 -0000 [thread overview]
Message-ID: <199909280353.NAA01148@gluttony.geoffk.wattle.id.au> (raw)
In-Reply-To: <19990928012326.5064.qmail@daffy.airs.com>
> Date: 27 Sep 1999 21:23:26 -0400
> From: Ian Lance Taylor <ian@zembu.com>
> CC: rth@cygnus.com, binutils@sourceware.cygnus.com
>
> Date: Mon, 27 Sep 1999 21:11:24 +1000
> From: Geoff Keating <geoffk@ozemail.com.au>
>
> I think this is really self-explanatory. OK to commit?
>
> Wed Sep 22 12:42:36 1999 Geoffrey Keating <geoffk@cygnus.com>
>
> * scripttempl/elf.sc (.sdata): Include .gnu.linkonce.s.* sections
> in .sdata too.
>
> This only makes sense if the compiler has been modified to generate
> such sections.
>
> Note that for the other linkonce sections the default ELF linker
> script uses names like .gnu.linkonce.d*. That is, it does not assume
> a dot after the 'd'.
>
> If the compiler generates .gnu.linkonce sections for .sdata sections,
> and the trailing dot is correct, then I have no objection to this
> patch.
It does seem to be correct. From gcc/config/mips/elf.h:
{ ".text.", ".gnu.linkonce.t." }, \
{ ".rodata.", ".gnu.linkonce.r." }, \
{ ".data.", ".gnu.linkonce.d." }, \
{ ".sdata.", ".gnu.linkonce.s." } \
and similarly in gcc/config/elfos.h. So the dot is always there.
Probably the other places should have the dot too, in case we ever run
out of letters, but it's not exactly an urgent problem...
OK, I'll commit it.
--
Geoffrey Keating <geoffk@cygnus.com>
next prev parent reply other threads:[~1999-09-27 21:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-09-27 4:23 Geoff Keating
1999-09-27 18:24 ` Ian Lance Taylor
1999-09-27 21:30 ` Geoff Keating [this message]
1999-09-27 21:42 ` Richard Henderson
1999-09-28 6:26 ` Ian Lance Taylor
1999-09-28 20:49 ` Geoff Keating
1999-09-28 20:59 ` Ian Lance Taylor
1999-09-28 21:50 ` Geoff Keating
1999-09-28 21:52 ` Ian Lance Taylor
1999-10-06 19:17 ` Geoff Keating
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199909280353.NAA01148@gluttony.geoffk.wattle.id.au \
--to=geoffk@ozemail.com.au \
--cc=binutils@sourceware.cygnus.com \
--cc=ian@zembu.com \
--cc=rth@cygnus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).