From: Geoff Keating <geoffk@ozemail.com.au>
To: binutils@sourceware.cygnus.com
Subject: elf32.em
Date: Wed, 27 Oct 1999 16:33:00 -0000 [thread overview]
Message-ID: <199910270848.SAA01584@gluttony.geoffk.wattle.id.au> (raw)
In elf32.em, there's this code:
FIXME: This approach--using bfd_elf_set_dt_needed_name--is not
very pretty. I haven't been able to think of anything that is
pretty, though. */
if (bfd_check_format (entry->the_bfd, bfd_object)
&& (entry->the_bfd->flags & DYNAMIC) != 0)
{
char *filname, *needed_name;
ASSERT (entry->is_archive && entry->search_dirs_flag);
/* Rather than duplicating the logic above. Just use the
filename we recorded earlier.o
First strip off everything before the last '/'. */
filename = strrchr (entry->filename, '/');
Shouldn't the variable be called 'filename'?
--
Geoffrey Keating <geoffk@cygnus.com>
next reply other threads:[~1999-10-27 16:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-10-27 16:33 Geoff Keating [this message]
1999-10-27 16:48 ` elf32.em Ian Lance Taylor
1999-10-27 23:27 ` elf32.em Jeffrey A Law
1999-11-03 7:49 ` elf32.em Jeffrey A Law
1999-11-03 7:49 ` elf32.em Jeffrey A Law
1999-11-03 8:24 ` elf32.em Jeffrey A Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199910270848.SAA01584@gluttony.geoffk.wattle.id.au \
--to=geoffk@ozemail.com.au \
--cc=binutils@sourceware.cygnus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).