From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geoff Keating To: binutils@sourceware.cygnus.com Subject: elf32.em Date: Wed, 27 Oct 1999 16:33:00 -0000 Message-id: <199910270848.SAA01584@gluttony.geoffk.wattle.id.au> X-SW-Source: 1999-10/msg00146.html In elf32.em, there's this code: FIXME: This approach--using bfd_elf_set_dt_needed_name--is not very pretty. I haven't been able to think of anything that is pretty, though. */ if (bfd_check_format (entry->the_bfd, bfd_object) && (entry->the_bfd->flags & DYNAMIC) != 0) { char *filname, *needed_name; ASSERT (entry->is_archive && entry->search_dirs_flag); /* Rather than duplicating the logic above. Just use the filename we recorded earlier.o First strip off everything before the last '/'. */ filename = strrchr (entry->filename, '/'); Shouldn't the variable be called 'filename'? -- Geoffrey Keating