From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Lance Taylor <ian@zembu.com>
To: geoffk@ozemail.com.au
Cc: binutils@sourceware.cygnus.com, law@cygnus.com
Subject: Re: elf32.em
Date: Wed, 27 Oct 1999 16:48:00 -0000
Message-id: <19991027234806.10154.qmail@daffy.airs.com>
References: <199910270848.SAA01584@gluttony.geoffk.wattle.id.au>
X-SW-Source: 1999-10/msg00148.html

   Date: Wed, 27 Oct 1999 18:48:30 +1000
   From: Geoff Keating <geoffk@ozemail.com.au>

   In elf32.em, there's this code:

	FIXME: This approach--using bfd_elf_set_dt_needed_name--is not
	very pretty.  I haven't been able to think of anything that is
	pretty, though.  */
     if (bfd_check_format (entry->the_bfd, bfd_object)
	 && (entry->the_bfd->flags & DYNAMIC) != 0)
       {
	 char *filname, *needed_name;

	 ASSERT (entry->is_archive && entry->search_dirs_flag);

	 /* Rather than duplicating the logic above.  Just use the
	    filename we recorded earlier.o

	    First strip off everything before the last '/'.  */
	 filename = strrchr (entry->filename, '/');

   Shouldn't the variable be called 'filename'?

Actually, I think the uses of it should be filname, to avoid
shadowing.  Or we should just remove the declaration of filname, and
use the existing filename local.

Jeff, I'm not sure it's a good idea to try for the .sl extension on
every system type, given that it is only meaningful on HP/UX.  If
there is a long search path, it is a waste of time.  It is also
incorrect in principle.  You can test for a particular emulation using
#ifdef TARGET_IS_xxx.

Ian