public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* [Patch] Dump unknown dwarf lne records
@ 2011-05-04 11:10 Tristan Gingold
  2011-05-10  2:41 ` Alan Modra
  0 siblings, 1 reply; 3+ messages in thread
From: Tristan Gingold @ 2011-05-04 11:10 UTC (permalink / raw)
  To: binutils Development

Hi,

small patch to dump the unhandled lne records in dwarf.c.  Can be useful to manually decode them.

Ok for trunk ?

Tristan.

binutils/
2011-05-04  Tristan Gingold  <gingold@adacore.com>

	* dwarf.c (process_extended_line_op): Dump unknown records.


diff --git a/binutils/dwarf.c b/binutils/dwarf.c
index b240af6..5102aec 100644
--- a/binutils/dwarf.c
+++ b/binutils/dwarf.c
@@ -376,14 +376,22 @@ process_extended_line_op (unsigned char *data, int is_stmt)
       break;
 
     default:
-      if (op_code >= DW_LNE_lo_user
-	  /* The test against DW_LNW_hi_user is redundant due to
-	     the limited range of the unsigned char data type used
-	     for op_code.  */
-	  /*&& op_code <= DW_LNE_hi_user*/)
-	printf (_("user defined: length %d\n"), len - bytes_read);
-      else
-	printf (_("UNKNOWN: length %d\n"), len - bytes_read);
+      {
+        unsigned int rlen = len - bytes_read - 1;
+
+        if (op_code >= DW_LNE_lo_user
+            /* The test against DW_LNW_hi_user is redundant due to
+               the limited range of the unsigned char data type used
+               for op_code.  */
+            /*&& op_code <= DW_LNE_hi_user*/)
+          printf (_("user defined: "));
+        else
+          printf (_("UNKNOWN: "));
+        printf (_("length %d ["), rlen);
+        for (; rlen; rlen--)
+          printf (" %02x", *data++);
+        printf ("]\n");
+      }
       break;
     }
 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Patch] Dump unknown dwarf lne records
  2011-05-04 11:10 [Patch] Dump unknown dwarf lne records Tristan Gingold
@ 2011-05-10  2:41 ` Alan Modra
  2011-05-10  9:09   ` Tristan Gingold
  0 siblings, 1 reply; 3+ messages in thread
From: Alan Modra @ 2011-05-10  2:41 UTC (permalink / raw)
  To: Tristan Gingold; +Cc: binutils Development

On Wed, May 04, 2011 at 01:09:56PM +0200, Tristan Gingold wrote:
> 	* dwarf.c (process_extended_line_op): Dump unknown records.

OK.

-- 
Alan Modra
Australia Development Lab, IBM

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Patch] Dump unknown dwarf lne records
  2011-05-10  2:41 ` Alan Modra
@ 2011-05-10  9:09   ` Tristan Gingold
  0 siblings, 0 replies; 3+ messages in thread
From: Tristan Gingold @ 2011-05-10  9:09 UTC (permalink / raw)
  To: Alan Modra; +Cc: binutils Development


On May 10, 2011, at 4:41 AM, Alan Modra wrote:

> On Wed, May 04, 2011 at 01:09:56PM +0200, Tristan Gingold wrote:
>> 	* dwarf.c (process_extended_line_op): Dump unknown records.
> 
> OK.

Thanks, committed.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-05-10  9:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-04 11:10 [Patch] Dump unknown dwarf lne records Tristan Gingold
2011-05-10  2:41 ` Alan Modra
2011-05-10  9:09   ` Tristan Gingold

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).