From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id 439513858D35; Mon, 21 Sep 2020 12:45:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 439513858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mliska@suse.cz X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6B491AE16; Mon, 21 Sep 2020 12:45:48 +0000 (UTC) Subject: Re: [PATCH] Import mklog.py from gcc repo To: Simon Marchi , Christian Biesinger Cc: binutils@sourceware.org, gdb-patches References: <20200917202922.4179305-1-simon.marchi@polymtl.ca> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= Message-ID: <1a02745d-b063-d146-5e81-fb1e5cd41b8a@suse.cz> Date: Mon, 21 Sep 2020 14:45:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.2.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Sep 2020 12:45:14 -0000 On 9/18/20 4:50 PM, Simon Marchi via Binutils wrote: > On 2020-09-18 10:27 a.m., Christian Biesinger wrote: >> I like this in principle, but the one annoying part is that no longer >> prints the patch author/date line, so you have to manually create it. >> I suppose one could make their own script for that (or maybe emacs >> users have a macro for that or something)... > > I think you could add an option to the script to do this, I don't see > why they would reject that. I don't know what the workflow of the gcc > devs is regarding this. I removed it as author and timestamp lines are automatically generated based on git commit information. > > But it's not a problem from my point of view. I prefer to write my > ChangeLog entries in the commit message without the header. I think > it's pointless to put a date there, because the final date will be the > date where I actually push the patch on the upstream master branch. And > the name/email is redundant with the author name/email of the commit. > > I use a script [1] to insert the entries in the ChangeLog files and > amend the commit when I'm about to push to upstream master. The script > automatically generates the date/name/email line at that moment. Note that some time ago I offered the gcc-changelog script to binutils community and it was basically rejected. [1] is a motivation example as anybody has it's own script to mechanically modify a timestamp and apply ChangeLog entries. It's a legwork. Martin > > Simon > > [1] https://github.com/simark/gnu-changelog-tools/blob/master/changelog-git-amend/changelog-git-amend.py >