From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 4B0C53858D37 for ; Wed, 5 Oct 2022 11:15:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4B0C53858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664968543; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jqoqqQ84hBm0M9m0dfyrkcHWqb/D7MqpTZOnDpgrQmw=; b=BggP5tkcSH1A8pUAQjVP/jU6K6D3YILjK7WrC6EfCmfKf+usz3YFMAOc2XiTKNpd5l35kK /xV0fVqBTJCbX5JGo5kraRhCahJcgsnh0eE2+hc9bdSkApcz/onFRjOFIfmT9fYg1HZ5VL CFSVACoUYMKJsYPCxSsquc7Bt6U1C4s= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-277-YzESb4t7OYuEcD4RtFBwew-1; Wed, 05 Oct 2022 07:15:40 -0400 X-MC-Unique: YzESb4t7OYuEcD4RtFBwew-1 Received: by mail-qv1-f70.google.com with SMTP id y14-20020a0cf14e000000b004afb3c6984bso9709130qvl.21 for ; Wed, 05 Oct 2022 04:15:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=jqoqqQ84hBm0M9m0dfyrkcHWqb/D7MqpTZOnDpgrQmw=; b=yF5u1QziucGZsGRiROZXP0zZe+BvLS6dK5DJSbrgZZ7wFYaJezEUPcOKgd9a/ztBAq VWOeRTTb7qZxB8GFErOQ9+mn7O8aN+5QbPD2/innYTzFuvoHdxANjrEFxzITCbKw/Xe8 C1pkdg63HozDb/qKtzwuS4bAtdmr2KqJtbDyEdJx71w4JaaGmnIamm6bYrevCntmjKyi Nm8wdoYzQtyS6MP2+uU8lmosIbcVeMba/Ki0k1B3yiwzXMhFBQTaAz6veKbxGMoTjCUd baz3jNj31sDm2SMPIusu5HYyt696skGIEYc0FcwRuhKh90c/Flb4xJa/ZmR4FTnTVkP0 RDLA== X-Gm-Message-State: ACrzQf1v29IwSvDXEnRaH0D/BgKnOY0+/czDiq5Fz7NmK6BIJuBncZ7b GPXCln7QX2MUBCTUvUmje08jJhcpu7VtzUBot4mUiu6cOhV1dz76nZ8AAZV7TpEFvDwdgAYK5fd fF1URgZ2g7FOeOZ7+9A== X-Received: by 2002:a05:622a:3ce:b0:392:7a2b:f6b6 with SMTP id k14-20020a05622a03ce00b003927a2bf6b6mr604407qtx.249.1664968540418; Wed, 05 Oct 2022 04:15:40 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4/ZmtKEAWJy6MrTGAr+5md6ORfR7etTRROMOcnSsacO/cKTCIvt9ftJmpoD4nHTnKziQyehg== X-Received: by 2002:a05:622a:3ce:b0:392:7a2b:f6b6 with SMTP id k14-20020a05622a03ce00b003927a2bf6b6mr604398qtx.249.1664968540207; Wed, 05 Oct 2022 04:15:40 -0700 (PDT) Received: from [192.168.1.18] ([79.123.82.157]) by smtp.gmail.com with ESMTPSA id f21-20020a05620a409500b006b95b0a714esm17968135qko.17.2022.10.05.04.15.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Oct 2022 04:15:39 -0700 (PDT) Message-ID: <1aa71b21-da00-7006-3a3d-1a96e4a181fb@redhat.com> Date: Wed, 5 Oct 2022 12:15:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH] bfd: xtensa: fix __stop_SECTION literal drop, To: Alexey Lapshin , "binutils@sourceware.org" Cc: Ivan Grokhotkov , Alexey Gerenkov , Anton Maklakov References: From: Nick Clifton In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Alexey, > Literals placement algorithm may drop __stop_SECTION symbol as > duplicated because it is not initialized yet and we can not differ it > from __start_SECTION symbol at this stage. Both symbols will be > initialized a bit later. > This workaround prevented start_stop symbols from equality in compare > function > --- > bfd/elf32-xtensa.c | 7 +++++++ > ld/testsuite/ld-xtensa/startstop.d | 6 ++++++ > ld/testsuite/ld-xtensa/startstop.s | 16 ++++++++++++++++ > ld/testsuite/ld-xtensa/xtensa.exp | 2 ++ Patch approved - please apply. Cheers Nick