From: Khem Raj <raj.khem@gmail.com>
To: Vladimir Mezentsev <vladimir.mezentsev@oracle.com>,
binutils@sourceware.org
Subject: Re: [PATCH] gprofng: Fix build with 64bit file offset on 32bit machines
Date: Tue, 1 Aug 2023 11:10:56 -0700 [thread overview]
Message-ID: <1b87f6b0-1f30-246e-4351-e68e3c42e5c0@gmail.com> (raw)
In-Reply-To: <ff3dbed8-9d63-273f-587d-60b4d10de677@oracle.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 2253 bytes --]
On 8/1/23 11:05 AM, Vladimir Mezentsev wrote:
> Hi Khem,
>
> Please check it in.
>
I don't have write access. Someone needs to install it for me.
> Thank you for the fix gprofng.
> -Vladimir
>
> On 7/31/23 15:31, Khem Raj via Binutils wrote:
>> gprofng/ChangeLog
>> 2023-07-31 Khem Raj <raj.khem@gmail.com>
>>
>> * libcollector/iotrace.c: Define open64, fgetpos64, and fsetpos64
>> only when __USE_LARGEFILE64 and __USE_FILE_OFFSET64 are not
>> defined.
>> ---
>> gprofng/libcollector/iotrace.c | 9 ++++++---
>> 1 file changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --git a/gprofng/libcollector/iotrace.c
>> b/gprofng/libcollector/iotrace.c
>> index c0ea7497b09..81c844048d9 100644
>> --- a/gprofng/libcollector/iotrace.c
>> +++ b/gprofng/libcollector/iotrace.c
>> @@ -1030,8 +1030,9 @@ gprofng_open64 (int(real_open64) (const char *,
>> int, ...),
>> }
>> DCL_FUNC_VER (DCL_OPEN64, open64_2_2, open64@GLIBC_2.2)
>> +#if !defined(__USE_LARGEFILE64)
>> DCL_OPEN64 (open64)
>> -
>> +#endif
>> #define F_ERROR_ARG 0
>> #define F_INT_ARG 1
>> @@ -2989,8 +2990,9 @@ DCL_FUNC_VER (DCL_FGETPOS64, fgetpos64_2_17,
>> fgetpos64@GLIBC_2.17)
>> DCL_FUNC_VER (DCL_FGETPOS64, fgetpos64_2_2_5, fgetpos64@GLIBC_2.2.5)
>> DCL_FUNC_VER (DCL_FGETPOS64, fgetpos64_2_2, fgetpos64@GLIBC_2.2)
>> DCL_FUNC_VER (DCL_FGETPOS64, fgetpos64_2_1, fgetpos64@GLIBC_2.1)
>> +#if !defined(__USE_LARGEFILE64)
>> DCL_FGETPOS64 (fgetpos64)
>> -
>> +#endif
>> /*-------------------------------------------------------------
>> fsetpos */
>> static int
>> gprofng_fsetpos (int(real_fsetpos) (FILE *, const fpos_t *),
>> @@ -3087,8 +3089,9 @@ DCL_FUNC_VER (DCL_FSETPOS64, fsetpos64_2_17,
>> fsetpos64@GLIBC_2.17)
>> DCL_FUNC_VER (DCL_FSETPOS64, fsetpos64_2_2_5, fsetpos64@GLIBC_2.2.5)
>> DCL_FUNC_VER (DCL_FSETPOS64, fsetpos64_2_2, fsetpos64@GLIBC_2.2)
>> DCL_FUNC_VER (DCL_FSETPOS64, fsetpos64_2_1, fsetpos64@GLIBC_2.1)
>> +#if !defined(__USE_LARGEFILE64)
>> DCL_FSETPOS64 (fsetpos64)
>> -
>> +#endif
>> /*-------------------------------------------------------------
>> fsync */
>> int
>> fsync (int fildes)
>
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 2613 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 203 bytes --]
next prev parent reply other threads:[~2023-08-01 18:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 22:31 Khem Raj
2023-08-01 18:05 ` Vladimir Mezentsev
2023-08-01 18:10 ` Khem Raj [this message]
2023-08-02 4:03 ` Vladimir Mezentsev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b87f6b0-1f30-246e-4351-e68e3c42e5c0@gmail.com \
--to=raj.khem@gmail.com \
--cc=binutils@sourceware.org \
--cc=vladimir.mezentsev@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).