From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 842433858D33 for ; Thu, 28 Jul 2022 16:19:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 842433858D33 Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26SG48fT031370; Thu, 28 Jul 2022 16:19:40 GMT Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3hg940vqua-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 28 Jul 2022 16:19:39 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 26SEwGki029687; Thu, 28 Jul 2022 16:19:39 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2171.outbound.protection.outlook.com [104.47.57.171]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3hkt7c1s35-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 28 Jul 2022 16:19:39 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eHOCrQa2hckWRV3/55ZGp4Or5chltNf7Io5TPQ3/3ubs9hU5Z1bRNB73FvMmqAe4BkwKMZXtB3xIBfne5PjrXClhYVRqKNc+3VXYS87+Qx5N2RjIOQIMZ58e+8ckMI1aKWYZCt5+Ak/jPc/5zAsWowTZsk3kFEkCAb9M/NB/03j7cvSPwHw+2YFyh7akvcsVCod0aeRasFm70TiJShHGLD64jab9BbRi0AhQsyBeIB1nTbtJICxPRh6DmSTrNVswhHo2vqaPm8aY0W8tlYONiRbdyZfJvgCRP60lMO8nikqqE1aBGLqkW6DiE7GhqbgZIJc8PXm/3loB5aVJ0Jb4Fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GQ4GPbaPS6m/DplM30/13d6UAeWmhm/68EyO6/vM/cY=; b=kurV/WIm+Mwv8hq3gyMXbnLQ9y+HQ1KvRepmzC/SFiTC738zHX7HBObCQAhN3lp0quh6hqervfnO8UXWSCl6l64adNhLGWjselGNqf8M4wVfSM7hTLVDDebBLk5Ig1So+9FZ/oo5r/wkqq5bozMpcNQR0oCiHR5ylIuVvQiBw3nAYQ+zAZFNk2Mv4isJEHHnKGbjtguwxJiwhTf8vLTLzSGeTH4qvudXNm6bvtczpDfxw14lqHc2771RjN3NBTzkuiBoi6Kr1pjeOrT+8rs5tzJ4+i+YWSAjMFLHxXqur5L9tTOFJCVIdPiN2Q59/VNvGJxxgW+XXbvB2IibsXDzVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by BYAPR10MB3560.namprd10.prod.outlook.com (2603:10b6:a03:124::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Thu, 28 Jul 2022 16:19:30 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::65fb:fa92:9a15:f89b]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::65fb:fa92:9a15:f89b%6]) with mapi id 15.20.5458.025; Thu, 28 Jul 2022 16:19:30 +0000 Subject: Re: [PATCH, V5 00/10] Definition and Implementation of CTF Frame format To: Alan Modra , "Jose E. Marchesi" Cc: binutils@sourceware.org, Nick Alcock References: <20220717082011.1284067-1-indu.bhagat@oracle.com> <875yjriwok.fsf@oracle.com> From: Indu Bhagat Message-ID: <1c3436a1-05ba-9bb1-5acc-df83bd0f9919@oracle.com> Date: Thu, 28 Jul 2022 09:19:26 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SA0PR11CA0193.namprd11.prod.outlook.com (2603:10b6:806:1bc::18) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 06ab1466-a846-43be-6ba5-08da70b4f2f0 X-MS-TrafficTypeDiagnostic: BYAPR10MB3560:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dR4DgbHbt+s2rObN+Hllq4/MRWhrtIxGvah57LWA9uAHyu3xh+GMzArqlQIq+NIlGSQzIGewFIJNUs3ROTttZS2x685NFIzT261ADU9LGXPnQzNc4F6+yp+IKBGoiATGv03NG32NDZ37NaIEzIlfbzRqAX4jDkfP31kKIF0INgiqQbxUiNC536ons72TiEDk7gER/mBe8U6kwgFMdhFYXEBmy8sn/8Wg1RSJXRmvch1nXru4XWCm2qGU+GqYN/OrcnBD3Sa1jGgyYt2G8NFhc2b+Ct4u6LysJfTlzWLUnqsIpqXyHc9oO2DTqDjGYfEgB5R3LUB1J/xfXk2Zr9hwwYG/3n/U1G/YvpPFlRkL0Q155H9AlWuJyCfCq/TZcZ5B72nr4v+GVpKCl1qGFcrJRF/IZvoBC3rd/e+adUvT1OOGV/UJIp0Pl84vPcaeNj/rKKB9tpQwryDkbldZH1+0ZmJYPj/p4bRwrj/RR/fBVBQUK3KzNLJH9AQxwspYUDbcNML2ZCJ/87vS21reDx38fWtiXgDOz4EwJQrkCqgHalZHtiqmMVfI37Y2Xk3QlY3h4Urf0aKkErAkakQHT50c+ExSLxwNsFuyP1x+g8R5jQZmzlbZm3bnTlBT5DOuoX+Q0TjzSR66iTUy/Np+y2qUkxCt3smaGHRiOW2AnPeckQ/Y0BBskP3PPUScp0sHNMlaIjwAxV7n6TDG0/iuip5jSpJvhrUUG0W2h9vtBQG5M+EFtxsqqC//RChajUE65oIODdCvWkU7GDM/Qh4YgzuQITDhPbgtACyf6HohMCeN9WPnD8csoO5qRKsxOYshccS+LzIKaVTN0/xbcSAfXXtFFg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1001MB2158.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(39860400002)(376002)(366004)(346002)(136003)(396003)(83380400001)(6636002)(107886003)(6506007)(110136005)(6666004)(53546011)(6486002)(31696002)(41300700001)(316002)(186003)(6512007)(5660300002)(8936002)(478600001)(2616005)(2906002)(86362001)(38100700002)(44832011)(8676002)(66946007)(66476007)(36756003)(31686004)(66556008)(4326008)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U1ZLcS9DY0R0bkdqS0tGejdBTENaZlZibE5lYUhOVy9xMjRnMHhYMDZIM3Jj?= =?utf-8?B?TFhsVitQZ3o1V0FhWGhRdnFHZEkvcWU3Tm9DVzAvUW9jVlFOdXlqYWsreVJy?= =?utf-8?B?NzVHZTg1NTlMYm5aaVN2VG1GdXlibU1GM0tXQlZzOUNDZmJJb3MzV0RQbVlo?= =?utf-8?B?K2hqcFgyam9OWlM5cHpmaWhsc3VlNXllQ3pDeVgxRXI2UnduT0I3N3dneWYr?= =?utf-8?B?QU5pYUJBd3o1TFZNWE8xbFpJNFNzOFQwd1lRZlYxNGx4bU9WTmZ2Q0d4SXlV?= =?utf-8?B?TThxS1kvRWtXaUxDSzNvRURUQlQxSEpQNC9HK2hQWGtRRjA3TzVRS2pKWDlL?= =?utf-8?B?UXRjR1picXo4cUFpOVlpVFRZMmJjb091VlRJdjhRT1FTblAxQ0ovdFY4S1ZL?= =?utf-8?B?NS9YQ2VkV2w1T1lPek8zL1htNFJteERxclpteko0N2lXdTR0bUlRM3pvamZq?= =?utf-8?B?SmFuV1V2T0ZHOFVZanhyNjZianJDanU1dnBYN1hjMGhOeTJ5b3dKcnE3VElw?= =?utf-8?B?OWwza1BtTEx6N2NvREdFYWZmRHBwZFRXYTNQMHFrZVkwWE1MVGxwNlozb3hU?= =?utf-8?B?bzBzYS9yQjEzVit4cE5scHV4NHRTU1BVbVIxYWJNT29TVkU2clhqUEhkeFNp?= =?utf-8?B?Tmh4VEpRQnQyR2lNcVhPY1pxeDYyL0hPK2ZyVzVNM2gveStxQXllSmpKYTJQ?= =?utf-8?B?VlZkaUVrVVdtK2t0V3RZMGlNa0FTMEN3NGM0MVJ1SmNzQy85Q3loamhNRXNZ?= =?utf-8?B?VXV2aUFCdlVFNDlZdWU4M3F4NXVKZUNhVjd2dlRqREhMRWxlRWFpSHFXaWo0?= =?utf-8?B?dFlRUW1KYVd4VlkzOEFmS01FeGw4bXhUOS9yMXN0Skw5T3pTMHFJb2hheDk3?= =?utf-8?B?L3NmdXZCTFQ3dzFSUkNpdk1tRlRtK2RLWjR2MkNNendxdmtwWng1WC8vVXc5?= =?utf-8?B?dkxPRWNZVnhJMTl3S0ZxeGVEZmVWbmZiaDdEdHhGKzI5NXZ6eGZCS0Mzd3VS?= =?utf-8?B?bk14RVZEZXRMTlZpd0t5OG95NWQ2Y09paURrV3RJODlHTUQyYk5SMXBnTzdk?= =?utf-8?B?aExPTml4a2FMMzkybXNFdGJWSDU2bmVHWWExUkpNZDdVR1BFWXIrN0U0dS9K?= =?utf-8?B?QnovcWxQYWU1US85NjJ3alFIcXZHbWw5dFRNdDZyTlRJa0t2Qm9oNWhqMHNl?= =?utf-8?B?NXJ6R2s3K0Zpd0M5eCt4N3M0eHk2RlVTZGY5YStUQnVUcytnOE44NktxcVFX?= =?utf-8?B?NVVlMUZENjhhcllUcWEyVER6WXAvZEZ3OTI4bk5XQzhhekt4czVNWUhOVWtv?= =?utf-8?B?YTZRTFBrOXlrQzhycXhySTk0OWZ5TXYvSU9UOEduaERZcGRkZFcxRXhjK3VS?= =?utf-8?B?c09MaTRHK0dnL2ZSRkUwSkFxeEpOWnJ0ZzhTTmRvS1RxSmxRbWEzRjVKZFh5?= =?utf-8?B?NW8rNFZzTmdWUEpaTitrQmVaR05uT3loQ1JGQnNaYVluUk9OVUNDUXdldHZR?= =?utf-8?B?RXFraE92U3BVMDlMaXA4Qk9mUjljbU0vQ2o2MDJrY2IrenZVZVhXR1U1eDJh?= =?utf-8?B?TWdCMVJYNlgvUlFnQzRtVERiRUFmY2JjZkhoenR3dW5KWjNOVFJxejZKNWln?= =?utf-8?B?TkxWMVd2UlVxYkwyR1lSWSswcUU2Y1BNcXY0TCtVRUxSVDRjK3ZEQ1NiREhB?= =?utf-8?B?a0Q3bkVUNVBOQm4zMFNVb1JMTjg0YlJ4dExMY3RGc1hvZG9wTkd5djRUbnJi?= =?utf-8?B?T2NYR3JIcVV0bzI4TVlJVmt2bzNaZmd1K3Rwd0Q1VUloK1puclFsV0Y2T1Fa?= =?utf-8?B?RkswYy9WUWNvWTFkTENiaEtLZFI5eVdmZWh5SHRVQkpzTEhvL1JvWXZEa1Iv?= =?utf-8?B?bE1XTTJwdHdOd3NIWG4yZ1pTeWl5NmFLU1YzaHpEaTMwUzNWQlJvNnFzWWh1?= =?utf-8?B?eFZhZXRjejhEMWVEalZJZkcyemd4ZVByZFFjdTd4bHJDYXp4MzlMcktFeW9k?= =?utf-8?B?Q0kza01zZDRFR1pPcWxHcWVNSTJCQk51NWNUSE9ydWdWWkZWeFFBK0UzZlZs?= =?utf-8?B?Wmt1UzRqbXVsaldBdXd3bGYwVkZSaXUyd1lYd21pOHBpVHFZOWhxRFJJSkto?= =?utf-8?B?eXBRZnFlK1JjNjdqZXFObER4T1RmTkpxU3UyR0tGVEJrNWVVcW1tYzU0M1NZ?= =?utf-8?B?aWc9PQ==?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 06ab1466-a846-43be-6ba5-08da70b4f2f0 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2022 16:19:30.0956 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wnFJKomYO6nV21ZYUQfRoTcS7IM9MT7ga2Hg/h9sOe80jZGhdcasP+WazRrJpQR/vThdq0LH1wUvQqIzObFLzA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3560 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-28_06,2022-07-28_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 malwarescore=0 phishscore=0 spamscore=0 adultscore=0 suspectscore=0 mlxscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207280074 X-Proofpoint-GUID: aZ3tEwl8E5CCKhs9iRVGpz9jgP5EzNRn X-Proofpoint-ORIG-GUID: aZ3tEwl8E5CCKhs9iRVGpz9jgP5EzNRn X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jul 2022 16:19:42 -0000 On 7/27/22 6:59 PM, Alan Modra wrote: > On Wed, Jul 20, 2022 at 06:19:23PM +0200, Jose E. Marchesi via Binutils wrote: >> Any chance we can have a review for this patch series? > > I applied the patch series, regenerated libctfframe/configure, and ran > my normal set of regression tests. The libctfframe tests failed on > every target. On native x86_64-linux: > > libctfframe/testsuite/libctfframe.decode/bigendian_data.c:91:24: warning: too many arguments for format > [-Wformat-extra-args] > 91 | fprintf (stderr, "Decode: Fail to get funcdesc\n", ctf_frame_errmsg (err)); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > On any cross-target I get ERROR: $target-cc does not exist, or > complaints like ./.libs/libctfframe.a(libctfframe_la-ctf-frame.o): > Relocations in generic ELF (EM: 62). That's due to trying to link > host objects into a target executable. > I will look into these cross-target failures etc and post V6 with fixes. Thanks for trying the patch series out and reporting these. My testing workflow was carelessly missing libctfframe folder for regression testing for cross-builds. Indu > So, no, the patch series is not OK without that fixed. I did glance > over the patches and other than that they look OK, but I would expect > Nick Alcock to handle most of the review. >