From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by sourceware.org (Postfix) with ESMTPS id 0468C3857C73 for ; Mon, 18 Dec 2023 15:24:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0468C3857C73 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0468C3857C73 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::42d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702913058; cv=none; b=xI/5Ol1CQOODkMCePCifGyABS2pSg4ZOr5N9aO0onC85zYS90q8Lg4WrQ1Pc3NkHlYszapc/HhXev5CfoRM5/RbtmVvnYYc/5tF0sw+1vGOKpW5ASz7m80+D12rNFXZZNBiYo4P9kb7iENG58qWBINsFp+fgrLv8sH9RViUaFog= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702913058; c=relaxed/simple; bh=yUaBrbuAC2D5hF9hGt2wUWvPQCSKm5NnPEJ6pC/Wg9Y=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=wv0LHr9Vr3QBCXuDroBIDqF/AvWfPoyHXy4/PXc5YXCZdM+OT9CW0NdJKq6E3UAFmiNIqAM6Y/4NcdFvZMrSmulExQjdvQqgM5SkGdFhKTGQfYPhZELpSOXFdPRodoyFUEASNpJn372sfGXfAkJtcCsMAbKOAM/h+OAwv4B2L8g= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-336641e9cf1so1236272f8f.0 for ; Mon, 18 Dec 2023 07:24:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1702913056; x=1703517856; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=kgCRA738HIiLld7WCNSXnh5iGuSBgQTC3f+jhLFRjGs=; b=dHQ7HlyjyBrCJ9p7GQC+iorfcGKCaW+ZjwmTkRf23u4cfxm6VzQod90jyhsR1PZuD8 z90x//HWozdm/TB2aqs6FujeK99jWHFQsB9YXavYrCl9kOPVlSp8+BKrTV/YthgS5F5P HxBGMx1nSAy4L8UTPeRVw8yJYcBs/HSpgBHP5NMHAKaGY4Iz35QvWfWB6uyf6o0N3oZI p5lb3s9Xkwo43df5b/z/RvCsX0DQkFFHVM9GQllRbE/i2823UZjn5n5BHrJgsokQPqIC MgFxBIHpSKtyDRr+L0gYc9NJwItX2jRnzA66JwxsJQ3aJV/hBPLu64dapoWWVwdFTHhX i8og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702913056; x=1703517856; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kgCRA738HIiLld7WCNSXnh5iGuSBgQTC3f+jhLFRjGs=; b=DEFY3OOJE5/Sx2EoCWWXygkEjde2eYwbyZa9KpCA7PBhplNZJtZUpTwPdIkse78SzW BeiTaaO8bkghqsPffjLhKzMmNl+VIhfKn3HMtAHBU6u4tXK+oiys7O3Vb8KamxaMcUEs Kyhk+qt3oeaf6CkECLscgn276WtghyHnWTFjLMdw5E44X8VXKnaTsO9wvf2hyMHl7fsG 2WNFIJTLklYBXtj11JbUasDEMKbrgADhUdSz1WLJaC8zi3ywQyLl5F3queJ9R8W1Bb1G u9xRjCRttOSGgfda74axDV7hHEetAAoh1icTDDhqa9Piuf8N7i2v4RHecW3K7+/2EB4Y sE+g== X-Gm-Message-State: AOJu0YxAj8wEg6Bcw3GZN6ejSVmkv8KJGKU3w0j4etTK2IMIxsowhFMw gl7HPcN+w8HDpHdZbEQkWEVo X-Google-Smtp-Source: AGHT+IHkaI3O8yA/XClBsH6h9FRRfOD1NMYkdAhW6Q7pSXn1ctGOSgDQU2PS9qBdzO6xIs2+hWz0Pg== X-Received: by 2002:a5d:45d1:0:b0:336:4dfb:93eb with SMTP id b17-20020a5d45d1000000b003364dfb93ebmr3591628wrs.69.1702913055673; Mon, 18 Dec 2023 07:24:15 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id w15-20020adfec4f000000b003366cc543casm1506425wrn.102.2023.12.18.07.24.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Dec 2023 07:24:15 -0800 (PST) Message-ID: <1c6d2661-fae5-46ad-aba7-14bad27a6b9f@suse.com> Date: Mon, 18 Dec 2023 16:24:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/8] Support APX GPR32 with rex2 prefix To: "Cui, Lili" Cc: "Lu, Hongjiu" , "ccoutant@gmail.com" , "binutils@sourceware.org" References: <20231102112911.2372810-1-lili.cui@intel.com> <20231102112911.2372810-2-lili.cui@intel.com> <5807de3c-c509-69df-cdaf-e334ab26bc5f@suse.com> <8d748339-0505-ecfe-762d-a476e0c019ad@suse.com> <968ed07c-65bf-c7de-e213-0b9b5f3fbefd@suse.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3026.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 14.12.2023 11:13, Cui, Lili wrote: >> -----Original Message----- >> From: Jan Beulich >> Sent: Friday, November 10, 2023 5:22 PM >> >> On 10.11.2023 10:14, Jan Beulich wrote: >>> On 10.11.2023 08:11, Cui, Lili wrote: >>>> Here are some cases: >>>> 0: 41 0f a8 rex.B push %gs ---> rex.B was not consumed, rex >> will print it. >>>> 0: d5 01 0f a8 {rex2} push %gs ----> Without egpr, we need to >> print {rex2} for it. But we can't see anything about REX2.B3 from the prefix. >>>> 4: d5 19 58 pop %r24 ----> There is egpr, we know it uses >> rex2 prefix. We cannot see the information of the lower 4 bits of rex2 >>>> >>>> It is not helpful to judge rex_used in rex2. >>> >>> So: REX2, like REX, is a prefix for legacy encodings. Therefore my >>> view is that it ought to be treated similarly to REX in the >>> disassembler (I'm fine to avoid the introduction of a myriad of >>> rex2... [no figure braces] prefixes in gas). Just like in the first >>> line of what you present above for the REX.B case, I'd expect the same >>> for REX2. E.g., taking the 2nd line from above >>> >>> 0: d5 01 0f a8 {rex2.B3} push %gs >>> >>> An alternative, matching your intention of treating REX2 more like >>> EVEX, would be to (subsequently, not right away) do away with rex.B >>> and alike as well, and only print {rex} in that case as well. Such an >>> intention would then want mentioning in the description (and >>> eventually carrying out). The main difference between REX/REX2 and >>> VEX/EVEX, as I view it (and as would be speaking against this >>> alternative approach), is that in VEX/EVEX it is kind of normal that >>> certain bits are deliberately ignored (and might be set either way - >>> see gas'es command line options actually allowing to drive the values for >> some of such ignored fields). >>> REX/REX2, otoh, shouldn't normally specify unused bits, much like >>> other legacy prefixes aren't expected to be present for no reason (and >>> hence are explicitly printed when present). >> >> However, irrespective of what I said above, please feel free to go ahead with >> the simplified approach, to allow making progress. I'd like to have H.J.'s input >> on how to achieve overall consistency, and we can make further adjustments >> later on. But please make sure you actually mention this aspect in the >> description of the patch. > > We are going to use {rex2 0xXX}. So that's going to be {rex2} alone as equivalent to {rex} and {rex2 0xXX} as equivalent to rex (no braces)? Independent of that I'm of course curious how you're meaning to deal with - collisions with REX2 bits already set for other reasons, and - yet more specifically control over REX2.M. Jan