From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by sourceware.org (Postfix) with ESMTPS id 6079D3858C2C for ; Tue, 9 Jan 2024 08:24:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6079D3858C2C Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6079D3858C2C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::12d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704788692; cv=none; b=hENk7+1MP5eUnucUSFZwgOzdcFQ3CaGqTOrxCBoCai9KynLKBd+1uH1HD7hHibXaX8CdUAbIIjvwH6siudfHZYJCRe990soqoZzl//Q5kMqouzspubh8ENGVDKHnGT6tX6A5xE53SIPlC9BuQweH7oDkVxb6KF0NOndBT99UhLo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704788692; c=relaxed/simple; bh=4QWTgLwf0lvttSu2Y3UOM/UoDbq/kZdNQXf1K/2mkRA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=TZJFeI1qdTlNfEyPG0C8Jtj76embFcdlcknRoRepkQ8mxfvWojvAow8E0/PMJ/ZkhoE4F03psnTOh//50PxEfsjKaY/iIrl8E84cMSSHC8gQiig6K10MyWShPKfXAB9XdTPMyuafOsek7IRlZwWgKh0FcBmqr/b22h8bYS4jMMk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-50e7af5f618so2825701e87.1 for ; Tue, 09 Jan 2024 00:24:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1704788687; x=1705393487; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:cc:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YntK4WvM3W+UOSYDM5D9wVf1+7S2c35f721ad87SJuU=; b=HdrhRNxZOokFC7z6OM3GVwfyVIBMDaGQL3BEs/w5cwKRjZiXkaAxwr12qbWWpnPUuh eaYzJQfIsf3CipzD8jro08J0HLmPqZ9uc1Q3NOOcSeu88uJNd0Mv85/iUzedRVOPuXxr M+6RO5B+cUUQwIeyOinR280/QpbdQJXCP84qkJpyxVY2ImHvJQsD13OjsX+ODQ370OLW TTpuXGEjK74tpbbG8pfwDG3XLOlecg+tqKMd83n89e8C80wElMz4X08G74y+DcNRk5ii yVNvNa7WgHCBh6joUcTmVVGLldOi/L8DDUvh49xMRyyDJgeWm8suiCPqIssENIIHiymF /QCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704788687; x=1705393487; h=content-transfer-encoding:in-reply-to:autocrypt:from:cc:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YntK4WvM3W+UOSYDM5D9wVf1+7S2c35f721ad87SJuU=; b=le5jQGfUUuHjqxqGs26QQMuFbp+1NByGMnRFTFwUU9ySncPruENEq2WO7icXl20Pzu y7jdI4UJfG9Cn/pP/sJZpDg1XZtBS/wLOCWWSXUF3AtFGSyWGxLMpxWRDAcKC0cvzHVO qaBHovUonKMgseIs5iNgkjJfNH6t4uYqI7WsdQIOPFGWf/gTKxmEWRmHAx2w5+VOvYZf d4Y4DnT6St88agwpyL0mn9x4WYGvKSjgCC5WaWWgge+OpKop/O+YsiEQzzTuJWa6IhJ4 rb2ZkCSnkBHPmHyG0dXHz3ag/6f2ekxuJOmbCFxzhOu6iu4PmFZg6lXkiYmDrpYwPXVH VvNQ== X-Gm-Message-State: AOJu0YwfmfdBv7ti8JLRvv2LG+7bhKxFfeAQ8/JuCKdGRo6sit4s3ZHh ypxbcVPF8a20ffdaFLHxSsw1JXGIu9QU X-Google-Smtp-Source: AGHT+IHfSc2+i6rZtvKUC2qxjzZzLapBtYAMRdHzOKSxkw8UnvlesWBq4vGhCvQGZgK/jGu5in3hMA== X-Received: by 2002:a05:6512:b9a:b0:50e:b2f9:e73d with SMTP id b26-20020a0565120b9a00b0050eb2f9e73dmr3057365lfv.95.1704788687079; Tue, 09 Jan 2024 00:24:47 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id h12-20020a02cd2c000000b0046da402ed29sm512757jaq.109.2024.01.09.00.24.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jan 2024 00:24:46 -0800 (PST) Message-ID: <1cf65034-171c-44e7-bb7d-022f35451cb0@suse.com> Date: Tue, 9 Jan 2024 09:24:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] opcodes: i386: fix dw2_regnum data type in reg_entry Content-Language: en-US To: Indu Bhagat , Lili Cui , "H.J. Lu" , Kong Lingling , "Hu, Lin1" References: <20240109011229.4191052-1-indu.bhagat@oracle.com> Cc: binutils@sourceware.org From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20240109011229.4191052-1-indu.bhagat@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3025.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 09.01.2024 02:12, Indu Bhagat wrote: > The DWARF register numbers for the APX EGRPs start with 130. The data > type holding the same currently is signed char. > > ChangeLog: > * opcodes/i386-opc.h (reg_entry): Bump to signed short. So yes, something needs doing. But there are further questions to be raised to the original authors: Was the code tested at all in this regard? Why do numbers start at 130, when according to i386-reg.tbl 128 and 129 are unused (and would hence be more natural to [also] use)? > --- a/opcodes/i386-opc.h > +++ b/opcodes/i386-opc.h > @@ -1047,7 +1047,7 @@ typedef struct > #define RegIZ (RegIP - 1) > /* FLAT is a fake segment register (Intel mode). */ > #define RegFlat ((unsigned char) ~0) > - signed char dw2_regnum[2]; > + signed short dw2_regnum[2]; > #define Dw2Inval (-1) > } > reg_entry; It's a little sad that non-64-bit field also has its size increased. Right now either way the structure size as a whole is the same, but down the road this may end up a little wasteful. Jan