From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by sourceware.org (Postfix) with ESMTPS id E10E2385841C for ; Mon, 17 Jan 2022 10:38:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E10E2385841C Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2057.outbound.protection.outlook.com [104.47.14.57]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-6-ItLm7EBJOMisy1pNFetgvg-1; Mon, 17 Jan 2022 11:38:41 +0100 X-MC-Unique: ItLm7EBJOMisy1pNFetgvg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c4JsokCpACsPGMeVmwBJM3wNe9g6f9p9Gc1V/7LVDpjXqE1Aj/h7zwnNIxAEBZhtOrv5Dtigvd+8YxrUugITix+tAU5vznErbxPAWpvaTe7y20GgjEfapvNtNi3x2Fuj/3iXLMAjlYzIeVJjH7vxAg50Nr4lBoyXH3nsKgYLMOW8jPQ4KztJ6umRj0jcoO7+V1Ta6nVuH+zx285cvBfQCmLhiFV1sOZPvZCruh6GT2xUDItUWhpSbOSgIdRqoZH10Dr6idGiGk7s2zdqHc07jyBCUi3bUkDpfv+fMX8E+M9zwS0oCkpZfxnl1VlPFyehW422XTXXHqK/KlLmUB4xFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8cUPNyEbVweu0oAXXx3MVUTr+Y8TBy1Id9MNsFZri5s=; b=J6ImaZ+geYFmbCB/mlUY2s7JhSIeHV+7lxVybQs1S8Jkjep1piGMcO205jHnJcYN1obrDHugd7LSxuk7Q3kwOdcz11gJZ2uxGK3QiWLZhGW7PMRZH1HEoJy09WXIg+vAidV3P8xJlEpJTAiD/clOMRzmcCmAq29R6omk3DuzeXI1qab8VPRyr8h9PED8PtDPH6DzcDQ98KkDkgy2OEAkSlQcnxWn5T+op+bKTWfXk1ZgtYWjd6OcMsbROY0re5m+pCn3LVhfFyyN59wr9tYrPRF1/FhDBoBFPfmns9oHLt1V3trBdUvA8m1JSkEbcAbF+HX+UXdAkPftNVeoYXpeUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by AM0PR04MB4545.eurprd04.prod.outlook.com (2603:10a6:208:73::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.10; Mon, 17 Jan 2022 10:38:39 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4888.013; Mon, 17 Jan 2022 10:38:39 +0000 Message-ID: <1d8309a8-434c-f4e5-1c48-b16229b16489@suse.com> Date: Mon, 17 Jan 2022 11:38:37 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v3] elf: Set p_align to the minimum page size if possible Content-Language: en-US To: "H.J. Lu" Cc: Binutils References: <20211229193949.146079-1-hjl.tools@gmail.com> <11e134a2-1ee7-bec4-fa03-1d76609923f7@suse.com> <5843914b-e666-3c55-2e5b-5b320d55cf51@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8PR04CA0059.eurprd04.prod.outlook.com (2603:10a6:20b:312::34) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7dc89653-14d8-4412-eee6-08d9d9a58605 X-MS-TrafficTypeDiagnostic: AM0PR04MB4545:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OleugbmuAXPBQCQONO/FXESoQHGlrsof6/e4xxo3tiRCR6ch8Yw2fqrZqIv+8oA1zlsBR8kbshxcpWmEy6eFcQAG2TtN2VnhfWduBHQhZwoEVUWdJrURX/ECnibr8dwDlS2FB/uJQ8KxVGmKdfQz8X/olQbxIYqhyfmxWS0lqqFFCT28INkg4d6ESKYHzlEfG8zGnHbtQiUnaDq5d0aEMMXTCf41+otXDaFPknlZaQua8tufseaQG5YPDdAhPvzCszCZaRTu1IwEi3M1FKe1EGa/cqEgG93n0lAvxxbxHTW87kFPpt4U0uw7v7uLqwU8g14n3XF+4XqZNTNtw9W4MlqWyUpUKaczopEAE2wi9UX6K5coSPRh2l+w90lR4XEPWlJ642bMpQ3smBAYl/BR3xTIj1Z7Alvaz2NfXasGgHVYFMQ13WRbaaiF3jnPpAi4vc7tox+dcyjQNuwf37UzIufDs/gMuQCS//sxy5XuhJR+QX6kDTgBH1t2as44SpfJqs0mOMBhMn6Bz2JoLzuyPO0n1dsRHUZvoNwrSLf1F02FVJR91hssNohm5xE7PFg2x2KU9ynZib28Pmo9eDrjkn/4T5oJQJLKHb0HAWFgW/3ZQb7ApOjzxg7cMVlfiGQS5JtVEusgTmixH69kUp0xqcTjcRGMlKdyfYOC9TpgSjzriSX5n0kVf5gGJFbg2m+5gGwtTKphnX9+PUfbhOC8w1w2U3W3e7dXpbmgHp8UpWk= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5600.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(186003)(66476007)(66556008)(26005)(36756003)(86362001)(2616005)(5660300002)(66946007)(508600001)(316002)(4326008)(2906002)(38100700002)(6916009)(31686004)(31696002)(6512007)(8676002)(83380400001)(8936002)(6506007)(6486002)(53546011)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U3BUWUVRNWxVaGNiRFZyWGRMYU1sUWlCZmdKWktQMWdmUjk1dDIxUkdhYXYz?= =?utf-8?B?QlJmUWQ3Nk1wZ0sxUExVUXp6cHhFTndkVVc2bklQRWNXalI1dmhEajV0SE1l?= =?utf-8?B?Q1NJZGJzQlJqaFdvZHJmOVVVN0Zldnh6a1pUd2YrSTUxYWJmUUtGTUhVY0Ru?= =?utf-8?B?aVkvVmMxTWNWUEE3Tk5HTzdObHI3aklvRytsY1A2NExDOVZhY2N3ckQ3TVRQ?= =?utf-8?B?aVF0UHMyVEhEeTFxZHdjZE9tRVNUS2QycU1UWFZiRTE3L1pOMVQwY0EzN0VJ?= =?utf-8?B?anZ2a1dKVTBzclBTRjVRVnl0dWlkaWtHT1Y0MjFEclZkemdyT09ZMk5Dd2Zh?= =?utf-8?B?TG1RK25jeGtoVFhhTmJ4bkQ2emRzb3U4b0h6Zkh3amdXNm9tTlZjZ1ZQS2dz?= =?utf-8?B?VU81WkdEK1c2Szd2UFk4b05mUlF0ajBpc0hnYmZmYVJkaysyZUNwQjBJQlNF?= =?utf-8?B?TWlTYW9OTVMrQW54OXBLYXJQSk9VOHpKRDE0SG9weHdEYXJvR0N3Y1Rmd2xR?= =?utf-8?B?a29tV3Y5Y0p0Y0t4KzZZR1k1eDZic0pBUWJaa1FkZlZHUGxKR0ViSHQ1b0p6?= =?utf-8?B?aVlOeEd2TFpZaHZLd3RuUU13bmdOYkUvL0JGMVNlbzYrN2Y1WUMyZHRKVFlV?= =?utf-8?B?eGhiZ0plcDJqeXp4OE5xZzVJYlBnWXZZdmZ6YmtkRm9VZW5Pbk4zSk1RUEdX?= =?utf-8?B?OW1oRWJkK1lZcnRva3hoRy9uRSt2WWNDRVJ1ZEFpSENSTE5UYzN1U2grYVNO?= =?utf-8?B?aHpLcFRsczRFcVV2SGlBWkhNVlJjY2dSTHluSFBPM3U5K2pLak90YUtwbVVy?= =?utf-8?B?amthMTF6UnZVZFNmTDhIT1NndWg1cklKelVxcEVqWEdLU1VjektZOFJCZ3Z1?= =?utf-8?B?cHRCNitweklhL0lwSUpNTTBZbjBnNXJKNmFNY3NZZFBKUXVzcFhNYTFNS2l6?= =?utf-8?B?ZVNVaWh3ZW9sZzR2eEFDNEI3b29NQXRPUWU4L2dMaDlOT2VNTUxWTUx0U0VE?= =?utf-8?B?S3QybXpvVzdld0FGWHFGVWM0TlVpT0xoaWQ0K2MvSzFhUVNFNzdTcVJ2SkdN?= =?utf-8?B?TGdXcnh0YTY3b2x5b0hXWHVwSWswNmtvSFhacGZBSFIxNkVTRkZKYjRjQjJQ?= =?utf-8?B?NHpwc0JhNmkyN0I1aTlpSW1pZlF5UXlGbjRiZEd4eDFwdlY1bE5kQVJUMFlZ?= =?utf-8?B?NGhscmUrMFI1TkRJaitnbitIN09ZVUtqUUJFR1NyVFJubWsyY1VUcGVnQUN2?= =?utf-8?B?Q0Y3M3pYTUY4TXhlcEdLSUxUNXMyc2hPbm1zVUcrM3Q3WXFaU2tJZklINFp0?= =?utf-8?B?dDBhWGg1SHZ3OVMrREJwOWhlYldrZTBKTWZSWncwc1FZMnhOUmZ6L1JNUzZC?= =?utf-8?B?SlJqM1ZPemp3ZkQzTzFic0Z3a0tmNUdOaHhkTEpDdHBTYXFsOXdRbnBrQ3ds?= =?utf-8?B?eTJTYlNhVEVyamx6VUQxa0FxTmFjdG45VkZzRFR2RGY0TWJKWTlBZW5UbXJa?= =?utf-8?B?V0Q4U0dHRlAweXptTWxicVVDVGd6VElLa3Buck1ic0lQSUNIT1Z6WXhBdmJz?= =?utf-8?B?UWJHNlJBQjNPVWpadXdKYzQ1MUZzY0Z6TUYvdStUOS9QRG85RDZvd2NMU21w?= =?utf-8?B?NUg3ak9Jbi9XaXNnOXZ4N0RkVzNiWFViMWtsVG1oeFloVnFUUW4zME5qOWI5?= =?utf-8?B?NWFJZTA0UGtwS2xqWWk3WkNiSitRd25qRjRLOHJWK0RLZFZJRmRqSlI4K0xM?= =?utf-8?B?ZFpDdEFXOUMrTzJiQllLM00xNUJlSE8vamo1L1RldTZLeTVoUnZrNDRZMlJF?= =?utf-8?B?UEE4bjFSdXUyNGRaTjd3dFhQdE5FWkQ3TmRtenkwZDRwcm9pc3FOQTBXUTNC?= =?utf-8?B?ZUxmR2ZPd1crQVdUQUM4TDVOTWk0WE12QSsxbUpFL21xSEhpSXdINzZ2WWh4?= =?utf-8?B?bXdhM0FnRUJRUllXcnBqQU9OMHUyN3RZbSs4dlRlUitMTzRBZjh4c3VqNkVl?= =?utf-8?B?cXU3aUJ3NVZEQVE1TE9OSmtjeXlycTNXRU5PWTd4MTB1Y2dMbmFpZFdHenZE?= =?utf-8?B?U3RIZ1NuVEo3SHRUaStLS1BJSHBQaElXM0ZmOXNta1p5UjVWcjNrOUxMZFYr?= =?utf-8?B?MkJuRCtUWldIQ2E5WHI2UC9QTmxmaWw1QkhJdlZnYWtzTTV1WmdCMllkWGJz?= =?utf-8?Q?IcKKkOWr/PfffUzLINpesLw=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7dc89653-14d8-4412-eee6-08d9d9a58605 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2022 10:38:39.3161 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kBWS0pbhVXokaSJ7JXzHF0K37YBDSkEM62Wiw9lYrALR3HZseP0M69DvLx3JCnGXKB9fgRCiM3fIB++my/gqGA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4545 X-Spam-Status: No, score=-3033.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Jan 2022 10:38:46 -0000 On 14.01.2022 15:14, H.J. Lu wrote: > On Fri, Jan 14, 2022 at 6:08 AM Jan Beulich wrote: >> >> On 14.01.2022 15:02, H.J. Lu wrote: >>> On Fri, Jan 14, 2022 at 5:40 AM Jan Beulich wrote: >>>> >>>> On 14.01.2022 14:03, H.J. Lu wrote: >>>>> On Fri, Jan 14, 2022 at 12:27 AM Jan Beulich wrote: >>>>>> >>>>>> On 29.12.2021 20:39, H.J. Lu via Binutils wrote: >>>>>>> --- a/ld/testsuite/ld-elf/linux-x86.exp >>>>>>> +++ b/ld/testsuite/ld-elf/linux-x86.exp >>>>>>> @@ -185,6 +185,42 @@ run_ld_link_exec_tests [list \ >>>>>>> "" \ >>>>>>> "tmpdir/indirect-extern-access-2.so" \ >>>>>>> ] \ >>>>>>> + [list \ >>>>>>> + "Run p_align-1a without PIE" \ >>>>>>> + "$NOPIE_LDFLAGS" \ >>>>>>> + "" \ >>>>>>> + { p_align-1.c } \ >>>>>>> + "p_align-1a" \ >>>>>>> + "pass.out" \ >>>>>>> + "$NOPIE_CFLAGS" \ >>>>>>> + ] \ >>>>>>> + [list \ >>>>>>> + "Run p_align-1b with PIE" \ >>>>>>> + "-pie" \ >>>>>>> + "" \ >>>>>>> + { p_align-1.c } \ >>>>>>> + "p_align-1b" \ >>>>>>> + "pass.out" \ >>>>>>> + "-fpie" \ >>>>>>> + ] \ >>>>>>> + [list \ >>>>>>> + "Run p_align-1c with -Wl,-z,max-page-size=0x1000 without PIE" \ >>>>>>> + "$NOPIE_LDFLAGS -Wl,-z,max-page-size=0x1000" \ >>>>>>> + "" \ >>>>>>> + { p_align-1.c } \ >>>>>>> + "p_align-1c" \ >>>>>>> + "pass.out" \ >>>>>>> + "$NOPIE_CFLAGS" \ >>>>>>> + ] \ >>>>>>> + [list \ >>>>>>> + "Run p_align-1d with -Wl,-z,max-page-size=0x1000 with PIE" \ >>>>>>> + "-pie -Wl,-z,max-page-size=0x1000" \ >>>>>>> + "" \ >>>>>>> + { p_align-1.c } \ >>>>>>> + "p_align-1d" \ >>>>>>> + "pass.out" \ >>>>>>> + "-fpie" \ >>>>>>> + ] \ >>>>>>> ] >>>>>> >>>>>> The two PIE variants of this also fail for me on glibc 2.26. Looks >>>>>> like LOAD segments' alignment isn't being honored there, at least >>>>>> not if it's as big as it is here. >>>>>> >>>>> >>>>> The PIE alignment needs the kernel fix: >>>>> >>>>> commit ce81bb256a224259ab686742a6284930cbe4f1fa >>>>> Author: Chris Kennelly >>>>> Date: Thu Oct 15 20:12:32 2020 -0700 >>>>> >>>>> fs/binfmt_elf: use PT_LOAD p_align values for suitable start address >>>> >>>> Well, then the test needs to be skipped if that fix is not in place. >>>> After all you're testing binutils behavior here, not kernel or libc one. >>>> I'm running a variety of (largely up-to-date) kernels on all of my >>>> systems. But it looks like our kernel folks decided against backporting >>>> this particular change. And I don't think you expect people to remember >>>> to run the testsuite only on top of "certain" kernels? >>> >>> Care to submit a patch? >> >> I have no idea what to check for. I would really expect you to fix such >> an issue (or really two of them, considering the other problem) recently >> introduced by you. > > What compiler are you using on the broken kernel? gcc 7.4.1 No idea how that matters, though. Jan