From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130079.outbound.protection.outlook.com [40.107.13.79]) by sourceware.org (Postfix) with ESMTPS id 4E682385736E for ; Wed, 29 Jun 2022 06:14:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4E682385736E ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GytAsC8siqUpFDWtII/u/NSmy1VJhzXyYNwuWWyyim3LUOcFKDZ7rGBswf9UcX0PPjKk0iGAH4mYHIgodisa67i8gP7d6eDLE/cjgTdslA2Zm7nIGQ9RIGhrCoj7/F1sVQQYOx2ItLO61ZFpsJDDJhyBPlPYEMfQn2TXSPnqFHAps08h9Hv5NR/IB9zzqPTNdMNgUg5ZssieFaVbIJfx/Mu15HS0LsQ1yvIqLss6HbV7QoI+U0j2iAtD5iycwIgJ1xIPl6dbwxgARUSKRObxUHSj+PLlPdn4QxQ+ddwPmJOQoI9T3Dwy25ERWyRhqpy9ZPm2qwNoT2pd9A1ggw5udA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OKUY1uFeAVR/rg8yqdVMbMBaDQLng87Kf0ngpJBvWFs=; b=OrxM/VBAlR0BJUpw0ySt/b8bhXIG8XqguNQt6xzZY6JanFIVaqo7l7viSkrMtKgYMmtJWN8/e//en+MkvYdGFbyoIKxWwTbBottmg1615IrbDUDE2NwiH+lgzDQedhVyEJ/5lOndhlgOocenmX9GX3fp6y151LNAMLkZIZxScqe1Bwbugs40UdhEUOpcTHX0xhWnaP7tnOCMah2vWUaaUpxz8g7vqQweRUMzp1Lsxv5E1jISEN60TtH8DjgXTiLCaQ6Tnj/GMDZRTUWB79Ud7c5QY+ZFZzEEZOUKBSjtMAaH7ihOFcYrld2+KNfuQnZqqCV/pD8WkwPQMjwdmmK+Qg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS1PR04MB9431.eurprd04.prod.outlook.com (2603:10a6:20b:4d9::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.18; Wed, 29 Jun 2022 06:14:46 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.014; Wed, 29 Jun 2022 06:14:46 +0000 Message-ID: <1d96af41-6eda-6815-7217-3c14d60d3332@suse.com> Date: Wed, 29 Jun 2022 08:14:44 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Content-Language: en-US To: Binutils From: Jan Beulich Subject: [PATCH] ELF: emit symbol table when there are relocations Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6PR08CA0029.eurprd08.prod.outlook.com (2603:10a6:20b:c0::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9df669a0-1ae3-4e8f-d244-08da5996aa04 X-MS-TrafficTypeDiagnostic: AS1PR04MB9431:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cb/WGXGSC5JJ00jzRYqLrmGIhV3ZsigW3hG5krLc0aHgHI5L19h65yvD+2+6PanA6XH7lB9sSGQAoUZLy/1wY7d2qxur4ce4z9mrDTFh2vf2i54sS6aYDR0+pf3bMsQDZB4xRXCNqAodSXMrfIZMN8mHi/VAPGJu8Ov8DgcDZMgMriRP/baC1R6liMXUEYOinq/8o9ngSYRljoUlpkJQjUHSyqAc2oXK8Z+WdroDqFztCcmDRp1C0TO6OfcFkNIUcpD/kjMkF7e9IwIMLsrUWpkoDImux+ZWwZLvYXU+cjtVQn/2LWIr5FeVCZweDLCdKzFZssdVJwUbEfAWukWoT7+wKKt7FrNQhjNE/otoDbJlLUmFo3UdmBpWpbK1MlTMVeFtuwCoHgUsyVrgVc98Oa1aXThr4I+GZdY7UBgWR/LTB0CFYz0mnH83e0ylYSyp6k3jvZliqa0Qh8ZXJImSIfvC6zUVqRG0mXpCSA4uTr0HIE7YcgeVyYTQAmlnQloX2KJlJ0McBZzxovB67IGp8JpRXmEOjCgO/qUE34UOiTea1YRUzndu/MH8tmNQD3A6DXiYhaYt4+8icaFsIcDhiBI6eqK1Vq0vm4faf5XOq1Xi9quYbJcD6gf5w7+4HMH5sqlKvvw+OCM2DSOJKMFCZ00s5HTaYZe8RyVAFDeqQIEnwzvlvtp6H04hlR8ttRhjC9+oOO22vjyU72hSXUpSzeaGFgvuDCnqUgxGYT5VfcoCkWrxsbh0T59D6PvQ9SEtys71DqFHePggzDo+nqDVlqCGqPsMild9C2X0rhg3LeA26K9CY/xWXAxc47aIkK7xL/zHt/E2rzbLWE1MHc7hpQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6560.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(39860400002)(136003)(366004)(376002)(346002)(396003)(2616005)(478600001)(8936002)(8676002)(6506007)(36756003)(86362001)(41300700001)(5660300002)(186003)(316002)(38100700002)(2906002)(6486002)(66946007)(31696002)(6512007)(83380400001)(6916009)(66476007)(26005)(66556008)(31686004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M2ZUVWJ6MmhUTzFnbFZVbDV2YmRUazdEVDhUMFBmNlVLcFl5N1RHTnl5RzNj?= =?utf-8?B?NGhXSFhIZjBUM01lSVoxcDdjNURnbHJCUVNwcnZ3cGdORGk5a1FLVTBSTGFk?= =?utf-8?B?M2szdUNaUG5sWGg2NXlNUkhzdGpORTE1NFZEaUlGVTN4UmZWQ3kzeTdNNFlz?= =?utf-8?B?WjMrcVJQZ3B2MFFaOTFHM3pIVFZGb08ydFRVU2xQdlNTYmlmcTRjSnp6NjZV?= =?utf-8?B?cUIzazVyMjZNc2UrcWdmYU9WTTkzM3BEMXhSMWxmN1MvMlZBcXBUckU5QlVr?= =?utf-8?B?VGo4TzdEeGR4UXN0b2hDWkgrckkzNGpRNnVzSVRyMEJSc05sNXNMa01xTFhH?= =?utf-8?B?M2kvdjhlamUzN1ZRRVZvV0tZNEQ3TG1DQ2pBTGJJOTdHV0poWk1pR1RpdFEx?= =?utf-8?B?RSsxRjlsNU10bzAraVBlY1ZqR0R5RjdBQ1VBYURQemwyMXByYjBjbjVPaG5U?= =?utf-8?B?WXRHQ0k3OEF4ZGFwZ0hVTmk5dUNnUzk4YzVwYzJab3Q4RVZEMUliaWp2QmVZ?= =?utf-8?B?cE5aTkpSK1lsRlNNNEdlSTJRZ2x2UzBNUXNPOFZvMkp3Q0RQRzZJREpFQlV6?= =?utf-8?B?aGRZUitOMkVWZmh6U1ZLb25zWXNQRFZaenlCSi9BaVJhZ3VYMTNDN3ZOK3dV?= =?utf-8?B?UUxwNklRTXdGanZUODBTbE5WNUVRZ09ueExzSlpmZitDRUZMVjFncGtVOTZy?= =?utf-8?B?TGZYV2dPTlBhSFUvNUs3dm5IbExwczQyVEhCNmhBYzkxSHY2Ky9WSDV1enlR?= =?utf-8?B?VXU5bGZRM1VRKzNQM21YTmFnb2hsYkMxM3BqVExaYkttbHl0Zk9SWUhIOUJh?= =?utf-8?B?elRkRFZBWVFTaytUaDBFUUNxdFZwZnNsOUpXdkVvODEzczhVSU9TbUhtNGNa?= =?utf-8?B?a0hLWEF3TFU0SmFqM1Fxb0dvaWkxNlppTnpCc3V1VW4vYWJqRURFTWZoaW9k?= =?utf-8?B?bExVL2RzenVYSWE5cFFDTVg0UnZoeWlRbFc5eHZQbEtNMHRDRElKS1dIYnI1?= =?utf-8?B?bW1rc2xtNElFNmN3bkkzejlVcHNrSktwTHpaaHFrejFiSitwNENybTI2WVp2?= =?utf-8?B?OXRTTkprL1ZKeWtxOG5xNTZXc0pOam44L0RIS1Zrbzd6VXpwcG9HaHRVeEM4?= =?utf-8?B?dXRkVk1ZcStCQlhUUVhxZ3VQU3JMUFhhQmJWL00xbUNjYmt4cVMvdzRkOGt1?= =?utf-8?B?ZEFEOVdjR0FsdkcvZE5EZVBTZERCMnJ6NUZ0TFZwRkpUb2k4alQ0bnpEWEVi?= =?utf-8?B?SXdYaTRDbmpjRk50ZHZVV093NjlRTU1RNEhJeW5RTng2OFpIZlV1cUcyS0tL?= =?utf-8?B?WVdGUVVHYVhQRU9ZSDBzc2lwZlMxaC8yVEE4OWZPMHFFWHd0SWpJN3lmYk1s?= =?utf-8?B?Q0s3YlB0UnQvWVZUQ09KVEZLSzhxSjY0ejk3ajdkUW54Qk9NWGRJdEhra3Na?= =?utf-8?B?RC9CWCtJaDIxak91VHk2bVp1OHZZYUtZUkowZ1Noc1BXWWtnejlqUFRHUGtJ?= =?utf-8?B?QTlKZjJLZDhxM25Iam1IaFlqRStwdUJFanhzOHpJM0hrcHc1RXhiSGE1Um1N?= =?utf-8?B?RDdYVHJoTjVtL05xREM0QnArWmp4azF3UEtSandSZFZpQlZrbk1WY2JGWEdW?= =?utf-8?B?b3lBNzdQZ2lHRGVhcnVsZEM1aktnRkpYUno3TDdxQXVVc2MxbUV1OUN6a1Mx?= =?utf-8?B?RkVwQzFkb0lISjF3MGVOMHhtVGpEaklqZ1B6UnllbGhySHFOZG9VZk5pb1dM?= =?utf-8?B?M3NHbWZRMzRySzRzQVh2ZURMS2x0K2JSNGR6OXlFTmJ2SC94WlBRRkMxSStm?= =?utf-8?B?ajJZR3owcWgyZkNVbmpNYytUT0ZieS9PZnVoNjF1WGYrZUhPOUJySitPd1Vz?= =?utf-8?B?dmpwVlkxdVh0WjZNSTBrMWl5QTc1RzE1WVRtdlg0bEFnbit2aEZ5eEIrdG8z?= =?utf-8?B?N3lRcTFvdGdNZ2xzaU5OUm5DbkkxRThzcDNFM3d4MVRrZERsWDhaU1JuajRF?= =?utf-8?B?S2pUQ0Vpd2NBd2cxd2NQN204UW45TzBMSmZieVVGaEd3T1ZQWWNmYkl0MHNW?= =?utf-8?B?OXZtVXFsQm90Q1kzUjM2TW40Vlc2VFNMZGNlQlJ1SktXZDRjeHVIZkNrdHNs?= =?utf-8?Q?QWA4ChCvotZMihOgJwiv/lr+F?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9df669a0-1ae3-4e8f-d244-08da5996aa04 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2022 06:14:45.9536 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3yQyo5c9vYMz4WTAbPNYHzHQOVE5Oc0ZVyEpWE0L/6ZQTdahFKQAD+8fkR3jf5hn0lxiLhjstXy7jeQgBcpasQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9431 X-Spam-Status: No, score=-3030.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jun 2022 06:14:51 -0000 Even when there are no symbols (e.g. all relocations being against absolute values), a symbol table (with just the first placeholder entry) needs to be emitted. Otherwise tools like objdump won't properly process the relocations. The respective checks in assign_section_numbers() and _bfd_elf_compute_section_file_positions() support also this view. Oddly enough so far HAS_RELOC was only set when reading in an object file, but not when generating one anew; the flag would only have been cleared when no relocations were found (anymore). While there also amend the affected function's leading comment to also mention gas. --- I'm not adding a testcase as I don't see a good way to. The involved relocations are target specific, and hence in principle one test per target would be needed for sufficient coverage. I could drop the label again in an x86-64 test I'm soon to submit, which is where I did actually notice the issue (leading to me adding a label there to have a non-empty symbol table). --- a/bfd/elf.c +++ b/bfd/elf.c @@ -3674,7 +3674,7 @@ elf_get_reloc_section (asection *reloc_s /* Assign all ELF section numbers. The dummy first section is handled here too. The link/info pointers for the standard section types are filled in here too, while we're at it. LINK_INFO will be 0 when arriving - here for objcopy, and when using the generic ELF linker. */ + here for gas, objcopy, and when using the generic ELF linker. */ static bool assign_section_numbers (bfd *abfd, struct bfd_link_info *link_info) @@ -3717,9 +3717,11 @@ assign_section_numbers (bfd *abfd, struc reloc_count += sec->reloc_count; } - /* Clear HAS_RELOC if there are no relocations. */ + /* Set/clear HAS_RELOC depending on whether there are relocations. */ if (reloc_count == 0) abfd->flags &= ~HAS_RELOC; + else + abfd->flags |= HAS_RELOC; } for (sec = abfd->sections; sec; sec = sec->next)