From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150088.outbound.protection.outlook.com [40.107.15.88]) by sourceware.org (Postfix) with ESMTPS id DA6923851172 for ; Fri, 14 Oct 2022 14:38:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DA6923851172 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EZBeX5vXRetZEqO2dRsRtDa1TYN7Ho0KVo1Vs9M+r2aG0NwnNoWBzZ8SotpqkxK0gkBW4jJQZmSX4aDu50/Y86d+1r682QCLbSC4q83UVblUXSI14kiAsLxLs1WgLasmQ9JKSTguedww5rlxpaoQP/lnjXd8BGMIqsR2CH8WogdJvaJ4bGDX42Ge6jKR8bQFOwkxLHp+19uz7iYnQFxav9K16nzVAGSRn1FVvv4gl2i2sFGRkxxzBM2HsJlebZgE8ZUdpUKDHXwnvcPn0xeA5TznSXGgprH2fupFIdZHpcVRgbslgillG/7k2OfAwuKdA2WeFnN48n1na+PBlsyVTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cTSwuhxUdrUJXumZyiNJVDrFSr8dxXlxa7r3cP/olw4=; b=J2CoCRa11lYWts8ypXOaXrNhXx/WnW8Y0ZEl2hR2goNePuxtJJcXFHlT1QN8QE9kngZY1i4r6elSnveibBsvMnoQ2b3i6t5Bk1gIfKSCkj3dezaJ6kupyDcnXxy+Tx9x5gJYmKcbS8ujGEjZth1qWcHAykH9FBYtquh7xgIOXfDtBoHYzZvbtoH4DD6vZS/mkaG/Yoa0HrfBrodYgJ3nBTn/l64SA8xKVDR750WmfX25U6V/SpnurKcHxmvSK5oXOAyuReSkubNjx0EtQZuY1pS3UNuDOZ+mgyykl9TQ8dzkMIEK6amiexpWTsYJPmx4jfqmN0XZptqqCPip/hDp1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cTSwuhxUdrUJXumZyiNJVDrFSr8dxXlxa7r3cP/olw4=; b=zzxLZtsk4rNNxOOlVbpb0Evqx93KDbjV2yTm95qhRbx5UO/kf27+L2ErumklXypLqwN+jZrqO7YU4YgZh/fW2oMGtEDt9N91wLX5DJ5q00WAE6owMeWYsj+qAC2BT55LQXo6ZA3EaVCYinqtmimeGRFvkIYGrJOim373q/YrHcTI+GA5eJ4MZg4Ra3XoJcXGgGmXwwTgEqFZF/thk8UOVJ2iJKhFPX49pQtTJLPSZkT+1ylGLaYcdt9Lf3nEFelTvdrM0PKUJEoZxiu7eFM9lj+9kyJt9sI/XxMUcbLG4Hw0GToTIYZQS7MgOix0rcRSgsujnA3FTHtI9nayI/BiGw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8238.eurprd04.prod.outlook.com (2603:10a6:102:1bc::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Fri, 14 Oct 2022 14:38:25 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.026; Fri, 14 Oct 2022 14:38:25 +0000 Message-ID: <1e6a7d9c-4b14-821e-cc46-453adbe6f183@suse.com> Date: Fri, 14 Oct 2022 16:38:23 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH 06/10] Support Intel RAO-INT Content-Language: en-US To: Haochen Jiang Cc: hjl.tools@gmail.com, Kong Lingling , binutils@sourceware.org References: <20221014091248.4920-1-haochen.jiang@intel.com> <20221014091248.4920-7-haochen.jiang@intel.com> From: Jan Beulich In-Reply-To: <20221014091248.4920-7-haochen.jiang@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6PR08CA0008.eurprd08.prod.outlook.com (2603:10a6:20b:b2::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8238:EE_ X-MS-Office365-Filtering-Correlation-Id: 942021af-6d72-4988-134f-08daadf1c05d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: A6lWoFVcfj80mEOg6uhXuMKUT/E+qzDW+nZRy2oEvUAvSbd/VbCB/kvlv5VFeqC2CqSQYWOxYdS5eMwL0tqOlTiVHZ6q8hqmSgkt68GJXQAhGaB+3MW4JkODOZjUNoF+4aMBMh5YH88Z/tOMkUhcuHjW8KR7EA3lGmLtWTHMMRcesN8W0XnzEhN6LVXyDq1CXH4g0SNpalrMaW5mybIpegPjGa/N/EdGUt9G7s6t7rW512ZTQwH7r8/jXBgqKwPyKNPw7b6pnFdXFect4dZU0nzSXPvvtw2OjTQQJa/0nBzUPrRoCWHex+yY8Mm7x3bsp2COZGIJFbUKl6f662lfjmi4kmZSXjJ/nbspSM7saLQrq2TLYsZcjgAipn1y30xmNJAv1MpIDX8yhBhgkp6ktrvlUvTOvX7ttx4B7ySe0z5hwnid+Xg2tOKYoibSQAH0rO4C16rDjm1jacBFKK4VmFQEDcmAD9veeTBzMdA6M11UyqJ0ZwGOIc2DJnrri0uZ9wctblfcD4+Pnf6ubux7JxhL8Lyhfee8WL/JzJN7FRzJqoddVn38ftmHYdzHka+AQZXDKjNkq81H2Ze8vKFAPoJTJN7oVlDPuSffAgax0ONhLV/DsDycpefd4IWZM+Do0wjBbXHPKF+Rua1qVKyDO58HK13Ry/UgQ76GPajJZ/4yHG+quRnTuzFp8P0dGwNRTaPt+H0yvhpLVee8cNlnMJ9M9vzExQgua/E5lhaTZzCht+YQU737z4ES0pIZT7DNIKIfh7xyddH3nmvRrghkuSi//iGLsklOmWYRKkjVugo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(39860400002)(366004)(396003)(376002)(346002)(451199015)(31686004)(478600001)(53546011)(6486002)(6512007)(26005)(6506007)(186003)(2616005)(36756003)(2906002)(38100700002)(8936002)(66476007)(66556008)(4326008)(8676002)(41300700001)(5660300002)(66946007)(316002)(31696002)(86362001)(6916009)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RGF6ekxRaWIxM0U0NmNIS1NGdjJXRmN4eVlIVHFiM01qSnMyQ1NxMTlUYm1V?= =?utf-8?B?azI4T2RjR1d5T0J1TkhlN2dqNjlCM0gvSnEvVnd2bmtqUVZTUmtuWVFGYU4w?= =?utf-8?B?dzVmdGFuaWU0MVJaQnNoMzRKMkIvK0tKdlZrdWNCRTVPb2M0TjZUNm5QRjFs?= =?utf-8?B?Nk5DT2tWcWtuTEhkdmFpVkVIU2hBVWlUSDZvQzJKdjM4NjVVWjU4bEpLcDlN?= =?utf-8?B?V3RiaHRCc2xDLzlTVktIZG5sZ05zckxJcDhjWE54ckdmamJQUXNDWUNBd1Zq?= =?utf-8?B?dVgrdnlldjZ4aDhqVENuemQ5UDVBcFRGWjROWmJ0UURTU2xxTUlPdXZlUkV1?= =?utf-8?B?c3N5RnVGV3ZBQWRrMXBITGppWi9QUGRhellBY0pBdll1bjVmV0pTN1djajBO?= =?utf-8?B?aENrSTdrQks1V1JncURmeEp0aExOVDNmWWRaUjIvZ0NDRTlTaXdNWHFETjdr?= =?utf-8?B?eld3ODd6VjJTVUJHKzluNm9hS2NMb09sdVQ3K2ZpZDQ5cmkxSStXRjEvMmph?= =?utf-8?B?eXgrd0xBanIzWkxUYkY4LzRDS245bGRXNlNrWDVNSFFCTVhNVWxrRjdXVzhX?= =?utf-8?B?eGY2c0drVWlGekIzeWwxM3F5d0ZEcjh3TzB4VjVsUW9xNTlyS2ZjZVlGcmFD?= =?utf-8?B?VFdVQ0VsRFhHcG9QQzgrYjdna1RmODNZS2Vqdi9VQ2FWU0Y0KzllTXp3c3l0?= =?utf-8?B?SVp6ak5oeElHd0ZCK1pObGYwZFNlT2tJMDJHSVl1dFQ5dExUNnBZQTBOS1E2?= =?utf-8?B?ZDN6blNDSzJpWkFrOSs3NkJwRGY2aXpzTm55Um05Rk5CSzlqR1N2OVJTUk9l?= =?utf-8?B?ancxTHJpQlJ3REZrWmUzRnY0dVVLYkxTRERhYm1jU1BxajJKMDFNU3I3Ymx1?= =?utf-8?B?OUdIcmwyZmV2WHhNcGZWWHF1Q1h0SzU1MjRsd0lEZFYyMURUTzl4L29GUDg3?= =?utf-8?B?TmNUSVI4WXNLWmdlbEx5MXlwcUgwV1pOcHZhUTBDZG15LzllazhpK2lwRU1n?= =?utf-8?B?NlNLZmYrNEJaTzRIQ1J0eVF0UTBiK2RYSmljdmZleWlQMC9tbTRxYit1Szhu?= =?utf-8?B?M1dJQ3UzUzUyU2NtdGFJbjNvaVdjSkpHN1ZoWFNOOVM5c1dsYkJwejRvR0Ju?= =?utf-8?B?Y20xWWtZT0JlYmJTUEY2eHR0UVdwbWZwNnZQbE1ZeDBzNVBmSUlyT1lrWElI?= =?utf-8?B?MGZZUnk2MXJxNERhMkVndldGYkhnelg2Vlh2dVVzbklYaC9ac2dsT05oeDhP?= =?utf-8?B?R2xxVTVJRTBGc29CdHRnMTluV25CbFFncURZSWViZlBVNmVHd0I4YU1YQ2F5?= =?utf-8?B?Wmt1dGN2SVhweWt0aFMwbGVRR0VyNExiT1hDKzkxVTdUQm92aDVMeit4ZkpI?= =?utf-8?B?MjFpS0huKzRSeC9QMzdWMGpjNmowTlJUS1cvZUlyTEgvK0hqV0l4S21VM3du?= =?utf-8?B?eXNaWmEvWDROTHFqdmU3ZXZqcmJ2OEZjVXNEbml6V3NvQWhBUFRvaktKVG9w?= =?utf-8?B?bUE3NEFFNHROMk1QaEJmN25WQ2N2WnFPNWxSZFhrTVRNWktCcS9zYk1Yb2tl?= =?utf-8?B?Rk1XY2Z6WnZJQ0V6YitqbEtWWHVSZ2RYQ2NKeUlYUmhqZ1ZOb2NMOHlKeWJu?= =?utf-8?B?ZFFZQlpZOWh0UmlMNkxlUnVaRnlnUUhNNWRLNzQycVdoamdVL2ZjOFpGenRV?= =?utf-8?B?dGpENGdtZ3RJZzdXVWpoakkrMDBLcklYSU1zbEt0Skw2ZWxCWTIzWkx6MmdP?= =?utf-8?B?aU1qMGt4Si85L0lsWEFvQjFTTjBuYkdWdG54WDB0dFVUVFR6QnRrZVZXNjRv?= =?utf-8?B?NWtVMFJvQW50MHVOZ003V3dNdVpJbnpYVmhtcDJaL3U5eldHQk5TTE9qYjRY?= =?utf-8?B?elp6K1RXbzNpMFhzVnBhREJGWEE4RGJjdE5yRy9xN1d2eE9GVWJJSy9EZ2xR?= =?utf-8?B?c1A2d2hkWVJHdHNYZElmbGZMTHlYUVg1amd5ejErNGlmVXpmNzdMMURuQlla?= =?utf-8?B?ZyttUG1FaVhBVG05c1BGUjhLcnBIT0xnMEVRZFBaMTVCL0FWM1QwZXdvSDZ2?= =?utf-8?B?LzkyNjlQdUFRVEZSRG1rd3dsRUVzakFwVW1nY0cxTHMwanR0ZzI5Z1gvLzhu?= =?utf-8?Q?+Y1R/Fg92akUJEJ1ZlZUrvFFI?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 942021af-6d72-4988-134f-08daadf1c05d X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 14:38:25.3332 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4rXU/nJLuPV0IOpjF1oDYnYLGP3MT71103NDNfz0pfXtKW3JqnK5ZWnWhnhUSH6iVz9Ph34m95Je3HQWRWmXug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8238 X-Spam-Status: No, score=-3031.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 14.10.2022 11:12, Haochen Jiang wrote: > --- a/gas/config/tc-i386.c > +++ b/gas/config/tc-i386.c > @@ -1097,7 +1097,8 @@ static const arch_entry cpu_arch[] = > SUBARCH (avx_ifma, AVX_IFMA, ANY_AVX_IFMA, false), > SUBARCH (avx_vnni_int8, AVX_VNNI_INT8, ANY_AVX_VNNI_INT8, false), > SUBARCH (avx_ne_convert, AVX_NE_CONVERT, ANY_AVX_NE_CONVERT, false), > - SUBARCH (cmpccxadd, CMPCCXADD, ANY_CMPCCXADD, false) > + SUBARCH (cmpccxadd, CMPCCXADD, ANY_CMPCCXADD, false), > + SUBARCH (raoint, RAOINT, ANY_RAOINT, false), As for the earlier patch - likely no need for ANY_RAOINT. Also please have the earlier patch add the comma so you don't need to touch that line again here (helping at least "git blame"). > --- a/opcodes/i386-dis.c > +++ b/opcodes/i386-dis.c > @@ -887,6 +887,7 @@ enum > MOD_0F38F9, > MOD_0F38FA_PREFIX_1, > MOD_0F38FB_PREFIX_1, > + MOD_0F38FC, > MOD_0F3A0F_PREFIX_1, > > MOD_VEX_0F12_PREFIX_0, > @@ -1086,6 +1087,7 @@ enum > PREFIX_0F38F8, > PREFIX_0F38FA, > PREFIX_0F38FB, > + PREFIX_0F38FC, PREFIX_0F38FC_M_0 please (see comment on an earlier patch). However, like in the earlier patch - if you used Mdq below, you could avoid going through mod_table[] altogether. > @@ -3598,6 +3600,14 @@ static const struct dis386 prefix_table[][4] = { > { MOD_TABLE (MOD_0F38FB_PREFIX_1) }, > }, > > + /* PREFIX_0F38FC */ > + { > + { "aadd", { Edq, Gdq }, PREFIX_OPCODE }, > + { "axor", { Edq, Gdq }, PREFIX_OPCODE }, > + { "aand", { Edq, Gdq }, PREFIX_OPCODE }, > + { "aor", { Edq, Gdq }, PREFIX_OPCODE }, > + }, Once having gone through prefix_table[], PREFIX_OPCODE (and PREFIX_DATA) are meaningless iirc and should hence be omitted. > --- a/opcodes/i386-opc.tbl > +++ b/opcodes/i386-opc.tbl > @@ -3317,3 +3317,12 @@ cmpsxadd, 0x66e8, None, CpuCMPCCXADD|Cpu64, Modrm|Vex128|Space0F38|VexVVVV=1|Swa > cmpzxadd, 0x66e4, None, CpuCMPCCXADD|Cpu64, Modrm|Vex128|Space0F38|VexVVVV=1|SwapSources|CheckRegSize|No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf, { Reg32|Reg64, Reg32|Reg64, Dword|Qword|Unspecified|BaseIndex } > > // CMPCCXADD instructions end. > + > +// RAOINT instructions. Nit: Better RAO-INT, like in the title? > +aadd, 0xf38fc, None, CpuRAOINT, Modrm|IgnoreSize|No_bSuf|No_wSuf|No_sSuf|No_ldSuf,{ Reg32|Reg64, Dword|Qword|Unspecified|BaseIndex} > +aand, 0x660f38fc, None, CpuRAOINT, Modrm|IgnoreSize|No_bSuf|No_wSuf|No_sSuf|No_ldSuf,{ Reg32|Reg64, Dword|Qword|Unspecified|BaseIndex} > +aor, 0xf20f38fc, None, CpuRAOINT, Modrm|IgnoreSize|No_bSuf|No_wSuf|No_sSuf|No_ldSuf,{ Reg32|Reg64, Dword|Qword|Unspecified|BaseIndex} > +axor, 0xf30f38fc, None, CpuRAOINT, Modrm|IgnoreSize|No_bSuf|No_wSuf|No_sSuf|No_ldSuf,{ Reg32|Reg64, Dword|Qword|Unspecified|BaseIndex} Why IgnoreSize? Instead I think you need CheckRegSize (assuming it does enough for Intel syntax memory operands - please double check; if not this will need fixing). Jan