From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) by sourceware.org (Postfix) with ESMTPS id 339233858001 for ; Thu, 25 Mar 2021 19:48:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 339233858001 Received: by mail-qt1-x82c.google.com with SMTP id u8so2568086qtq.12 for ; Thu, 25 Mar 2021 12:48:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=lP49i5snYKuLJPBZxTkz6LET28+HHBt5J8pH7j9Uv20=; b=espC8u0sQrAp+5E8cIntnY/q1Z/eNj06qkiv4M3VRnWfodRIWOzuKBycHxzFBigwuF JMWPTKszaYvRC+XXkav4X022+hE7AZyt4yDCyc/S5Ue44Yc5FshoCyyQcwdT+eok4Zj5 rVCXZZk81/6S+rg9NjcyJq1U5OpRK5B6juqYCKHz87ClsY/UIRLOQHYTo/jShIufksut xv6Ouk5Wm268T2ha4LDXUtMryYkysK7huMQGO7Qmwowfzqsil7hxmT4CcDXFN/VQQu7g qVTiydLJ30tkn2TZatUT4Rq+QJbgZ/dqJno98RHdFdZSfm7aHB31+mSLS1WcELA1r8gG k4Fg== X-Gm-Message-State: AOAM531G3LCgjZ4iEcqBRoP1bsmGGaexIly+Jh9SvOGzZFfFHEOnTgZU uyl+Pj8nmYQzNukDbOk3qhzYeg== X-Google-Smtp-Source: ABdhPJylLmgQ9vW2elzz8adVzJ3ynfZ98jOzS45hIt8wgLGNUDLJfVPIG6QCLGejOTF/h1Qgk5f9ag== X-Received: by 2002:ac8:5d52:: with SMTP id g18mr9510329qtx.380.1616701682752; Thu, 25 Mar 2021 12:48:02 -0700 (PDT) Received: from ?IPv6:2804:7f0:4841:2841:9c7b:60f4:124f:3c69? ([2804:7f0:4841:2841:9c7b:60f4:124f:3c69]) by smtp.gmail.com with ESMTPSA id g74sm4885126qke.3.2021.03.25.12.48.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Mar 2021 12:48:02 -0700 (PDT) Subject: Re: [PATCH] Add startswith function and use it instead of CONST_STRNEQ. To: Alan Modra Cc: Tom Tromey , Mike Frysinger , Alan Modra via Binutils , gdb-patches@sourceware.org References: <20210319063759.GM6791@bubble.grove.modra.org> <20210320070037.GR6791@bubble.grove.modra.org> <87wnu1k5z1.fsf@tromey.com> <20210321131254.GS6791@bubble.grove.modra.org> <87k0q0j5ql.fsf@tromey.com> <20210322120652.GV6791@bubble.grove.modra.org> <20210322225639.GY6791@bubble.grove.modra.org> <0520bcb8-1945-5f0f-87d1-14785b881c45@linaro.org> <20210325115413.GB5425@bubble.grove.modra.org> From: Luis Machado Message-ID: <1e7e6f28-c916-f138-63c5-ca27f191f994@linaro.org> Date: Thu, 25 Mar 2021 16:47:59 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210325115413.GB5425@bubble.grove.modra.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Mar 2021 19:48:04 -0000 Hi, On 3/25/21 8:54 AM, Alan Modra wrote: > On Thu, Mar 25, 2021 at 07:53:04AM -0300, Luis Machado wrote: >> On 3/22/21 7:56 PM, Alan Modra wrote: >>> On Mon, Mar 22, 2021 at 01:13:00PM -0300, Luis Machado wrote: >>>> Just FTR, I'm seeing breakage in sim/aarch64 and sim/arm. Both are >>>> complaining about "-Werror=implicit-function-declaration" regarding strncmp >>>> and strlen. >>>> >>>> Is this the breakage you're talking about? Just so I know what to expect >>>> when it gets fixed. >>> >>> Yes. >>> >> >> Thanks. Are there plans to address this or should I come up with a patch? > > I posted a patch here > https://sourceware.org/pipermail/binutils/2021-March/115863.html > It's been tested with gdb, sim and binutils builds. > > Tom offered to solve the problem himself, so I'm waiting on that or > for someone in the gdb camp to review my patch. Since I messed this > up in the first place by taking a comment by Tom as a go-ahead rather > than first posting a patch for proper review by gdb maintainers, I'm > being a little cautious in committing the above patch. > I applied the above patch to today's master binutils-gdb and gave configure's --enable-targets=all a try, but I ran into the following: In file included from ../../../repos/binutils-gdb/bfd/archive.c:135: ./bfd.h:568:1: error: redefinition of ‘startswith’ 568 | startswith (const char *str, const char *prefix) | ^~~~~~~~~~ In file included from ../../../repos/binutils-gdb/bfd/sysdep.h:122, from ../../../repos/binutils-gdb/bfd/archive.c:134: ../../../repos/binutils-gdb/bfd/../include/str-util.h:23:1: note: previous definition of ‘startswith’ was here 23 | startswith (const char *str, const char *prefix) | ^~~~~~~~~~