From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by sourceware.org (Postfix) with ESMTPS id 977963861005 for ; Thu, 7 Dec 2023 14:05:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 977963861005 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 977963861005 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::12f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701957961; cv=none; b=QjH/V22kFWSAEAXd5FqQgW+Yvbpd+SQpkWdHaSJQmCrlLdgSPbarE9itIT1VHARFnKpaB09PGluc9VjD69vO1CLyALNg65w0jfC/snR96Zxaw7+GP8XBNpGlQoBPmRHYa711afrPqRl1xt/9J22zltS8Lkxrke52F8daLZjOSrw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701957961; c=relaxed/simple; bh=rTdDaGP0VtcNiP90497bQ3U9yTBOrDtEA83mFS8JQ70=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=WGaqbaEFFoMptCDgLk4GPHDruOYA1VaBzTCw8k9J8OYqTK6fL/jeJMc4kgjX9QUSGHEFBklZLzNGrqvCYqkDnzbNk0fFkVR0yTE/QjuT2nDTbQF6sEGZVzwKqxgUe/UhEPf68BSLjA14m1enwtNq9ErGQ5gTkjpR1cSQo8xZ2xM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-50bffb64178so869143e87.2 for ; Thu, 07 Dec 2023 06:05:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1701957950; x=1702562750; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Ox49oKVCGYk3LTt3pr7lMW7jawpzVU79WNQBYj5ZAl8=; b=ZDh/YWbbgq2lxnO8MsnRjJWsDLL7QiSZLJPRBOOHK8EW69KoyFMTeS2vrEW2zQynvM sseR1QBNqdSC0wDE1K+DwW0tgdJoxpjRq5MTeGe9HlOBAAq6Z/i7JYQxvRArYBVFkZCE gMGeItKWPSTszKOvobS6HzMvaX/wsTibx4A/xlpCrFJFTlteuV3w2B9dh4aKUohU+syL uoBBVGcv+bcGaEDDcPwPB1Rg6YfduwdIEoiQOj93TOhij3yw13AH8d230KvwJlE6Sty1 wf8LzwlFVGgNql8Wm6aIUxI5ASYbGp7AkD6MResUb/SSXgNPXE8ZzP0A5ZToebuJysyq WmRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701957950; x=1702562750; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ox49oKVCGYk3LTt3pr7lMW7jawpzVU79WNQBYj5ZAl8=; b=sJZLg1pGmtJA5DOV5wdGTRLkvVN5sR7R5A5LH1RiHJAVLMlJAaEdbhObUpWr/UP2ms Kb/jEkKcNUV/Ywzh9dMCau2fCxad6Qp7xMeWFnYOfT8ynLHqAaYDKRW37EIAWFMze0+d Eg/SZ5ihsZyMYRUbn9Zkz6JIkqEc2vPVbdFAXsqaCBybGp4ErVmiP0cU9m/H5AbQJ6pK ZYIytsDGWRPG7hBultZ0QKWqx187Jo1v73fFjApq1G6b97X7YzlUIYvDeenE7xuP+/OL 0VrJhfwusDupL7OBkyir3pz71wb5wOGyT0QF07dafC0us9+b66ycYfK+fHx9IpG5d3Gu 9V5Q== X-Gm-Message-State: AOJu0Yxozy8pUQVABOBIcpWdwPPj5N89hCKA4Cu7NqaEyzACZP/BJ5/i ZvQov2G79YqTe8pfh8wAMJYg X-Google-Smtp-Source: AGHT+IGBsf9Ih1dWsxY8d69Kv/2YYvSlyNkBIus3cIUiCczaa7ozY+wvjxXdc7R5I4s1CzI/wZb/8w== X-Received: by 2002:a05:6512:3da2:b0:50b:fe11:bf7c with SMTP id k34-20020a0565123da200b0050bfe11bf7cmr1955233lfv.18.1701957949876; Thu, 07 Dec 2023 06:05:49 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id w2-20020adfec42000000b0033342f72bf8sm1538567wrn.9.2023.12.07.06.05.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Dec 2023 06:05:49 -0800 (PST) Message-ID: <1e96d6fc-e657-4235-ac11-4cc6772effcc@suse.com> Date: Thu, 7 Dec 2023 15:05:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 5/9] Add tests for APX GPR32 with extend evex prefix Content-Language: en-US To: "Cui, Lili" Cc: hongjiu.lu@intel.com, binutils@sourceware.org References: <20231124070213.3886483-1-lili.cui@intel.com> <20231124070213.3886483-5-lili.cui@intel.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20231124070213.3886483-5-lili.cui@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3026.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 24.11.2023 08:02, Cui, Lili wrote: > --- a/gas/testsuite/gas/i386/x86-64-apx-egpr-inval.l > +++ b/gas/testsuite/gas/i386/x86-64-apx-egpr-inval.l > @@ -12,4 +12,192 @@ > .*:16: Error: unsupported extended GPR for addressing for `xsaveopt64' > .*:17: Error: unsupported extended GPR for addressing for `xsavec' > .*:18: Error: unsupported extended GPR for addressing for `xsavec64' > +.*:20: Error: unsupported extended GPR for addressing for `blendpd' > +.*:21: Error: unsupported extended GPR for addressing for `blendps' > +.*:22: Error: unsupported extended GPR for addressing for `blendvpd' > +.*:23: Error: unsupported extended GPR for addressing for `blendvpd' > +.*:24: Error: unsupported extended GPR for addressing for `blendvps' > +.*:25: Error: unsupported extended GPR for addressing for `blendvps' > +.*:26: Error: unsupported extended GPR for addressing for `dppd' > +.*:27: Error: unsupported extended GPR for addressing for `dpps' Seeing this diagnostic in action, I'm afraid I think this would better be closer to the diagnostics i386_index_check() issues. E.g. "extended GPR cannot be used as base/index for ...". > --- a/gas/testsuite/gas/i386/x86-64-apx-egpr-inval.s > +++ b/gas/testsuite/gas/i386/x86-64-apx-egpr-inval.s > @@ -1,4 +1,4 @@ > -# Check Illegal 64bit APX_F instructions > +# Check illegal 64bit APX_F instructions ??? > +#VEX without evex > + vaesimc (%r27), %xmm3 > + vaeskeygenassist $7,(%r27),%xmm3 > + vblendpd $7,(%r27),%xmm6,%xmm2 > + vblendpd $7,(%r27),%ymm6,%ymm2 > + vblendps $7,(%r27),%xmm6,%xmm2 > + vblendps $7,(%r27),%ymm6,%ymm2 > + vblendvpd %xmm4,(%r27),%xmm2,%xmm7 > + vblendvpd %ymm4,(%r27),%ymm2,%ymm7 > + vblendvps %xmm4,(%r27),%xmm2,%xmm7 > + vblendvps %ymm4,(%r27),%ymm2,%ymm7 > + vdppd $7,(%r27),%xmm6,%xmm2 > + vdpps $7,(%r27),%xmm6,%xmm2 > + vdpps $7,(%r27),%ymm6,%ymm2 > + vhaddpd (%r27),%xmm6,%xmm5 > + vhaddpd (%r27),%ymm6,%ymm5 > + vhsubps (%r27),%xmm6,%xmm5 > + vhsubps (%r27),%ymm6,%ymm5 > + vlddqu (%r27),%xmm4 > + vlddqu (%r27),%ymm4 > + vldmxcsr (%r27) > + vmaskmovpd %xmm4,%xmm6,(%r27) > + vmaskmovpd %ymm4,%ymm6,(%r27) > + vmaskmovpd (%r27),%xmm4,%xmm6 > + vmaskmovpd (%r27),%ymm4,%ymm6 > + vmaskmovps %xmm4,%xmm6,(%r27) > + vmaskmovps %ymm4,%ymm6,(%r27) > + vmaskmovps (%r27),%xmm4,%xmm6 > + vmaskmovps (%r27),%ymm4,%ymm6 > + vmovmskpd %xmm4,%r27d > + vmovmskpd %xmm8,%r27d > + vmovmskps %xmm4,%r27d > + vmovmskps %ymm8,%r27d > + vpblendd $7,(%r27),%xmm6,%xmm2 > + vpblendd $7,(%r27),%ymm6,%ymm2 > + vpblendvb %xmm4,(%r27),%xmm2,%xmm7 > + vpblendvb %ymm4,(%r27),%ymm2,%ymm7 > + vpblendw $7,(%r27),%xmm6,%xmm2 > + vpblendw $7,(%r27),%ymm6,%ymm2 > + vpcmpeqb (%r26),%ymm6,%ymm2 > + vpcmpeqd (%r26),%ymm6,%ymm2 > + vpcmpeqq (%r16),%ymm6,%ymm2 > + vpcmpeqw (%r16),%ymm6,%ymm2 > + vpcmpestri $7,(%r27),%xmm6 > + vpcmpestrm $7,(%r27),%xmm6 > + vpcmpgtb (%r26),%ymm6,%ymm2 > + vpcmpgtd (%r26),%ymm6,%ymm2 > + vpcmpgtq (%r16),%ymm6,%ymm2 > + vpcmpgtw (%r16),%ymm6,%ymm2 > + vpcmpistri $100,(%r25),%xmm6 > + vpcmpistrm $100,(%r25),%xmm6 > + vperm2f128 $7,(%r27),%ymm6,%ymm2 > + vperm2i128 $7,(%r27),%ymm6,%ymm2 > + vphaddd (%r27),%xmm6,%xmm7 > + vphaddd (%r27),%ymm6,%ymm7 > + vphaddsw (%r27),%xmm6,%xmm7 > + vphaddsw (%r27),%ymm6,%ymm7 > + vphaddw (%r27),%xmm6,%xmm7 > + vphaddw (%r27),%ymm6,%ymm7 > + vphminposuw (%r27),%xmm6 > + vphsubd (%r27),%xmm6,%xmm7 > + vphsubd (%r27),%ymm6,%ymm7 > + vphsubsw (%r27),%xmm6,%xmm7 > + vphsubsw (%r27),%ymm6,%ymm7 > + vphsubw (%r27),%xmm6,%xmm7 > + vphsubw (%r27),%ymm6,%ymm7 > + vpmaskmovd %xmm4,%xmm6,(%r27) > + vpmaskmovd %ymm4,%ymm6,(%r27) > + vpmaskmovd (%r27),%xmm4,%xmm6 > + vpmaskmovd (%r27),%ymm4,%ymm6 > + vpmaskmovq %xmm4,%xmm6,(%r27) > + vpmaskmovq %ymm4,%ymm6,(%r27) > + vpmaskmovq (%r27),%xmm4,%xmm6 > + vpmaskmovq (%r27),%ymm4,%ymm6 > + vpmovmskb %xmm4,%r27 > + vpmovmskb %ymm4,%r27d > + vpsignb (%r27),%xmm6,%xmm7 > + vpsignb (%r27),%xmm6,%xmm7 > + vpsignd (%r27),%xmm6,%xmm7 > + vpsignd (%r27),%xmm6,%xmm7 > + vpsignw (%r27),%xmm6,%xmm7 > + vpsignw (%r27),%xmm6,%xmm7 > + vptest (%r27),%ymm6 > + vrcpps (%r27),%xmm6 > + vrcpps (%r27),%ymm6 > + vrcpss (%r27),%xmm6,%xmm6 > + vroundpd $1,(%r24),%xmm6 > + vroundps $2,(%r24),%xmm6 > + vroundsd $3,(%r24),%xmm6,%xmm3 > + vroundss $4,(%r24),%xmm6,%xmm3 There's still the pending question of whether these really need to be treated as invalid (rather than being converted to VRNDSCALE*). Also (to a lesser degree) for {LD,ST}MXCSR. > + vrsqrtps (%r27),%xmm6 > + vrsqrtps (%r27),%ymm6 > + vrsqrtss (%r27),%xmm6,%xmm6 > + vstmxcsr (%r27) > + vtestpd (%r27),%xmm6 > + vtestpd (%r27),%ymm6 > + vtestps (%r27),%xmm6 > + vtestps (%r27),%ymm6 > + vtestps (%r27),%ymm6 > + vptest (%r27),%xmm6 This one wants moving up, now that sorting was mostly done. > --- /dev/null > +++ b/gas/testsuite/gas/i386/x86-64-apx-evex-promoted-bad.s > @@ -0,0 +1,28 @@ > +# Check Illegal prefix for 64bit EVEX-promoted instructions > + > + .allow_index_reg > + .text > +_start: > + #movbe %r23w,%ax set EVEX.pp = f3 (illegal value). > + .insn EVEX.L0.f3.M12.W0 0x60, %di, %ax > + #movbe %r23w,%ax set EVEX.pp = f2 (illegal value). > + .insn EVEX.L0.f2.M12.W0 0x60, %di, %ax > + #VSIB vpgatherqq 0x7b(%rbp,%zmm17,8),%zmm16{%k1} set EVEX.P[10] == 0 > + #(illegal value). > + .byte 0x62, 0xe2, 0xf9, 0x41, 0x91, 0x84, 0xcd, 0x7b, 0x00, 0x00, 0x00 > + .byte 0xff For the purpose of this test (whatever P[10] again is) you don't need a 32-bit displacement, do you? Shorter is (almost always) better in such tests. > + #EVEX_MAP4 movbe %r23w,%ax set EVEX.mm == b01 (illegal value). > + .insn EVEX.L0.66.M13.W0 0x60, %di, %ax > + #EVEX_MAP4 movbe %r23w,%ax set EVEX.aa(P[17:16]) == b01 (illegal value). There's aaa, but no aa afaik. > + .insn EVEX.L0.66.M12.W0 0x60, %di, %ax{%k1} > + #EVEX_MAP4 movbe %r18w,%ax set EVEX.zL'L == 0b11 (illegal value). How's z relevant when the value is just a 2-bit one? And then z should likely have a separate test (also for the from-VEX case below)? > + .insn EVEX.L0.66.M12.W0 0x60, %di, {rd-sae}, %ax > + #EVEX from VEX bzhi %ebx,%eax,%ecx EVEX.P[17:16](EVEX.aa) == 1 (illegal value). > + .insn EVEX.L0.NP.0f38.W0 0xf5, %eax, %ebx, %ecx{%k1} > + .byte 0xff, 0xff, 0xff > + #EVEX from VEX bzhi %ebx,%eax,%ecx EVEX.P[22:21](EVEX.L’L) == 1 (illegal value). > + .insn EVEX.L0.NP.0f38.W0 0xf5, %eax, {rd-sae}, %ebx, %ecx > + .byte 0xff, 0xff, 0xff If you arranged for a ModR/M byte of 0xc9 (among other possibilities) in both of these cases, you could avoid the .byte lines altogether afaict. Jan