From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from slateblue.cherry.relay.mailchannels.net (slateblue.cherry.relay.mailchannels.net [23.83.223.168]) by sourceware.org (Postfix) with ESMTPS id 36818387541F for ; Thu, 28 Sep 2023 19:27:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 36818387541F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=eagercon.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=eagercon.com X-Sender-Id: dreamhost|x-authsender|eager@eagerm.com Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 7F121502147; Thu, 28 Sep 2023 19:27:48 +0000 (UTC) Received: from pdx1-sub0-mail-a259.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 018CE502173; Thu, 28 Sep 2023 19:27:47 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1695929268; a=rsa-sha256; cv=none; b=ZAYhXHbfDugD8QN40y8LcxnilXK5OdHPPXx8NbinSrZdMvcP6X99kiIskjCyHkjdeW2PwL qUs5t/K1wjiRnBFRtwgPdDdUaIvCBkQgdBPBL3bKAcJZH1wZjaofFulS5RBPweyzuUpV4Y XaraeMYAtidypPE2AXNa9f6/i5aTTVz6MX8p+ovDlsqOp0eT+fMOB7PenoIiUhc412I4fr T03UraSI7uqx/t/+gIZNViP2lMGfxL5npashXi/Bybq7Uzmufi215qlNgE/LRlq82mc3Ay T+KKnr3d0UH8V4ZtaaCb/+G3ldADchcT/zdK5RNbqXe8I0C8sDgbiqHYggNKVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1695929268; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ySusBxjEqVVuiBw403HHBU/CarptEs9IPBrm35VL+ZI=; b=PD+Un8EERL/XGIIazH20isnneCEYjqWTuWqBTeYuB8Ru1fdJeD+RRNiUNE9OW3Xmw1g7pd 38okaasBBk4qWU6ntvchfIUJz8Ae5baihOmv2JihC6Yx9dlHLao5RzH58RFpoqkMmfgFtE zFlYhFNDbhqOdrQYaRozEA5vDEdFUfJ6V7EPxnJA2PvJ/JHp17glOCpkNso//Fh6+OWHPJ Ie8fUE7nOQ+wr8za7HD+MWeEL58P7PwkDci1ZoY8vh7rdDpP7RjpVfpYIh2jb+x5u/BCsk iBhwre7q+aAZwEH+ISoWB2sMXfhTkwc5UyEtwHG0oDyb4OK/RJrR/wpNBlc4PA== ARC-Authentication-Results: i=1; rspamd-7d5dc8fd68-zgjlf; auth=pass smtp.auth=dreamhost smtp.mailfrom=eager@eagercon.com X-Sender-Id: dreamhost|x-authsender|eager@eagerm.com X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|eager@eagerm.com X-MailChannels-Auth-Id: dreamhost X-Troubled-Lonely: 7d052cc8460b8180_1695929268324_4193590252 X-MC-Loop-Signature: 1695929268324:2150414150 X-MC-Ingress-Time: 1695929268324 Received: from pdx1-sub0-mail-a259.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.112.191.212 (trex/6.9.1); Thu, 28 Sep 2023 19:27:48 +0000 Received: from [192.168.20.10] (c-73-170-238-207.hsd1.ca.comcast.net [73.170.238.207]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: eager@eagerm.com) by pdx1-sub0-mail-a259.dreamhost.com (Postfix) with ESMTPSA id 4RxNmM2yWtzFW; Thu, 28 Sep 2023 12:27:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eagercon.com; s=dreamhost; t=1695929267; bh=ySusBxjEqVVuiBw403HHBU/CarptEs9IPBrm35VL+ZI=; h=Date:Subject:To:Cc:From:Content-Type:Content-Transfer-Encoding; b=JVS87IH4pNsPlBMGBInp2nzSNiEj8YBpDMDj/9bMpM+IAG0kJ8wkOzypG/aXE6TK/ pXMdqzFNcbmnEcXjOTQUvMWPrJi/+W1ZhDoy4d4res0GeADa5liyo/zmFVMaQsy5ra TqkoftJnv0TU51EbI5f+R53TLNInTzTxInNoCPOkv0LeuhUnAK3ePpgkWZh6MvvBkz dZ26tF3HceUzWjtam54cC1Szd0n8XjDq0ZiQsKRzTcP8DQILz7o7t1oCHvmKeo10/e 078WM0ZhV/nvZNjHV00I8cqWZTP2BTap0uLkF8tu8eBuLfP/nunkDRVh8lgyA2o5YY 45dJdeNTM2OgA== Message-ID: <1eb5429b-94dc-e394-14f3-9063f19125eb@eagercon.com> Date: Thu, 28 Sep 2023 12:27:46 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v1 1/1] gas: expr: fix support .long 0U and .long 0u Content-Language: en-US To: Jan Beulich , Neal Frager Cc: ibai.erkiaga-elorza@amd.com, nagaraju.mekala@amd.com, mark.hatle@amd.com, sadanand.mutyala@amd.com, appa.rao.nali@amd.com, vidhumouli.hunsigida@amd.com, luca.ceresoli@bootlin.com, binutils@sourceware.org References: <20230927132130.1604555-1-neal.frager@amd.com> <424aef37-8ee6-5309-8342-502e0f41b73c@suse.com> From: Michael Eager In-Reply-To: <424aef37-8ee6-5309-8342-502e0f41b73c@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/27/23 06:33, Jan Beulich via Binutils wrote: > On 27.09.2023 15:21, Neal Frager via Binutils wrote: >> Fix support for .long 0U and .long 0u in GCC. >> >> This patch has been tested for years of AMD Xilinx Yocto >> releases as part of the following patch set: >> >> https://github.com/Xilinx/meta-xilinx/tree/master/meta-microblaze/recipes-devtools/binutils/binutils >> >> Signed-off-by: Neal Frager >> --- >> gas/expr.c | 9 +++++++++ >> 1 file changed, 9 insertions(+) > > Without a testcase demonstrating what's wrong, I'd almost be inclined to say > that ... > >> --- a/gas/expr.c >> +++ b/gas/expr.c >> @@ -824,6 +824,15 @@ operand (expressionS *expressionP, enum expr_mode mode) >> break; >> } >> } >> + if ((*input_line_pointer == 'U') || (*input_line_pointer == 'u')) >> + { >> + input_line_pointer--; >> + >> + integer_constant ((NUMBERS_WITH_SUFFIX || flag_m68k_mri) >> + ? 0 : 10, >> + expressionP); >> + break; >> + } >> c = *input_line_pointer; >> switch (c) >> { > > ... this ought to be covered by logic in integer_constant() already. But I > think I see what the issue is. Nevertheless, go look for tc_allow_U_suffix, > which wants using here as well. Further I think the same issue then exists > for L/l suffixes? > > Plus I think you want to add the new code to the switch() statement rather > than immediately ahead of it. > > Jan > Neal -- Can you provide a test case for this patch? I'm not able to reproduce any error. Please take a look at gas/expr.c:541-543 (PR 19910: Look for, and ignore, a U suffix to the number). Is this a fix for the same issue? https://sourceware.org/bugzilla/show_bug.cgi?id=19910 As Jan says, it looks like this code, if needed, should be in the switch statement. -- Michael Eager