From: Nick Clifton <nickc@redhat.com>
To: YunQiang Su <yunqiang.su@cipunited.com>, macro@orcam.me.uk
Cc: binutils@sourceware.org
Subject: Re: [PATCH v2] GAS/MIPS: Add mips16-e-irix.d testcase
Date: Fri, 10 Nov 2023 14:21:45 +0000 [thread overview]
Message-ID: <1f9f3f8f-0cd5-4e7b-94f9-0735a19324db@redhat.com> (raw)
In-Reply-To: <20231009070931.3437078-1-yunqiang.su@cipunited.com>
Hi YunQiang Su,
> The Irix 5 and 6 assemblers set the type of any common symbol and
> any undefined non-function symbol to STT_OBJECT. The symbol "g1"
> in the testcase 'mips16-e' is an example.
>
> We add this testcase with helping of ${imips} variable, so that
> we can run this test for Irix triples, and run mips16-e on other
> mips platforms.
>
> gas/ChangeLog:
> * testsuite/gas/mips/mips.exp: Add imips to mips16-e,
> so that Irix can use different testcase.
> * gas/mips/mips16-e-irix.d: New file.
Approved and applied. Thank you for submitting this patch.
Cheers
Nick
prev parent reply other threads:[~2023-11-10 14:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 7:09 YunQiang Su
2023-11-10 14:21 ` Nick Clifton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f9f3f8f-0cd5-4e7b-94f9-0735a19324db@redhat.com \
--to=nickc@redhat.com \
--cc=binutils@sourceware.org \
--cc=macro@orcam.me.uk \
--cc=yunqiang.su@cipunited.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).