From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 56F533885C34 for ; Tue, 15 Nov 2022 10:50:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 56F533885C34 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668509440; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i088bnhL7/NgA4+bgPuul0jCrmjEhTCB+hCncw+Yhmw=; b=YxEIvlYGP/l3k9JbohEh76pot0MbixOGUPtlz/Drv87yHEIoWeVkBKihUR1hLo9YklszRm wGTpK2UHV+X9CggbiW3Hkd9+YI5zG8kdJUFl5C0VpfO8Xtz0ZxYTQ60SuIp573i4uOZSuD 8oJT8uGMUC/47NROyuAZna3hJvxkAoA= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-614-F91xVVmmMN675W0_bI7S1w-1; Tue, 15 Nov 2022 05:50:38 -0500 X-MC-Unique: F91xVVmmMN675W0_bI7S1w-1 Received: by mail-qv1-f70.google.com with SMTP id on28-20020a056214449c00b004bbf12d7976so10358084qvb.18 for ; Tue, 15 Nov 2022 02:50:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=i088bnhL7/NgA4+bgPuul0jCrmjEhTCB+hCncw+Yhmw=; b=geSZAhQXRo66cxC97/bMHEvplcdq5iFNOt9yjt8CoXjsa2V1fDhCtIiKirtQn+DGCV b3Hu3ENjp4Rp51lEPXeNM7roFMIGxazgpXiYh/De5/0EyvX+01GfdytxtAwhhYYDg/tt 23xJk1QSVayKMEf0iAYsSRatg3Rm3QzfUDd+n9AjN0o1d5UDweC26vl+WewB2P5NJY0E 6lQqMRR5qeIZxcZsVp1Vq5PJeH5pd86ldx+vMLCOTRTkKNU7Nn1mmvhFARLgvpak5xIE X7AzGAR+qc3JuoSHN14HHEgLHWm4it84gE+4QQIGJvj96UM/0CqJb8YNa4Ftoeg6vvjE zMkQ== X-Gm-Message-State: ANoB5pllZHTWNgY0RElsUy+QrhOizq0KsBQJy13sN+lZxPcnHBq903Tu gHX5xXcL+5h21QyX0wACvDG5tR/xkaItuxZlsVhdHLJT4DY/dWDY9ptnA4t234Yh2YdEaV73ywF PW1AlHM4SPLOW6Hn7Zw== X-Received: by 2002:ac8:7090:0:b0:3a5:3ea0:b2e8 with SMTP id y16-20020ac87090000000b003a53ea0b2e8mr15798664qto.117.1668509438119; Tue, 15 Nov 2022 02:50:38 -0800 (PST) X-Google-Smtp-Source: AA0mqf5/eFb70DGWLfuJJCQSDRGQ7dIhy60U4iic/B4tpG+U8wf4CH5QzdS7snRItsLj0v7+XEIUGA== X-Received: by 2002:ac8:7090:0:b0:3a5:3ea0:b2e8 with SMTP id y16-20020ac87090000000b003a53ea0b2e8mr15798657qto.117.1668509437921; Tue, 15 Nov 2022 02:50:37 -0800 (PST) Received: from [192.168.1.18] (adsl-164-85.freeuk.com. [80.168.164.85]) by smtp.gmail.com with ESMTPSA id cm26-20020a05622a251a00b0039cc82a319asm7043054qtb.76.2022.11.15.02.50.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Nov 2022 02:50:37 -0800 (PST) Message-ID: <1fc98550-06e7-284e-3f1c-dda991bdd0e5@redhat.com> Date: Tue, 15 Nov 2022 10:50:36 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH V2] GAS fix alignment for aarch64-pe To: Zac Walker , binutils@sourceware.org References: From: Nick Clifton In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Zac, > For the aarch64-pe target various values of '.align' causes writing of COFF files to fail. > > This version of the patch differs from the first by using the write.c implementation of SUB_SEGMENT_ALIGN. This means there was no need to modify md_section_align or > aarch64_handle_align. The change is specific to the aarch64-pe target. > > In my testing generated aligned code was correctly padded with nop. Patch approved - please apply. Cheers Nick