From: Jan Beulich <jbeulich@suse.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH 2/2] x86: Append "#pass" to APX tests
Date: Thu, 4 Jan 2024 10:35:35 +0100 [thread overview]
Message-ID: <1fef1fb2-07e2-4d4c-8e90-416357189176@suse.com> (raw)
In-Reply-To: <20231229235033.338761-2-hjl.tools@gmail.com>
On 30.12.2023 00:50, H.J. Lu wrote:
> Append "#pass" to APX tests for targets which pad text sections with NOPs.
>
> * testsuite/gas/i386/x86-64-apx-evex-promoted-bad.d: Append
> "#pass".
> * testsuite/gas/i386/x86-64-apx-ndd-optimize.d: Likewise.
> * testsuite/gas/i386/x86-64-apx-ndd.d: Likewise.
> * testsuite/gas/i386/x86-64-apx-pushp-popp-intel.d: Likewise.
> * testsuite/gas/i386/x86-64-apx-pushp-popp.d: Likewise.
It's interesting that you found a need for this, when I'm sure I made a
comment to this effect during review (somewhere in the series, but
obviously applicable throughout). When approving, you didn't check that
all review comments were addressed, did you?
Jan
next prev parent reply other threads:[~2024-01-04 9:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-29 23:50 [PATCH 1/2] x86: Don't use .insn with '/' H.J. Lu
2023-12-29 23:50 ` [PATCH 2/2] x86: Append "#pass" to APX tests H.J. Lu
2024-01-04 9:35 ` Jan Beulich [this message]
2024-01-04 9:33 ` [PATCH 1/2] x86: Don't use .insn with '/' Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1fef1fb2-07e2-4d4c-8e90-416357189176@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).