From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by sourceware.org (Postfix) with ESMTPS id 5BB253861850 for ; Thu, 4 Jan 2024 09:35:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5BB253861850 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5BB253861850 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704360930; cv=none; b=TTQRW/Hm9vkhJaQNPezKCapf/xhECa8JYkMPTStu4LEMP6PlvIek4/MoHcxtrfAvlOA/VrCz8BRbN2YIEp4OJzv/1bl3q+ZVGiwYjsDdJ3PQywcB7F501vg8JyDqVLYCPcLwTNjEpWuq4fgID+3OPqO/qRloyu9HfO4ccwEOEfw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704360930; c=relaxed/simple; bh=WNyYv7RvuARCAH4FhFVKjSlwZXhQ/yie42X20cx1oxw=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=dahjP+icsjNxNk+a1aai9ukrwFfMxrOeZHZvQyIGL6b9rTmS8RfnHUixOGzEnAwmj2cyCMV77Z9PMV+d9FW95Tf0IpQb9j6hnjUdJjuYLgBGFWUzt1BSlS9cER8X8VzTXBjXOg0UDjkLat4Hx9WeybcDcRB0BZ0k+DPla8AMiII= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lf1-x131.google.com with SMTP id 2adb3069b0e04-50eabfac2b7so303493e87.0 for ; Thu, 04 Jan 2024 01:35:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1704360927; x=1704965727; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:cc:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=deBAvneOljeHtrWRKQWjipBbGkX2Pgzbx0B4b8e3Fqo=; b=CRQyhKV7bIulj6+g8z5kXyZp+hLdFZTBHuKfnWeTVaqdz3+2WN4NBqQ+QhBmGQKRur SOzJAYpxr836r/XkzOsr9ojCm/V6x7xMsopgkB2D5fYIMGJjvbROgneXrJu6m1GqqJ2L 1nnLLAQhvhTsMnnZrV22cXf5XrkekmmAUKVRjw4BLbCVeyoTnvfCsLb1ZgP9TtxxNM4M xLDMZh23AYMY2sLyr5qKh5dgURw65yTE4M4qGhqlPsvuCx0U6WVuVYyOAwcvrWmLRIby NBv+q/Qih778qqSd+qEVTL8rTLbxijGUIyU0huVo4RotEYC8P/jQZX3hDXpmu8CE1weR OINA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704360927; x=1704965727; h=content-transfer-encoding:in-reply-to:autocrypt:from:cc:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=deBAvneOljeHtrWRKQWjipBbGkX2Pgzbx0B4b8e3Fqo=; b=TbRFx8rK3WIjJKCJcWoofvGo6NDt/ZcaqpMHTf+0vxSdkcXA+mk2pP2532AT/vaAwL RKRL/179sOpFByzecVSTHsz5aoWzsYOgnz9ytSCOZB+ZyMBzEh+rN9TiU026UmQmzU3W xnKIG8frnT01GmkUvsYdN5uXWQoic14UegFjrYvx0ibzE/jtV9MCCsguPJk25IFRUvFz ArZu/TmpjR1kWhGn8dA+OLBlW80A14w+BP+G3FPF/ArFdLzIgf0Hyx2Mu5zHGYkn9L1p AmZvpuoY6dO3PU78mnnwgczYX871F0y1jR7d+wOwB0jW9OFohwPmhucrBPW/RgM012PU RdUg== X-Gm-Message-State: AOJu0Yw/TyggBkKZkJxRQCDqhJKfVsxEGoZLjTuNVoaHcvB1OY6DCDVR psuOCtTuyhtNND/c472zyqFhH9twyrxI X-Google-Smtp-Source: AGHT+IGHOZVbN6by720Om0btzghOcXQVT0noLbwbKaF9ij2Ood9jqkltZduBtltfJJ1mcdwig+dhhQ== X-Received: by 2002:a05:6512:694:b0:50e:3b8f:3c40 with SMTP id t20-20020a056512069400b0050e3b8f3c40mr200552lfe.43.1704360926862; Thu, 04 Jan 2024 01:35:26 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id dn9-20020a056638090900b0046b54c58994sm7805730jab.90.2024.01.04.01.35.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jan 2024 01:35:26 -0800 (PST) Message-ID: <1fef1fb2-07e2-4d4c-8e90-416357189176@suse.com> Date: Thu, 4 Jan 2024 10:35:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] x86: Append "#pass" to APX tests Content-Language: en-US To: "H.J. Lu" References: <20231229235033.338761-1-hjl.tools@gmail.com> <20231229235033.338761-2-hjl.tools@gmail.com> Cc: binutils@sourceware.org From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20231229235033.338761-2-hjl.tools@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3026.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 30.12.2023 00:50, H.J. Lu wrote: > Append "#pass" to APX tests for targets which pad text sections with NOPs. > > * testsuite/gas/i386/x86-64-apx-evex-promoted-bad.d: Append > "#pass". > * testsuite/gas/i386/x86-64-apx-ndd-optimize.d: Likewise. > * testsuite/gas/i386/x86-64-apx-ndd.d: Likewise. > * testsuite/gas/i386/x86-64-apx-pushp-popp-intel.d: Likewise. > * testsuite/gas/i386/x86-64-apx-pushp-popp.d: Likewise. It's interesting that you found a need for this, when I'm sure I made a comment to this effect during review (somewhere in the series, but obviously applicable throughout). When approving, you didn't check that all review comments were addressed, did you? Jan