public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* (patch) windres/resrc.c shadowing bug fix
@ 2000-01-03 12:01 Mumit Khan
  0 siblings, 0 replies; 3+ messages in thread
From: Mumit Khan @ 2000-01-03 12:01 UTC (permalink / raw)
  To: binutils

Obvious fix.

1999-01-01  Mumit Khan  <khan@xraylith.wisc.edu>

	* resrc.c (write_rc_rcdata): Fix shadowing bug.

Index: resrc.c
===================================================================
RCS file: /homes/khan/src/CVSROOT/binutils-19990911/binutils/resrc.c,v
retrieving revision 1.2
diff -u -3 -p -r1.2 resrc.c
--- resrc.c	1999/12/23 07:58:31	1.2
+++ resrc.c	2000/01/01 01:19:17
@@ -2166,9 +2166,9 @@ write_rc_rcdata (e, rcdata, ind)
 
 	    if (i + 1 < ri->u.buffer.length)
 	      {
-		int i;
+		int j;
 
-		i = (ri->u.buffer.data[i + 1] << 8) | ri->u.buffer.data[i];
+		j = (ri->u.buffer.data[i + 1] << 8) | ri->u.buffer.data[i];
 		if (first)
 		  first = 0;
 		else
@@ -2176,7 +2176,7 @@ write_rc_rcdata (e, rcdata, ind)
 		    fprintf (e, ",\n");
 		    indent (e, ind + 2);
 		  }
-		fprintf (e, "%d", i);
+		fprintf (e, "%d", j);
 		i += 2;
 	      }
 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: (patch) windres/resrc.c shadowing bug fix
  2000-01-04 14:16 Nick Clifton
@ 2000-04-01  0:00 ` Nick Clifton
  0 siblings, 0 replies; 3+ messages in thread
From: Nick Clifton @ 2000-04-01  0:00 UTC (permalink / raw)
  To: khan; +Cc: binutils

Hi Mumit,

: 1999-01-01  Mumit Khan  <khan@xraylith.wisc.edu>
: 
: 	* resrc.c (write_rc_rcdata): Fix shadowing bug.

Nice catch - please install.

Cheers
	Nick

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: (patch) windres/resrc.c shadowing bug fix
@ 2000-01-04 14:16 Nick Clifton
  2000-04-01  0:00 ` Nick Clifton
  0 siblings, 1 reply; 3+ messages in thread
From: Nick Clifton @ 2000-01-04 14:16 UTC (permalink / raw)
  To: khan; +Cc: binutils

Hi Mumit,

: 1999-01-01  Mumit Khan  <khan@xraylith.wisc.edu>
: 
: 	* resrc.c (write_rc_rcdata): Fix shadowing bug.

Nice catch - please install.

Cheers
	Nick

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2000-04-01  0:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2000-01-03 12:01 (patch) windres/resrc.c shadowing bug fix Mumit Khan
2000-01-04 14:16 Nick Clifton
2000-04-01  0:00 ` Nick Clifton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).