public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* Re: A patch for vms-misc.c
@ 2000-06-14 10:54 Nick Clifton
  2000-06-14 11:13 ` H . J . Lu
  0 siblings, 1 reply; 3+ messages in thread
From: Nick Clifton @ 2000-06-14 10:54 UTC (permalink / raw)
  To: hjl; +Cc: binutils

Hi H.J.

: I got a core dump when I enabled all targets and did
: 
: # objdump -d foo.o
: 
: where foo.o is a coff-i386 file.
: 
: -- 
: H.J. Lu (hjl@gnu.org)
: --
: 2000-06-14  H.J. Lu  <hjl@gnu.org>
: 
: 	* vms-misc.c (_bfd_vms_next_record): Return -1 if PRIV(vms_rec)
: 	is NULL.

Approved.  (Thanks for spoitting this one,  I was caught by it the
other day, but I did not take the time to track it down).

Cheers
	Nick

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: A patch for vms-misc.c
  2000-06-14 10:54 A patch for vms-misc.c Nick Clifton
@ 2000-06-14 11:13 ` H . J . Lu
  0 siblings, 0 replies; 3+ messages in thread
From: H . J . Lu @ 2000-06-14 11:13 UTC (permalink / raw)
  To: Nick Clifton; +Cc: binutils

On Wed, Jun 14, 2000 at 10:54:02AM -0700, Nick Clifton wrote:
> Hi H.J.
> 
> : I got a core dump when I enabled all targets and did
> : 
> : # objdump -d foo.o
> : 
> : where foo.o is a coff-i386 file.
> : 
> : -- 
> : H.J. Lu (hjl@gnu.org)
> : --
> : 2000-06-14  H.J. Lu  <hjl@gnu.org>
> : 
> : 	* vms-misc.c (_bfd_vms_next_record): Return -1 if PRIV(vms_rec)
> : 	is NULL.
> 
> Approved.  (Thanks for spoitting this one,  I was caught by it the
> other day, but I did not take the time to track it down).
> 

Done. Thanks.


-- 
H.J. Lu (hjl@gnu.org)

^ permalink raw reply	[flat|nested] 3+ messages in thread

* A patch for vms-misc.c
@ 2000-06-14  8:20 H . J . Lu
  0 siblings, 0 replies; 3+ messages in thread
From: H . J . Lu @ 2000-06-14  8:20 UTC (permalink / raw)
  To: binutils

I got a core dump when I enabled all targets and did

# objdump -d foo.o

where foo.o is a coff-i386 file.

-- 
H.J. Lu (hjl@gnu.org)
--
2000-06-14  H.J. Lu  <hjl@gnu.org>

	* vms-misc.c (_bfd_vms_next_record): Return -1 if PRIV(vms_rec)
	is NULL.

Index: vms-misc.c
===================================================================
RCS file: /work/cvs/gnu/binutils/bfd/vms-misc.c,v
retrieving revision 1.1.1.3
diff -u -p -r1.1.1.3 vms-misc.c
--- vms-misc.c	1999/07/17 20:52:33	1.1.1.3
+++ vms-misc.c	2000/06/14 14:59:44
@@ -459,6 +459,9 @@ _bfd_vms_next_record (abfd)
 	return -1;
     }
 
+  if (!PRIV(vms_rec))
+    return -1;
+
   if (PRIV(is_vax))
     {
       PRIV(rec_type) = *(PRIV(vms_rec));

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2000-06-14 11:13 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2000-06-14 10:54 A patch for vms-misc.c Nick Clifton
2000-06-14 11:13 ` H . J . Lu
  -- strict thread matches above, loose matches on Subject: below --
2000-06-14  8:20 H . J . Lu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).