* [RFA] Make rs6000-core.c compile on rs6000-ibm-aix3.2.5 again.
@ 2000-06-19 5:13 Mark Kettenis
2000-06-19 7:28 ` Alan Modra
2000-06-19 9:56 ` Nick Duffek
0 siblings, 2 replies; 4+ messages in thread
From: Mark Kettenis @ 2000-06-19 5:13 UTC (permalink / raw)
To: binutils, nsd
OK to check this in?
Nick's recent 64-bit AIX changes broke rs6000-ibm-aix3.2.5. Since
`union VmInfo' is only used within an `#ifdef CORE_VERSION_1' block
there is no problem with doing this for the definition too.
Mark
2000-06-19 Mark Kettenis <kettenis@gnu.org>
* rs6000-core.c: Wrap definition of `union VmInfo' within #ifdef
CORE_VERSION_1.
Index: rs6000-core.c
===================================================================
RCS file: /cvs/src/src/bfd/rs6000-core.c,v
retrieving revision 1.4
diff -u -p -r1.4 rs6000-core.c
--- rs6000-core.c 2000/06/16 20:19:24 1.4
+++ rs6000-core.c 2000/06/19 12:06:58
@@ -118,6 +118,7 @@ typedef union {
/* Union of old and new vm_info structures. */
+#ifdef CORE_VERSION_1
typedef union {
#ifdef AIX_CORE_DUMPX_CORE
struct vm_infox new;
@@ -126,6 +127,7 @@ typedef union {
#endif
struct vm_info old;
} VmInfo;
+#endif
/* Return whether CoreHdr C is in new or old format. */
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFA] Make rs6000-core.c compile on rs6000-ibm-aix3.2.5 again.
2000-06-19 5:13 [RFA] Make rs6000-core.c compile on rs6000-ibm-aix3.2.5 again Mark Kettenis
@ 2000-06-19 7:28 ` Alan Modra
2000-06-19 9:56 ` Nick Duffek
1 sibling, 0 replies; 4+ messages in thread
From: Alan Modra @ 2000-06-19 7:28 UTC (permalink / raw)
To: Mark Kettenis; +Cc: binutils, nsd
On Mon, 19 Jun 2000, Mark Kettenis wrote:
> * rs6000-core.c: Wrap definition of `union VmInfo' within #ifdef
> CORE_VERSION_1.
Nick is on holiday this week, and told me to act as binutils maintainer
in his absence. This patch looks like it's in the class of "obvious
fixes", so please go ahead and check it in.
Regards, Alan Modra
--
Linuxcare. Support for the Revolution.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFA] Make rs6000-core.c compile on rs6000-ibm-aix3.2.5 again.
2000-06-19 5:13 [RFA] Make rs6000-core.c compile on rs6000-ibm-aix3.2.5 again Mark Kettenis
2000-06-19 7:28 ` Alan Modra
@ 2000-06-19 9:56 ` Nick Duffek
1 sibling, 0 replies; 4+ messages in thread
From: Nick Duffek @ 2000-06-19 9:56 UTC (permalink / raw)
To: kettenis; +Cc: binutils
On 19-Jun-2000, Mark Kettenis wrote:
>Nick's recent 64-bit AIX changes broke rs6000-ibm-aix3.2.5. Since
>`union VmInfo' is only used within an `#ifdef CORE_VERSION_1' block
>there is no problem with doing this for the definition too.
Thanks for the fix,
Nick Duffek
nsd@redhat.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFA] Make rs6000-core.c compile on rs6000-ibm-aix3.2.5 again.
@ 2000-06-19 16:39 Nick Clifton
0 siblings, 0 replies; 4+ messages in thread
From: Nick Clifton @ 2000-06-19 16:39 UTC (permalink / raw)
To: alan; +Cc: kettenis, binutils, nsd
Hi Alan,
: > * rs6000-core.c: Wrap definition of `union VmInfo' within #ifdef
: > CORE_VERSION_1.
:
: Nick is on holiday this week, and told me to act as binutils maintainer
: in his absence. This patch looks like it's in the class of "obvious
: fixes", so please go ahead and check it in.
Thanks for approving this. (Yes I am pn vacation, but I just stopped
by to read some email....)
Cheers
Nick
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2000-06-19 16:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2000-06-19 5:13 [RFA] Make rs6000-core.c compile on rs6000-ibm-aix3.2.5 again Mark Kettenis
2000-06-19 7:28 ` Alan Modra
2000-06-19 9:56 ` Nick Duffek
2000-06-19 16:39 Nick Clifton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).