[PATCH] tic54x gas target

[PATCH] tic54x gas target

[Timothy Wall]

These patches implement GAS for the tic54x.

About 3Mb of test files have been excised for brevity.

Re: [PATCH] tic54x gas target

[Alan Modra]

On Mon, 19 Jun 2000, Timothy Wall wrote:

> These patches implement GAS for the tic54x.
> 
> About 3Mb of test files have been excised for brevity.

It's still not exactly brief :-)

Some comments:

- Someone has gone to a bit of trouble to add autoconf checks for libm in
  all the aclocal.m4 files.  You should probably use the autoconf value
  rather than plain "-lm", or better still get rid of -lm altogether.

- I noticed C++ style comments lurking in your source.  As a general rule,
  binutils source ought to compile with pre-ANSI K&R compilers.  There are
  a number of people reading the binutils list who can probably help test
  your code for K&R compatibility.

If these things are fixed, consider it approved.

Regards, Alan Modra
-- 
Linuxcare.  Support for the Revolution.

Re: [PATCH] tic54x gas target

[Geoff Keating]

> Date: Tue, 20 Jun 2000 11:17:10 +1000 (EST)
> From: Alan Modra <alan@linuxcare.com.au>

> - I noticed C++ style comments lurking in your source.  As a general rule,
>   binutils source ought to compile with pre-ANSI K&R compilers.  There are
>   a number of people reading the binutils list who can probably help test
>   your code for K&R compatibility.

For things that are only ever cross-compiled, or where all the native
compilers support it, it's OK to use ISO C89 (an example of this is
rs6000, where we even require ISO C89 plus a 64 bit type).  K&R is only
required for targets that must bootstrap with a K&R compiler, like x86
and sparc.

(Of course, C++-style comments are still not allowed.)
-- 
- Geoffrey Keating <geoffk@cygnus.com>