[RFA] pe-dll patch

[RFA] pe-dll patch

[Charles Wilson]

A typo crept into ld/pe-dll.c sometime between 19990818 and 20000625.
The current version (without this patch) has the following behavior:

an object file will have:
 U __imp__png_create_read_struct
but the dll import library will export:
 I ___imp_png_create_read_struct
which doesn't match.

In the 19990818 sources (or if the included patch is applied to the
current sources), the import library will export
 I __imp__png_create_read_struct
which matches.


(Note: ___imp_png_create_read_struct will be exported ALSO, if
pe_dll_compat_implib is true (e.g. if the --compat-implib switch is
used))


Wed Jul 12 2000 19:52:00 Charles Wilson <cwilson@ece.gatech.edu>
 
       * ld/pe-dll.c: fix a typo in the __imp_ name decoration
       for dll import libraries


--- binutils-20000625-orig/ld/pe-dll.c  Sat Jun 24 21:54:51 2000
+++ binutils-20000625/ld/pe-dll.c       Wed Jul 12 19:05:54 2000
@@ -1443,7 +1443,7 @@
   if (! exp->flag_data)
     quick_symbol (abfd, U(""), exp->internal_name, "", tx,
BSF_GLOBAL,0);
   quick_symbol (abfd, U("_head_"), dll_symname, "", UNDSEC,
BSF_GLOBAL,0);
-  quick_symbol (abfd, U("__imp_"), exp->internal_name, "",
id5,BSF_GLOBAL, 0);
+  quick_symbol (abfd, U("_imp__"), exp->internal_name, "",
id5,BSF_GLOBAL, 0);
   if (pe_dll_compat_implib)
     quick_symbol (abfd, U("__imp_"), exp->internal_name, "", 
                   id5, BSF_GLOBAL, 0);


begin 664 binutils_ld_pe-dll.patch.gz
M'XL("`'Z;#D``V)I;G5T:6QS+3(N<&%T8V@`E9!-3X-`$(;/\BM>.=&P:P%!
M(R8&ZU=B&CV0QN-F89>Z<?FPA:3^>]G0Q#1(C7.9P\SSY)VAE")35=<JO:6!
MU]=%$-%ZH]9S+>:-I$+KL_PDY2V>NPI!B,"/HS".?)AMRW7=,7^`ODG1HQI^
M`/\J]J*>'M`D`?7#\)Q<PMWW)+$`J`+.*>2NH3>%YFLF>,MG9@!\=BK_8-NO
M,JLU')X5@F#EV/:,#/NJ:N6FXII5O)0$MDW0[@@6Z2-[6KXN;I<$WNS:FC:Q
M=\D%,[X^O1G_B%8O]^G#W5A&IV5,E0T[%DZ):"QTIX7&]W_A_J>-9.:HO"X;
9WAJ55MGQO_Y]P(`?UJ\9O@'ZH+Q`:0(``$Z)
`
end

Re: [RFA] pe-dll patch

[DJ Delorie]

> Wed Jul 12 2000 19:52:00 Charles Wilson <cwilson@ece.gatech.edu>
>  
>        * ld/pe-dll.c: fix a typo in the __imp_ name decoration
>        for dll import libraries

Applied, though I know *someone* is going to complain ;-)

I compared ld with MSVC's import libraries, and they are the same now.