[EFifer@sanwaint.com: RE: binutils prerelease available for testing (feedback needed)]

[EFifer@sanwaint.com: RE: binutils prerelease available for testing (feedback needed)]

[DJ Delorie]

Can I revert this patch and put it back on the discussion block?

------- Start of forwarded message -------
Mailing-List: contact cygwin-help@sourceware.cygnus.com; run by ezmlm
Precedence: bulk
List-Subscribe: < mailto:cygwin-subscribe@sources.redhat.com >
List-Archive: < http://sources.redhat.com/ml/cygwin/ >
List-Post: < mailto:cygwin@sources.redhat.com >
List-Help: < mailto:cygwin-help@sources.redhat.com >, < http://sources.redhat.com/ml/#faqs >
Sender: cygwin-owner@sources.redhat.com
From: "Fifer, Eric" <EFifer@sanwaint.com>
To: cygwin@sources.redhat.com
Subject: RE: binutils prerelease available for testing (feedback needed)
Date: Thu, 20 Jul 2000 18:46:40 +0100
Content-Type: text/plain;
	charset="iso-8859-1"


Danny Smith wrote:
>But, rebuilding binutils-000718 after reverting the changes made to
>gas/config/obj_coff.c
>( http://sources.redhat.com/ml/binutils/2000-07/msg00226.html )  back to
>binutils-000717 version, I can successfully build and link against dlls,
>using either dllwrap or gcc -shared.

Yes, rebuilding binutils-20000718-1 with the patch you mention
reversed out, clears up the problems I'm seeing.

Thanks,

Eric Fifer

- --
Want to unsubscribe from this list?
Send a message to cygwin-unsubscribe@sourceware.cygnus.com
------- End of forwarded message -------

Re: [EFifer@sanwaint.com: RE: binutils prerelease available for testing (feedback needed)]

[Nick Clifton]

HI DJ,

: Can I revert this patch and put it back on the discussion block?

Yes - please make sure to include Mark explicitly in any discussions.

Cheers
	Nick


: Danny Smith wrote:
: >But, rebuilding binutils-000718 after reverting the changes made to
: >gas/config/obj_coff.c
: >( http://sources.redhat.com/ml/binutils/2000-07/msg00226.html )  back to
: >binutils-000717 version, I can successfully build and link against dlls,
: >using either dllwrap or gcc -shared.
: 
: Yes, rebuilding binutils-20000718-1 with the patch you mention
: reversed out, clears up the problems I'm seeing.
: 
: Thanks,
: 
: Eric Fifer

Re: [EFifer@sanwaint.com: RE: binutils prerelease available for testing (feedback needed)]

[Mark E.]

> : Danny Smith wrote:
> : >But, rebuilding binutils-000718 after reverting the changes made to
> : >gas/config/obj_coff.c
> : >( http://sources.redhat.com/ml/binutils/2000-07/msg00226.html )  back to
> : >binutils-000717 version, I can successfully build and link against dlls,
> : >using either dllwrap or gcc -shared.
> : 
> : Yes, rebuilding binutils-20000718-1 with the patch you mention
> : reversed out, clears up the problems I'm seeing.

Interesting. Most of the changes go along with what's already being done in 
the BFD version in obj_coff_endef . The first culprit I'd look would be this 
change:

	if (S_GET_STORAGE_CLASS (symp) == C_NULL)
	{
	  if (!S_IS_DEFINED (symp) && !SF_GET_LOCAL (symp))
	    {
	      assert (S_GET_VALUE (symp) == 0);
	      S_SET_EXTERNAL (symp);
	    }
	  else if (S_GET_SEGMENT (symp) == text_section
	           && symp != seg_info (text_section)->sym)
	    {
	      S_SET_STORAGE_CLASS (symp, C_LABEL);
	    }
	  else
	    {
	      S_SET_STORAGE_CLASS (symp, C_STAT);
	    }
	}

Re: [EFifer@sanwaint.com: RE: binutils prerelease available for testing (feedback needed)]

[DJ Delorie]

> > Should I wait until you do some more debugging, or should I revert
> > your earlier patch now and let you submit a new one later?
> 
> Go ahead and revert it. I'll submit a new one later.

I have reverted your patch.

2000-07-20  DJ Delorie  <dj@redhat.com>

	* config/obj-coff.c (obj_frob_symbol): revert previous change,
	it breaks linking against DLLs.

2000-07-17  Mark Elbrecht  <snowball3@bigfoot.com>

	* config/obj-coff.c (obj_frob_symbol): Don't merge labels. Don't
	merge if the symbol isn't constant. Don't call S_SET_EXTERNAL if
	the storage class is already set.