* Re: [EFifer@sanwaint.com: RE: binutils prerelease available for testing (feedback needed)]
@ 2000-07-20 12:22 Nick Clifton
2000-07-20 12:59 ` Mark E.
0 siblings, 1 reply; 4+ messages in thread
From: Nick Clifton @ 2000-07-20 12:22 UTC (permalink / raw)
To: dj, snowball3; +Cc: binutils
HI DJ,
: Can I revert this patch and put it back on the discussion block?
Yes - please make sure to include Mark explicitly in any discussions.
Cheers
Nick
: Danny Smith wrote:
: >But, rebuilding binutils-000718 after reverting the changes made to
: >gas/config/obj_coff.c
: >( http://sources.redhat.com/ml/binutils/2000-07/msg00226.html ) back to
: >binutils-000717 version, I can successfully build and link against dlls,
: >using either dllwrap or gcc -shared.
:
: Yes, rebuilding binutils-20000718-1 with the patch you mention
: reversed out, clears up the problems I'm seeing.
:
: Thanks,
:
: Eric Fifer
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [EFifer@sanwaint.com: RE: binutils prerelease available for testing (feedback needed)]
2000-07-20 12:22 [EFifer@sanwaint.com: RE: binutils prerelease available for testing (feedback needed)] Nick Clifton
@ 2000-07-20 12:59 ` Mark E.
[not found] ` <39773077.28196.4649D@localhost>
0 siblings, 1 reply; 4+ messages in thread
From: Mark E. @ 2000-07-20 12:59 UTC (permalink / raw)
To: binutils, dj
> : Danny Smith wrote:
> : >But, rebuilding binutils-000718 after reverting the changes made to
> : >gas/config/obj_coff.c
> : >( http://sources.redhat.com/ml/binutils/2000-07/msg00226.html ) back to
> : >binutils-000717 version, I can successfully build and link against dlls,
> : >using either dllwrap or gcc -shared.
> :
> : Yes, rebuilding binutils-20000718-1 with the patch you mention
> : reversed out, clears up the problems I'm seeing.
Interesting. Most of the changes go along with what's already being done in
the BFD version in obj_coff_endef . The first culprit I'd look would be this
change:
if (S_GET_STORAGE_CLASS (symp) == C_NULL)
{
if (!S_IS_DEFINED (symp) && !SF_GET_LOCAL (symp))
{
assert (S_GET_VALUE (symp) == 0);
S_SET_EXTERNAL (symp);
}
else if (S_GET_SEGMENT (symp) == text_section
&& symp != seg_info (text_section)->sym)
{
S_SET_STORAGE_CLASS (symp, C_LABEL);
}
else
{
S_SET_STORAGE_CLASS (symp, C_STAT);
}
}
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [EFifer@sanwaint.com: RE: binutils prerelease available for testing (feedback needed)]
[not found] ` <39773077.28196.4649D@localhost>
@ 2000-07-20 16:40 ` DJ Delorie
0 siblings, 0 replies; 4+ messages in thread
From: DJ Delorie @ 2000-07-20 16:40 UTC (permalink / raw)
To: snowball3; +Cc: binutils
> > Should I wait until you do some more debugging, or should I revert
> > your earlier patch now and let you submit a new one later?
>
> Go ahead and revert it. I'll submit a new one later.
I have reverted your patch.
2000-07-20 DJ Delorie <dj@redhat.com>
* config/obj-coff.c (obj_frob_symbol): revert previous change,
it breaks linking against DLLs.
2000-07-17 Mark Elbrecht <snowball3@bigfoot.com>
* config/obj-coff.c (obj_frob_symbol): Don't merge labels. Don't
merge if the symbol isn't constant. Don't call S_SET_EXTERNAL if
the storage class is already set.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [EFifer@sanwaint.com: RE: binutils prerelease available for testing (feedback needed)]
@ 2000-07-20 12:15 DJ Delorie
0 siblings, 0 replies; 4+ messages in thread
From: DJ Delorie @ 2000-07-20 12:15 UTC (permalink / raw)
To: binutils; +Cc: nickc
Can I revert this patch and put it back on the discussion block?
------- Start of forwarded message -------
Mailing-List: contact cygwin-help@sourceware.cygnus.com; run by ezmlm
Precedence: bulk
List-Subscribe: < mailto:cygwin-subscribe@sources.redhat.com >
List-Archive: < http://sources.redhat.com/ml/cygwin/ >
List-Post: < mailto:cygwin@sources.redhat.com >
List-Help: < mailto:cygwin-help@sources.redhat.com >, < http://sources.redhat.com/ml/#faqs >
Sender: cygwin-owner@sources.redhat.com
From: "Fifer, Eric" <EFifer@sanwaint.com>
To: cygwin@sources.redhat.com
Subject: RE: binutils prerelease available for testing (feedback needed)
Date: Thu, 20 Jul 2000 18:46:40 +0100
Content-Type: text/plain;
charset="iso-8859-1"
Danny Smith wrote:
>But, rebuilding binutils-000718 after reverting the changes made to
>gas/config/obj_coff.c
>( http://sources.redhat.com/ml/binutils/2000-07/msg00226.html ) back to
>binutils-000717 version, I can successfully build and link against dlls,
>using either dllwrap or gcc -shared.
Yes, rebuilding binutils-20000718-1 with the patch you mention
reversed out, clears up the problems I'm seeing.
Thanks,
Eric Fifer
- --
Want to unsubscribe from this list?
Send a message to cygwin-unsubscribe@sourceware.cygnus.com
------- End of forwarded message -------
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2000-07-20 16:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2000-07-20 12:22 [EFifer@sanwaint.com: RE: binutils prerelease available for testing (feedback needed)] Nick Clifton
2000-07-20 12:59 ` Mark E.
[not found] ` <39773077.28196.4649D@localhost>
2000-07-20 16:40 ` DJ Delorie
-- strict thread matches above, loose matches on Subject: below --
2000-07-20 12:15 DJ Delorie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).