From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eli Zaretskii To: msokolov@ivan.Harhan.ORG Cc: binutils@sources.redhat.com, gcc-patches@gcc.gnu.org, gdb-patches@sources.redhat.com Subject: Re: PATCH to top level: don't use dirname in configure Date: Sun, 23 Jul 2000 04:01:00 -0000 Message-id: <200007231101.HAA13289@indy.delorie.com> References: <0007221542.AA29888@ivan.Harhan.ORG> X-SW-Source: 2000-07/msg00420.html > Date: Sat, 22 Jul 00 10:42:11 CDT > From: msokolov@ivan.Harhan.ORG (Michael Sokolov) > > Eli Zaretskii wrote: > > > This assumes that (a) $(progname) always expands to "configure", and > > (b) that the last delimiter is '/'. I don't know whether the first > > assumption is true on each supported system, but the second might be > > wrong on DOS/Windows where a backslash might be used instead. > > Both of these assumptions are already being made extensively by the > rest of the very same Cygnus configure script. Perhaps all of those places should be fixed not to use a literal "configure". > My patch fixes an existing problem that must be fixed, and it cannot > introduce new problems that didn't exist before (as it does the same > thing the rest of the script does), therefore, it should be checked > in. I didn't say the patch shouldn't be checked in (it's something for the maintainers to decide), I just pointed out a possible regression that could happen, in case it would be missed. This is what these forums are for. If there's no regression, or if the regression is deemed not important, it's fine with me.