[chris@debian.org: Small aesthetic patch for objdump]

[chris@debian.org: Small aesthetic patch for objdump]

[H . J . Lu]

Ok to install?


H.J.
----- Forwarded message from "Christopher C. Chimelis" <chris@debian.org> -----

Envelope-to: hjl@valinux.com
Delivery-date: Sat, 29 Jul 2000 13:05:48 -0700
Date: Sat, 29 Jul 2000 16:05:45 -0400 (EDT)
From: "Christopher C. Chimelis" <chris@debian.org>
To: "H . J . Lu" <hjl@valinux.com>
Subject: Small aesthetic patch for objdump


Hey :-)

Below is a patch for objdump.c that properly sets the size of the
LONGEST_ARCH to the size of the "powerpc:common" string (since rs6000:6000
is no longer the longest.  This helps things line up better when doing an
'objdump -i' when binutils is compiled with multiple target archs.

I've had this for quite some time, but forgot to submit it for some
reason...

Thanks!
C

--- binutils-2.10.0.18.orig/binutils/objdump.c
+++ binutils-2.10.0.18/binutils/objdump.c
@@ -2613,7 +2613,7 @@
 }
 \f
 /* The length of the longest architecture name + 1.  */
-#define LONGEST_ARCH sizeof("rs6000:6000")
+#define LONGEST_ARCH sizeof("powerpc:common")
 
 static const char *
 endian_string (endian)


----- End forwarded message -----

-- 
H.J. Lu (hjl@gnu.org)

Re: [chris@debian.org: Small aesthetic patch for objdump]

[Geoff Keating]

> Date: Sat, 29 Jul 2000 16:13:02 -0700
> From: "H . J . Lu" <hjl@valinux.com>

> Ok to install?

This seems OK as far as it goes, but the real fix would be to
loop through all the actual architecture names and see which is the
longest.

-- 
- Geoffrey Keating <geoffk@cygnus.com>

Re: [chris@debian.org: Small aesthetic patch for objdump]

[Christopher C. Chimelis]

On Sat, 29 Jul 2000, Geoff Keating wrote:

> > Date: Sat, 29 Jul 2000 16:13:02 -0700
> > From: "H . J . Lu" <hjl@valinux.com>
> 
> > Ok to install?
> 
> This seems OK as far as it goes, but the real fix would be to
> loop through all the actual architecture names and see which is the
> longest.

Agreed.  I can generate a patch for this as well, if needed.  I patched it
this way only because I had a direct need at the time.

C

Re: [chris@debian.org: Small aesthetic patch for objdump]

[H . J . Lu]

On Sun, Jul 30, 2000 at 12:17:29AM -0400, Christopher C. Chimelis wrote:
> 
> On Sat, 29 Jul 2000, Geoff Keating wrote:
> 
> > > Date: Sat, 29 Jul 2000 16:13:02 -0700
> > > From: "H . J . Lu" <hjl@valinux.com>
> > 
> > > Ok to install?
> > 
> > This seems OK as far as it goes, but the real fix would be to
> > loop through all the actual architecture names and see which is the
> > longest.
> 
> Agreed.  I can generate a patch for this as well, if needed.  I patched it

Please do. Thanks.


H.J.

Re: [chris@debian.org: Small aesthetic patch for objdump]

[Nick Clifton]

Hi H.J.,

: Ok to install?

Sure.

Cheers
	Nick


: --- binutils-2.10.0.18.orig/binutils/objdump.c
: +++ binutils-2.10.0.18/binutils/objdump.c
: @@ -2613,7 +2613,7 @@
:  }
:  \f
:  /* The length of the longest architecture name + 1.  */
: -#define LONGEST_ARCH sizeof("rs6000:6000")
: +#define LONGEST_ARCH sizeof("powerpc:common")
:  
:  static const char *
:  endian_string (endian)

Re: [chris@debian.org: Small aesthetic patch for objdump]

[H . J . Lu]

On Sat, Jul 29, 2000 at 04:39:52PM -0700, Nick Clifton wrote:
> Hi H.J.,
> 
> : Ok to install?
> 
> Sure.
> 
> Cheers
> 	Nick
> 
> 
> : --- binutils-2.10.0.18.orig/binutils/objdump.c
> : +++ binutils-2.10.0.18/binutils/objdump.c
> : @@ -2613,7 +2613,7 @@
> :  }
> :  \f
> :  /* The length of the longest architecture name + 1.  */
> : -#define LONGEST_ARCH sizeof("rs6000:6000")
> : +#define LONGEST_ARCH sizeof("powerpc:common")
> :  
> :  static const char *
> :  endian_string (endian)
> 
> 

Done. Sorry for the long delay.

-- 
H.J. Lu (hjl@gnu.org)