* Re: [chris@debian.org: Small aesthetic patch for objdump]
@ 2000-07-29 16:39 Nick Clifton
2000-08-17 18:58 ` H . J . Lu
0 siblings, 1 reply; 6+ messages in thread
From: Nick Clifton @ 2000-07-29 16:39 UTC (permalink / raw)
To: hjl; +Cc: binutils
Hi H.J.,
: Ok to install?
Sure.
Cheers
Nick
: --- binutils-2.10.0.18.orig/binutils/objdump.c
: +++ binutils-2.10.0.18/binutils/objdump.c
: @@ -2613,7 +2613,7 @@
: }
: \f
: /* The length of the longest architecture name + 1. */
: -#define LONGEST_ARCH sizeof("rs6000:6000")
: +#define LONGEST_ARCH sizeof("powerpc:common")
:
: static const char *
: endian_string (endian)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [chris@debian.org: Small aesthetic patch for objdump]
2000-07-29 16:39 [chris@debian.org: Small aesthetic patch for objdump] Nick Clifton
@ 2000-08-17 18:58 ` H . J . Lu
0 siblings, 0 replies; 6+ messages in thread
From: H . J . Lu @ 2000-08-17 18:58 UTC (permalink / raw)
To: Nick Clifton; +Cc: binutils
On Sat, Jul 29, 2000 at 04:39:52PM -0700, Nick Clifton wrote:
> Hi H.J.,
>
> : Ok to install?
>
> Sure.
>
> Cheers
> Nick
>
>
> : --- binutils-2.10.0.18.orig/binutils/objdump.c
> : +++ binutils-2.10.0.18/binutils/objdump.c
> : @@ -2613,7 +2613,7 @@
> : }
> : \f
> : /* The length of the longest architecture name + 1. */
> : -#define LONGEST_ARCH sizeof("rs6000:6000")
> : +#define LONGEST_ARCH sizeof("powerpc:common")
> :
> : static const char *
> : endian_string (endian)
>
>
Done. Sorry for the long delay.
--
H.J. Lu (hjl@gnu.org)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [chris@debian.org: Small aesthetic patch for objdump]
2000-07-29 21:17 ` Christopher C. Chimelis
@ 2000-07-29 21:25 ` H . J . Lu
0 siblings, 0 replies; 6+ messages in thread
From: H . J . Lu @ 2000-07-29 21:25 UTC (permalink / raw)
To: Christopher C. Chimelis; +Cc: Geoff Keating, binutils, nickc
On Sun, Jul 30, 2000 at 12:17:29AM -0400, Christopher C. Chimelis wrote:
>
> On Sat, 29 Jul 2000, Geoff Keating wrote:
>
> > > Date: Sat, 29 Jul 2000 16:13:02 -0700
> > > From: "H . J . Lu" <hjl@valinux.com>
> >
> > > Ok to install?
> >
> > This seems OK as far as it goes, but the real fix would be to
> > loop through all the actual architecture names and see which is the
> > longest.
>
> Agreed. I can generate a patch for this as well, if needed. I patched it
Please do. Thanks.
H.J.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [chris@debian.org: Small aesthetic patch for objdump]
2000-07-29 18:56 ` Geoff Keating
@ 2000-07-29 21:17 ` Christopher C. Chimelis
2000-07-29 21:25 ` H . J . Lu
0 siblings, 1 reply; 6+ messages in thread
From: Christopher C. Chimelis @ 2000-07-29 21:17 UTC (permalink / raw)
To: Geoff Keating; +Cc: hjl, binutils, nickc
On Sat, 29 Jul 2000, Geoff Keating wrote:
> > Date: Sat, 29 Jul 2000 16:13:02 -0700
> > From: "H . J . Lu" <hjl@valinux.com>
>
> > Ok to install?
>
> This seems OK as far as it goes, but the real fix would be to
> loop through all the actual architecture names and see which is the
> longest.
Agreed. I can generate a patch for this as well, if needed. I patched it
this way only because I had a direct need at the time.
C
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [chris@debian.org: Small aesthetic patch for objdump]
2000-07-29 16:13 H . J . Lu
@ 2000-07-29 18:56 ` Geoff Keating
2000-07-29 21:17 ` Christopher C. Chimelis
0 siblings, 1 reply; 6+ messages in thread
From: Geoff Keating @ 2000-07-29 18:56 UTC (permalink / raw)
To: hjl; +Cc: binutils, nickc
> Date: Sat, 29 Jul 2000 16:13:02 -0700
> From: "H . J . Lu" <hjl@valinux.com>
> Ok to install?
This seems OK as far as it goes, but the real fix would be to
loop through all the actual architecture names and see which is the
longest.
--
- Geoffrey Keating <geoffk@cygnus.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [chris@debian.org: Small aesthetic patch for objdump]
@ 2000-07-29 16:13 H . J . Lu
2000-07-29 18:56 ` Geoff Keating
0 siblings, 1 reply; 6+ messages in thread
From: H . J . Lu @ 2000-07-29 16:13 UTC (permalink / raw)
To: binutils, nickc
Ok to install?
H.J.
----- Forwarded message from "Christopher C. Chimelis" <chris@debian.org> -----
Envelope-to: hjl@valinux.com
Delivery-date: Sat, 29 Jul 2000 13:05:48 -0700
Date: Sat, 29 Jul 2000 16:05:45 -0400 (EDT)
From: "Christopher C. Chimelis" <chris@debian.org>
To: "H . J . Lu" <hjl@valinux.com>
Subject: Small aesthetic patch for objdump
Hey :-)
Below is a patch for objdump.c that properly sets the size of the
LONGEST_ARCH to the size of the "powerpc:common" string (since rs6000:6000
is no longer the longest. This helps things line up better when doing an
'objdump -i' when binutils is compiled with multiple target archs.
I've had this for quite some time, but forgot to submit it for some
reason...
Thanks!
C
--- binutils-2.10.0.18.orig/binutils/objdump.c
+++ binutils-2.10.0.18/binutils/objdump.c
@@ -2613,7 +2613,7 @@
}
\f
/* The length of the longest architecture name + 1. */
-#define LONGEST_ARCH sizeof("rs6000:6000")
+#define LONGEST_ARCH sizeof("powerpc:common")
static const char *
endian_string (endian)
----- End forwarded message -----
--
H.J. Lu (hjl@gnu.org)
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2000-08-17 18:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2000-07-29 16:39 [chris@debian.org: Small aesthetic patch for objdump] Nick Clifton
2000-08-17 18:58 ` H . J . Lu
-- strict thread matches above, loose matches on Subject: below --
2000-07-29 16:13 H . J . Lu
2000-07-29 18:56 ` Geoff Keating
2000-07-29 21:17 ` Christopher C. Chimelis
2000-07-29 21:25 ` H . J . Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).