public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* Your change breaks ppc-linux
@ 2001-05-24 22:23 H . J . Lu
  2001-05-24 22:31 ` Eric Christopher
  2001-05-24 23:29 ` Geoff Keating
  0 siblings, 2 replies; 6+ messages in thread
From: H . J . Lu @ 2001-05-24 22:23 UTC (permalink / raw)
  To: binutils; +Cc: trix

I believe your patch breaks ppc-linux.


H.J.
----
2001-05-24  Tom Rix <trix@redhat.com>

        * Makefile.am coff-pmac bfd now defined in coff-rs6000.c
	xcoff-target.h not used to define rs6000 or ppc bfd.
	* Makefile.in same

	* bfd-in.h : (struct lineno_cache_entry) promote element "offset"
	to 64 bit.

	* coff-rs6000.c : Many changes for 64 bit support.  Move common
	32/64 code to xcofflink.c.  Explictly define the rs6000coff_vec
	and pmac_xcoff_vec

	* coff64-rs6000.c : Many changes for 64 bit support.  64 bit
	linker now supported.  Explictly define the rs6000coff64_vec.

	* coffcode.h : (coff_set_arch_mach_hook) xcoff 64 bit support
	(coff_print_aux) same 
	(coff_write_object_contents) same
	(coff_slurp_line_table) same

	* coffgen.c : (coff_fix_symbol_name) formatting
	(coff_mangle_symbols) xcoff 64 bit support
	(coff_write_symbol) same
	(coff_write_alien_symbol) same
	(coff_write_native_symbol) same
	(coff_write_symbols) same
	(coff_get_symbol_info) same
	(bfd_coff_get_syment) same
	(coff_print_symbol) same

	* config.bfd : add powerpc64-*-aix* target

	* libcoff-in.h : formatting

	* libcoff.h : move xcoff extern declarations to libxcoff.h

	* libxcoff.h : New file

	* xcofflink.c : Many changes for xcoff64 support.  Move common 
	structures to include/coff/xcoff.h.  Move specific structure to 
	backends coff-rs6000.c and coff64-rs6000.c.   Use new backend
	functions, defined in libxcoff.h, to isolate 32/64 dependencies.
	
	(bfd_xcoff_size_dynamic_sections) : special __rtinit symbol for 
	aix4.2+ -binitfini.

	(xcoff_build_ldsyms) : handle special __rtinit symbol.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Your change breaks ppc-linux
  2001-05-24 22:23 Your change breaks ppc-linux H . J . Lu
@ 2001-05-24 22:31 ` Eric Christopher
  2001-05-24 22:36   ` H . J . Lu
  2001-05-24 23:29 ` Geoff Keating
  1 sibling, 1 reply; 6+ messages in thread
From: Eric Christopher @ 2001-05-24 22:31 UTC (permalink / raw)
  To: H . J . Lu; +Cc: binutils, trix

On 24 May 2001 22:23:25 -0700, H . J . Lu wrote:
> I believe your patch breaks ppc-linux.
> 
I'm not doubting you, but where it is breaking would be useful :)
 
-eric


-- 
Pain is not the cleanser

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Your change breaks ppc-linux
  2001-05-24 22:31 ` Eric Christopher
@ 2001-05-24 22:36   ` H . J . Lu
  2001-05-24 22:42     ` Eric Christopher
  0 siblings, 1 reply; 6+ messages in thread
From: H . J . Lu @ 2001-05-24 22:36 UTC (permalink / raw)
  To: Eric Christopher; +Cc: binutils, trix

On Thu, May 24, 2001 at 10:37:22PM -0700, Eric Christopher wrote:
> On 24 May 2001 22:23:25 -0700, H . J . Lu wrote:
> > I believe your patch breaks ppc-linux.
> > 
> I'm not doubting you, but where it is breaking would be useful :)
>  

There are many undefined symbols. You can configure a cross binutils
to ppc-linux to see it.


H.J.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Your change breaks ppc-linux
  2001-05-24 22:36   ` H . J . Lu
@ 2001-05-24 22:42     ` Eric Christopher
  0 siblings, 0 replies; 6+ messages in thread
From: Eric Christopher @ 2001-05-24 22:42 UTC (permalink / raw)
  To: H . J . Lu; +Cc: binutils, trix

On 24 May 2001 22:36:16 -0700, H . J . Lu wrote:
> On Thu, May 24, 2001 at 10:37:22PM -0700, Eric Christopher wrote:
> > On 24 May 2001 22:23:25 -0700, H . J . Lu wrote:
> > > I believe your patch breaks ppc-linux.
> > > 
> > I'm not doubting you, but where it is breaking would be useful :)
> >  
> 
> There are many undefined symbols. You can configure a cross binutils
> to ppc-linux to see it.

:)

Thanks for the info.

-eric

-- 
Pain is not the cleanser

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Your change breaks ppc-linux
  2001-05-24 22:23 Your change breaks ppc-linux H . J . Lu
  2001-05-24 22:31 ` Eric Christopher
@ 2001-05-24 23:29 ` Geoff Keating
  2001-05-24 23:31   ` H . J . Lu
  1 sibling, 1 reply; 6+ messages in thread
From: Geoff Keating @ 2001-05-24 23:29 UTC (permalink / raw)
  To: hjl; +Cc: binutils, trix

> Date: Thu, 24 May 2001 22:23:25 -0700
> From: "H . J . Lu" <hjl@lucon.org>
> Cc: trix@redhat.com
> Content-Disposition: inline
> User-Agent: Mutt/1.2.5i
> 
> I believe your patch breaks ppc-linux.

Which bit?

It does seem, on the face of it, that it only changes files with
'coff' in the name.

> 2001-05-24  Tom Rix <trix@redhat.com>
> 
>         * Makefile.am coff-pmac bfd now defined in coff-rs6000.c
> 	xcoff-target.h not used to define rs6000 or ppc bfd.
> 	* Makefile.in same
> 
> 	* bfd-in.h : (struct lineno_cache_entry) promote element "offset"
> 	to 64 bit.
> 
> 	* coff-rs6000.c : Many changes for 64 bit support.  Move common
> 	32/64 code to xcofflink.c.  Explictly define the rs6000coff_vec
> 	and pmac_xcoff_vec
> 
> 	* coff64-rs6000.c : Many changes for 64 bit support.  64 bit
> 	linker now supported.  Explictly define the rs6000coff64_vec.
> 
> 	* coffcode.h : (coff_set_arch_mach_hook) xcoff 64 bit support
> 	(coff_print_aux) same 
> 	(coff_write_object_contents) same
> 	(coff_slurp_line_table) same
> 
> 	* coffgen.c : (coff_fix_symbol_name) formatting
> 	(coff_mangle_symbols) xcoff 64 bit support
> 	(coff_write_symbol) same
> 	(coff_write_alien_symbol) same
> 	(coff_write_native_symbol) same
> 	(coff_write_symbols) same
> 	(coff_get_symbol_info) same
> 	(bfd_coff_get_syment) same
> 	(coff_print_symbol) same
> 
> 	* config.bfd : add powerpc64-*-aix* target
> 
> 	* libcoff-in.h : formatting
> 
> 	* libcoff.h : move xcoff extern declarations to libxcoff.h
> 
> 	* libxcoff.h : New file
> 
> 	* xcofflink.c : Many changes for xcoff64 support.  Move common 
> 	structures to include/coff/xcoff.h.  Move specific structure to 
> 	backends coff-rs6000.c and coff64-rs6000.c.   Use new backend
> 	functions, defined in libxcoff.h, to isolate 32/64 dependencies.
> 	
> 	(bfd_xcoff_size_dynamic_sections) : special __rtinit symbol for 
> 	aix4.2+ -binitfini.
> 
> 	(xcoff_build_ldsyms) : handle special __rtinit symbol.
> 


-- 
- Geoffrey Keating <geoffk@geoffk.org>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Your change breaks ppc-linux
  2001-05-24 23:29 ` Geoff Keating
@ 2001-05-24 23:31   ` H . J . Lu
  0 siblings, 0 replies; 6+ messages in thread
From: H . J . Lu @ 2001-05-24 23:31 UTC (permalink / raw)
  To: Geoff Keating; +Cc: binutils, trix

On Thu, May 24, 2001 at 11:27:49PM -0700, Geoff Keating wrote:
> > Date: Thu, 24 May 2001 22:23:25 -0700
> > From: "H . J . Lu" <hjl@lucon.org>
> > Cc: trix@redhat.com
> > Content-Disposition: inline
> > User-Agent: Mutt/1.2.5i
> > 
> > I believe your patch breaks ppc-linux.
> 
> Which bit?
> 
> It does seem, on the face of it, that it only changes files with
> 'coff' in the name.

ppc-linux includes rs6000coff. Just build it for ppc-linux. My
automated build failed.


H.J.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2001-05-24 23:31 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-05-24 22:23 Your change breaks ppc-linux H . J . Lu
2001-05-24 22:31 ` Eric Christopher
2001-05-24 22:36   ` H . J . Lu
2001-05-24 22:42     ` Eric Christopher
2001-05-24 23:29 ` Geoff Keating
2001-05-24 23:31   ` H . J . Lu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).