"make check" failure with sh-linux

"make check" failure with sh-linux

[H . J . Lu]

I got one "make check" failure in ld with sh-linux:

FAIL: SH relaxing to S-records


H.J.

Re: "make check" failure with sh-linux

[kaz Kojima]

Hi,

"H . J . Lu" <hjl@lucon.org> wrote:
> I got one "make check" failure in ld with sh-linux:
> 
> FAIL: SH relaxing to S-records

This error comes from the defaulting entry addresses. It's set to
0x400000 with --oformat srec and 0x400080 for he ELF output format
in sh-linux case. How about the following patch to the test?

	kaz

Index: sh.exp
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-sh/sh.exp,v
retrieving revision 1.3
diff -u -r1.3 sh.exp
--- sh.exp	2001/03/13 06:14:28	1.3
+++ sh.exp	2001/05/27 11:35:12
@@ -56,7 +56,14 @@
 
 set testsrec "SH relaxing to S-records"
 
-if ![ld_simple_link $ld tmpdir/sh1.s1 "-relax --oformat srec tmpdir/sh1.o"] {
+if [istarget sh*-linux-gnu] {
+    # This target needs the explicit entry address.
+    catch "exec $objdump -x tmpdir/sh1 | grep start\\ address | sed s/start\\ address//" entry_addr
+    set srec_relax_arg "-Ttext $entry_addr -relax --oformat srec tmpdir/sh1.o"
+} else {
+    set srec_relax_arg "-relax --oformat srec tmpdir/sh1.o"
+}
+if ![ld_simple_link $ld tmpdir/sh1.s1 $srec_relax_arg ] {
     fail $testsrec
 } else {
     # The file name is embedded in the S-records, so create both

Re: "make check" failure with sh-linux

[Nick Clifton]

Hi Kaz,

Thanks very much for submitting this patch.

> > FAIL: SH relaxing to S-records
> 
> This error comes from the defaulting entry addresses. It's set to
> 0x400000 with --oformat srec and 0x400080 for he ELF output format
> in sh-linux case. How about the following patch to the test?

I have applied your patch to the sources.

In the future, please could you enclose a suitable ChangeLog entry (in
plain text) along with the patch itself.

Cheers
        Nick

Re: "make check" failure with sh-linux

[kaz Kojima]

Hi,

Nick Clifton <nickc@cambridge.redhat.com> wrote:
>>> FAIL: SH relaxing to S-records
>> 
>> This error comes from the defaulting entry addresses. It's set to
>> 0x400000 with --oformat srec and 0x400080 for he ELF output format
>> in sh-linux case. How about the following patch to the test?
>
> I have applied your patch to the sources.

Thanks!

> In the future, please could you enclose a suitable ChangeLog entry (in
> plain text) along with the patch itself.

My bad. Sorry for the inconvenience.

	kaz