public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* PATCH: Check machine type for aout-cris
@ 2001-06-02 11:59 H . J . Lu
  2001-06-02 12:30 ` Hans-Peter Nilsson
  0 siblings, 1 reply; 3+ messages in thread
From: H . J . Lu @ 2001-06-02 11:59 UTC (permalink / raw)
  To: hp; +Cc: binutils

Any reason why aout-cris doesn't check machine type? The current aout-cris
will take any object files in the a.out format. I'd like to check this
patch.


H.J.
----
2001-06-02  H.J. Lu  <hjl@gnu.org>

	* aout-cris.c (MACHTYPE_OK): New. Defined.

Index: aout-cris.c
===================================================================
RCS file: /work/cvs/gnu/binutils/bfd/aout-cris.c,v
retrieving revision 1.1.1.4
diff -u -p -r1.1.1.4 aout-cris.c
--- aout-cris.c	2001/03/09 19:15:25	1.1.1.4
+++ aout-cris.c	2001/06/02 18:54:09
@@ -112,6 +112,8 @@ static boolean MY(set_sizes) PARAMS ((bf
 #define MY_get_section_contents aout_32_get_section_contents
 #endif
 
+#define MACHTYPE_OK(mtype) ((mtype) == M_CRIS)
+
 /* Include generic functions (some are overridden above).  */
 #include "aout32.c"
 #include "aout-target.h"

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: PATCH: Check machine type for aout-cris
  2001-06-02 11:59 PATCH: Check machine type for aout-cris H . J . Lu
@ 2001-06-02 12:30 ` Hans-Peter Nilsson
  2001-06-02 12:44   ` H . J . Lu
  0 siblings, 1 reply; 3+ messages in thread
From: Hans-Peter Nilsson @ 2001-06-02 12:30 UTC (permalink / raw)
  To: hjl; +Cc: hans-peter.nilsson, binutils

> Date: Sat, 2 Jun 2001 11:59:38 -0700
> From: "H . J . Lu" <hjl@lucon.org>

> 2001-06-02  H.J. Lu  <hjl@gnu.org>
> 
> 	* aout-cris.c (MACHTYPE_OK): New. Defined.

Approved, thanks.

If you're in cleanup mode, it looks like several other a.out
files, for example aout-arm.c, aout-tic30.c and aout-ns32k.c
could use a MACHTYPE_OK definition too.

brgds, H-P

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: PATCH: Check machine type for aout-cris
  2001-06-02 12:30 ` Hans-Peter Nilsson
@ 2001-06-02 12:44   ` H . J . Lu
  0 siblings, 0 replies; 3+ messages in thread
From: H . J . Lu @ 2001-06-02 12:44 UTC (permalink / raw)
  To: Hans-Peter Nilsson; +Cc: binutils

On Sat, Jun 02, 2001 at 09:30:00PM +0200, Hans-Peter Nilsson wrote:
> > Date: Sat, 2 Jun 2001 11:59:38 -0700
> > From: "H . J . Lu" <hjl@lucon.org>
> 
> > 2001-06-02  H.J. Lu  <hjl@gnu.org>
> > 
> > 	* aout-cris.c (MACHTYPE_OK): New. Defined.
> 
> Approved, thanks.

Done.

> 
> If you're in cleanup mode, it looks like several other a.out
> files, for example aout-arm.c, aout-tic30.c and aout-ns32k.c
> could use a MACHTYPE_OK definition too.

The only reason I worked on it is it is included in cris-linux :-).


H.J.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2001-06-02 12:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-06-02 11:59 PATCH: Check machine type for aout-cris H . J . Lu
2001-06-02 12:30 ` Hans-Peter Nilsson
2001-06-02 12:44   ` H . J . Lu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).