From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Modra To: Geoff Keating Cc: binutils@sources.redhat.com Subject: Re: ppc64 binutils Date: Sun, 05 Aug 2001 21:37:00 -0000 Message-id: <20010806140735.A13226@bubble.sa.bigpond.net.au> References: <20010806115413.B960@bubble.sa.bigpond.net.au> <200108060319.UAA08319@geoffk.org> X-SW-Source: 2001-08/msg00095.html On Sun, Aug 05, 2001 at 08:19:41PM -0700, Geoff Keating wrote: > > This can't possibly be right. BFD_ARCH_SIZE is a property of the > host. Hmm, yes, you get BFD_ARCH_SIZE == 64 if either the host or target is 64 bit. That would make building the 32 bit target from a 64 bit host wrong. I'll see about a different solution. > --- binutils-ppc64.orig/binutils/testsuite/binutils-all/readelf.s-64 Fri Jul 6 11:42:20 2001 > +++ binutils-ppc64/binutils/testsuite/binutils-all/readelf.s-64 Wed > Aug 1 12:56:15 2001 > > Are you sure this change doesn't break the testcase on some > other target? It seems to reduce the inputs allowed. No, I'm not sure but did build a few 64 bit targets. Reducing the allowed inputs was intentional, and I suppose I should have said so in the ChangeLog. I figure that eg. [45][c4] was meant to match 4c or 54, as they were the values I found. > +++ binutils-ppc64/gas/ChangeLog.swox Wed Aug 1 13:40:49 2001 > > These should be folded into the toplevel ChangeLog, indented inside > the entry where the file is added. Sure. Wasn't that what I said? > +++ binutils-ppc64/gas/config/obj-elf.c Wed Aug 1 12:56:15 2001 > > This is another generic change. Could you please submit changes to > the generic part separately from the new port? Also submit changes to > the ppc config (that change the way the existing ppc stuff works) > separately from the changes that introduce the new port. OK. > +/* Read AIX assembly syntax? User selects it with command line option > + `-Saix'. Default is to allow just proper ELF syntax. */ > > If this is not needed (and never will be) by released FSF compilers, > there's no need to put it in the released FSF binutils. Anyone who is > using a patched compiler can presumably find the patched binutils. > > +++ binutils-ppc64/gas/testsuite/ChangeLog.swox Wed Aug 1 13:41:29 > 2001 > > It's good to see so many testcases! Some of which will need to be removed if -Saix goes. > +++ binutils-ppc64/ld/emulparams/crislinux.sh Wed Aug 1 12:56:16 2001 > > That certainly requires an explanation. > > +++ binutils-ppc64/ld/genscripts.sh Wed Aug 1 12:56:16 2001 > > Submit separately, please. OK. I intended to make the commit in a number of pieces, and this is one of the obvious bits to do separately. > + # PowerPc64 srec linker can't handle .toc relocations. > > Um, why? Lots of "relocation truncated to fit: R_PPC64_TOC16_DS toc", because the generic srec linker doesn't do any fancy relocations. > +++ binutils-ppc64/opcodes/ppc-opc.c Wed Aug 1 12:56:16 2001 > > I think this change really needs to come in two parts, one that does > the boring change of making the structure larger, and one that adds > new instructions. I was lazy, I admit it. Thanks for looking it over anyway. I'll commit a number of changes that provide extra infrastructure, and we'll go from there. Alan