From mboxrd@z Thu Jan  1 00:00:00 1970
From: "H . J . Lu" <hjl@lucon.org>
To: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Cc: binutils@sourceware.cygnus.com
Subject: Re: PATCH: Add bfd_sprintf_vma/bfd_fprintf_vma
Date: Fri, 10 Aug 2001 09:38:00 -0000
Message-id: <20010810093831.A8606@lucon.org>
References: <20010809090341.A18066@lucon.org> <Pine.GSO.3.96.1010810100549.2724C-100000@delta.ds2.pg.gda.pl>
X-SW-Source: 2001-08/msg00220.html

On Fri, Aug 10, 2001 at 10:11:20AM +0200, Maciej W. Rozycki wrote:
> On Thu, 9 Aug 2001, H . J . Lu wrote:
> 
> > +void
> > +bfd_sprintf_vma (abfd, buf, value)
> > +     bfd *abfd;
> > +     char *buf;
> > +     bfd_vma value;
> > +{
> > +  if (bfd_get_flavour (abfd) == bfd_target_elf_flavour)
> > +    return bfd_elf_sprintf_vma (abfd, buf, value);
>        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > +  sprintf_vma (buf, value);
> > +}
> 
>  I don't think returning a value from a void function is the cleanest idea
> ever.  Otherwise, I'll check the changes when my time permits.  Thanks. 

Fixed.


H.J.