public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Thiemo Seufer <ica2_ts@csv.ica.uni-stuttgart.de>
To: binutils@sources.redhat.com
Subject: [PATCH] Fix bfd ABI string for MIPS
Date: Wed, 15 Aug 2001 14:40:00 -0000	[thread overview]
Message-ID: <20010816034148.K381@rembrandt.csv.ica.uni-stuttgart.de> (raw)

Hi All,

currently bfd returns for the MIPS ABI string "N32" for every ELF
object with header flag EF_MIPS_ABI2 set and "64" for every ELF
object which is 64bit.

This means E_MIPS_ABI_O64 and E_MIPS_ABI_EABI64 are named wrongly
as "64", and an object with EF_MIPS_ABI2 and arbitrary other flags
set is also wrongly called "N32".

The patch below fixes this.


Thiemo


2001-08-16  Thiemo Seufer <seufer@csv.ica.uni-stuttgart.de>

	/bfd/ChangeLog
	* elf32-mips.c (elf_mips_abi_name): Return the right ABI string for
	E_MIPS_ABI_O64 and E_MIPS_ABI_EABI64


diff -BurPX /bigdisk/dl/src/binutils-exclude src-orig/bfd/elf32-mips.c src/bfd/elf32-mips.c
--- src-orig/bfd/elf32-mips.c	Mon Jun 18 21:48:24 2001
+++ src/bfd/elf32-mips.c	Thu Jun 21 07:45:18 2001
@@ -1928,16 +1928,16 @@
 {
   flagword flags;
 
-  if (ABI_N32_P (abfd))
-    return "N32";
-  else if (ABI_64_P (abfd))
-    return "64";
-
   flags = elf_elfheader (abfd)->e_flags;
   switch (flags & EF_MIPS_ABI)
     {
     case 0:
-      return "none";
+      if (ABI_N32_P (abfd))
+	return "N32";
+      else if (ABI_64_P (abfd))
+	return "64";
+      else
+	return "none";
     case E_MIPS_ABI_O32:
       return "O32";
     case E_MIPS_ABI_O64:

             reply	other threads:[~2001-08-15 14:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-08-15 14:40 Thiemo Seufer [this message]
2001-08-16  9:26 ` Eric Christopher
2001-08-16  9:41   ` Andrew Cagney
     [not found]     ` <20010816200837.W381@rembrandt.csv.ica.uni-stu>
2001-08-16 11:10     ` Thiemo Seufer
2001-08-24 11:57       ` Thiemo Seufer
2001-08-24 13:25         ` Eric Christopher
2001-08-24 13:39           ` Andrew Cagney
2001-08-24 13:43             ` Eric Christopher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010816034148.K381@rembrandt.csv.ica.uni-stuttgart.de \
    --to=ica2_ts@csv.ica.uni-stuttgart.de \
    --cc=binutils@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).