Re: [PATCH] Fix bfd ABI string for MIPS

[Thiemo Seufer <ica2_ts@csv.ica.uni-stuttgart.de>]

Andrew Cagney wrote:
> > On 16 Aug 2001 03:41:48 +0200, Thiemo Seufer wrote:
> > 
> >> Hi All,
> >> 
> >> currently bfd returns for the MIPS ABI string "N32" for every ELF
> >> object with header flag EF_MIPS_ABI2 set and "64" for every ELF
> >> object which is 64bit.

First of all, sorry for this bad description. It's not that bfd
returns this string to an client, it's use is internal to
elf32-mips.c. Having a closer look, it's in fact only used for
an error message about modules with incompatible ABI.

> >> This means E_MIPS_ABI_O64 and E_MIPS_ABI_EABI64 are named wrongly
> >> as "64", and an object with EF_MIPS_ABI2 and arbitrary other flags
> >> set is also wrongly called "N32".
> >> 
> >> The patch below fixes this.
> > 
> > I think this may have side effects.  How did you test this? gcc and gdb?
> > 
> > -eric
> > 
> 
> Yes, I wondered the same thing.  Here, I think it doesn't have an effect 
>   on GDB. GDB grubs aound in the bits in the elf header when determining 
> the ABI.  However, caution is definitly advised.

Sorry again. It definitely has no side effect except of putting out
the correct ABI names in the error message.


Thiemo