From: Thiemo Seufer <ica2_ts@csv.ica.uni-stuttgart.de>
To: binutils@sources.redhat.com
Subject: Re: [PATCH] Include alloca.h for bfd
Date: Thu, 23 Aug 2001 08:48:00 -0000 [thread overview]
Message-ID: <20010823174716.E3542@rembrandt.csv.ica.uni-stuttgart.de> (raw)
In-Reply-To: <m3y9oaj0x7.fsf@north-pole.nickc.cambridge.redhat.com>
Nick Clifton wrote:
> Hi Thiemo, Hi Ian,
>
> > In the past I did not permit alloca to be used in BFD, because on
> > systems which do not have alloca the version in libiberty would call
> > xmalloc, which might cause the program to crash when it ran out of
> > memory. I believe that BFD should never crash because it runs out of
> > memory; instead, it should return the appropriate error to the caller.
> > (That's why I wrote the objalloc interface when obstacks were changed
> > to no longer support a failure to allocate memory.) However, I do not
> > know what the current thinking is on alloca in BFD.
>
> I agree with your policy. I was unaware of the problems involved with
> using alloca, which is why I did not enforce the rule as you used to
> do. Now that I am aware of it I will try to enforce it in the future
> and also remove the current uses of alloca.
>
> Thiemo - rather than including alloca.h how about changing the code in
> linker.c to use objalloc_alloc() instead ?
It's a simple string, so I used bfd_malloc.
Thiemo
2001-08-23 Thiemo Seufer <seufer@csv.ica.uni-stuttgart.de>
/bfd/ChangeLog
* linker.c (_bfd_generic_link_add_archive_symbols): Replace alloca()
by bfd_malloc().
diff -BurpNX /bigdisk/src/binutils-exclude src-orig/bfd/linker.c src/bfd/linker.c
--- src-orig/bfd/linker.c Sat Aug 18 21:47:22 2001
+++ src/bfd/linker.c Thu Aug 23 17:14:45 2001
@@ -1007,9 +1007,10 @@ _bfd_generic_link_add_archive_symbols (a
let's look for its import thunk */
if (info->pei386_auto_import)
{
- char *buf = alloca (strlen (h->root.string) + 10);
+ char *buf = (char *) bfd_malloc (strlen (h->root.string) + 10);
sprintf (buf, "__imp_%s", h->root.string);
arh = archive_hash_lookup (&arsym_hash, buf, false, false);
+ free(buf);
}
if (arh == (struct archive_hash_entry *) NULL)
{
next prev parent reply other threads:[~2001-08-23 8:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-21 12:09 Thiemo Seufer
2001-08-21 13:20 ` Ian Lance Taylor
2001-08-21 14:46 ` Thiemo Seufer
2001-08-21 14:56 ` Ian Lance Taylor
2001-08-23 7:42 ` Nick Clifton
2001-08-23 8:48 ` Thiemo Seufer [this message]
2001-08-23 9:02 ` Jakub Jelinek
2001-08-23 9:15 ` Thiemo Seufer
2001-08-23 10:13 ` Andrew Cagney
2001-08-23 10:29 ` Ian Lance Taylor
2001-08-23 11:42 ` Andrew Cagney
2001-08-23 11:49 ` Jakub Jelinek
2001-08-23 10:16 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010823174716.E3542@rembrandt.csv.ica.uni-stuttgart.de \
--to=ica2_ts@csv.ica.uni-stuttgart.de \
--cc=binutils@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).