From: "H . J . Lu" <hjl@lucon.org>
To: Andrew Cagney <ac131313@cygnus.com>
Cc: binutils@sourceware.cygnus.com
Subject: Re: PATCH: Update nm.c for 64bit BFD on 32bit ELF files.
Date: Fri, 24 Aug 2001 16:45:00 -0000 [thread overview]
Message-ID: <20010824164507.A12244@lucon.org> (raw)
In-Reply-To: <3B86DFCE.2070605@cygnus.com>
On Fri, Aug 24, 2001 at 07:14:22PM -0400, Andrew Cagney wrote:
>
> > + char buf[30];
> >
> > if (! dynamic)
> > {
> > @@ -960,6 +966,9 @@ display_rel_file (abfd, archive_bfd)
> > return;
> > }
> >
> > + bfd_sprintf_vma (abfd, buf, (bfd_vma) -1);
> > + print_width = strlen (buf);
> > +
>
> Hmm, the most popular security hole and a generally popular bug is
> buffer overrun on the stack. Is hardwiring a buffer allocated of the
> stack and then sprintf() into it really a good idea?
We know bfd_sprintf_vma will at most print a 64bit address in hex.
H.J.
next prev parent reply other threads:[~2001-08-24 16:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-24 15:35 H . J . Lu
2001-08-24 16:14 ` Andrew Cagney
2001-08-24 16:45 ` H . J . Lu [this message]
2001-08-25 1:55 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010824164507.A12244@lucon.org \
--to=hjl@lucon.org \
--cc=ac131313@cygnus.com \
--cc=binutils@sourceware.cygnus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).