public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Thiemo Seufer <ica2_ts@csv.ica.uni-stuttgart.de>
To: binutils@sources.redhat.com
Subject: [PATCH] Code cleanup in tc-mips.c, addendum
Date: Sun, 26 Aug 2001 07:19:00 -0000	[thread overview]
Message-ID: <20010826161908.B13086@rembrandt.csv.ica.uni-stuttgart.de> (raw)

Hi All,

this fixes two checks for MAX_GPREL_OFFSET I've forgotten in the
last patch.


Thiemo


2001-08-26  Thiemo Seufer <seufer@csv.ica.uni-stuttgart.de>

	/gas/ChangeLog
	* tc_mips.c (load_address): Reflect change to MAX_GPREL_OFFSET.
	(macro): Likewise.


--- src-orig/gas/config/tc-mips.c	Sun Aug 26 15:22:58 2001
+++ src/gas/config/tc-mips.c	Sun Aug 26 16:10:28 2001
@@ -3330,7 +3330,7 @@
 	   lui		$reg,<sym>		(BFD_RELOC_HI16_S)
 	   addiu	$reg,$reg,<sym>		(BFD_RELOC_LO16)
 	 If we have an addend, we always use the latter form.  */
-      if ((valueT) ep->X_add_number >= MAX_GPREL_OFFSET
+      if ((valueT) ep->X_add_number > MAX_GPREL_OFFSET
 	  || nopic_need_relax (ep->X_add_symbol, 1))
 	p = NULL;
       else
@@ -4226,7 +4226,7 @@
 	       addiu	$tempreg,$tempreg,<sym>	(BFD_RELOC_LO16)
 	     If we have a constant, we need two instructions anyhow,
 	     so we may as well always use the latter form.  */
-	  if ((valueT) offset_expr.X_add_number >= MAX_GPREL_OFFSET
+	  if ((valueT) offset_expr.X_add_number > MAX_GPREL_OFFSET
 	      || nopic_need_relax (offset_expr.X_add_symbol, 1))
 	    p = NULL;
 	  else

             reply	other threads:[~2001-08-26  7:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-08-26  7:19 Thiemo Seufer [this message]
2001-08-27 11:51 ` Thiemo Seufer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010826161908.B13086@rembrandt.csv.ica.uni-stuttgart.de \
    --to=ica2_ts@csv.ica.uni-stuttgart.de \
    --cc=binutils@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).