* [PATCH] Code cleanup in tc-mips.c, addendum
@ 2001-08-26 7:19 Thiemo Seufer
2001-08-27 11:51 ` Thiemo Seufer
0 siblings, 1 reply; 2+ messages in thread
From: Thiemo Seufer @ 2001-08-26 7:19 UTC (permalink / raw)
To: binutils
Hi All,
this fixes two checks for MAX_GPREL_OFFSET I've forgotten in the
last patch.
Thiemo
2001-08-26 Thiemo Seufer <seufer@csv.ica.uni-stuttgart.de>
/gas/ChangeLog
* tc_mips.c (load_address): Reflect change to MAX_GPREL_OFFSET.
(macro): Likewise.
--- src-orig/gas/config/tc-mips.c Sun Aug 26 15:22:58 2001
+++ src/gas/config/tc-mips.c Sun Aug 26 16:10:28 2001
@@ -3330,7 +3330,7 @@
lui $reg,<sym> (BFD_RELOC_HI16_S)
addiu $reg,$reg,<sym> (BFD_RELOC_LO16)
If we have an addend, we always use the latter form. */
- if ((valueT) ep->X_add_number >= MAX_GPREL_OFFSET
+ if ((valueT) ep->X_add_number > MAX_GPREL_OFFSET
|| nopic_need_relax (ep->X_add_symbol, 1))
p = NULL;
else
@@ -4226,7 +4226,7 @@
addiu $tempreg,$tempreg,<sym> (BFD_RELOC_LO16)
If we have a constant, we need two instructions anyhow,
so we may as well always use the latter form. */
- if ((valueT) offset_expr.X_add_number >= MAX_GPREL_OFFSET
+ if ((valueT) offset_expr.X_add_number > MAX_GPREL_OFFSET
|| nopic_need_relax (offset_expr.X_add_symbol, 1))
p = NULL;
else
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Code cleanup in tc-mips.c, addendum
2001-08-26 7:19 [PATCH] Code cleanup in tc-mips.c, addendum Thiemo Seufer
@ 2001-08-27 11:51 ` Thiemo Seufer
0 siblings, 0 replies; 2+ messages in thread
From: Thiemo Seufer @ 2001-08-27 11:51 UTC (permalink / raw)
To: binutils
Thiemo Seufer wrote:
[snip]
> 2001-08-26 Thiemo Seufer <seufer@csv.ica.uni-stuttgart.de>
>
> /gas/ChangeLog
> * tc_mips.c (load_address): Reflect change to MAX_GPREL_OFFSET.
> (macro): Likewise.
I checked this in under the obvious fix rule.
Thiemo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2001-08-27 11:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-08-26 7:19 [PATCH] Code cleanup in tc-mips.c, addendum Thiemo Seufer
2001-08-27 11:51 ` Thiemo Seufer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).